From patchwork Fri Oct 19 09:43:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huaibin Wang X-Patchwork-Id: 47069 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5A5A11B444; Fri, 19 Oct 2018 11:43:39 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id EF22A25B3 for ; Fri, 19 Oct 2018 11:43:37 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id n11-v6so36635235wru.13 for ; Fri, 19 Oct 2018 02:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E97swbqyfTKbscuB2dOQa9RZVQZldh45ilEhNWiKPfY=; b=cVywHauHhU4+qBN9a7vGPx3+94beoPaLQJrGoRY0ZTsgZ2gQPuvEQtZ3vqDzKQCL+p fT2EhyKd+izjJmWAX5sxMbvfrXUWBbkZeZfEusr4k1jQqZI/zBcebz7k0NRftPr9bQ9f VLmZ4XWqtyKvdt3IeP33Dl4mXFjN57HkgQU5kWzXqvuFWlSiJdOn8xqBMesbYMitKW5m YqPHglrlYmCa2pR6/boNXmd9np0hCU+Yo81+KJYWoHJWcXxfic5h8sfzRXhzpZpVxqSr o4HwLiO2JPwY8aJr1gsdK1I6EyOCsY0FulwQm9Pje0HUuAFTjQXo6oUtFZyxQuA/PmGZ HtVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E97swbqyfTKbscuB2dOQa9RZVQZldh45ilEhNWiKPfY=; b=udUKGr05Gl4fYZaqNE92aS4Hg2aD66KdGPQuzkxHMrvVAV3VqeK5lryux1/1ho5qFt 8Bi4sKP/oeafCPIP6Oph3ckRhd6GSxoaZvI8JHkeRtE5zeHvyoH/mU7dhbDFe8GgShh/ Q5r1bKNd1C+tm6yT/5kQ/EHYSaPNz70Xj5b7Tlk9o6y8LDdML+Nv6ZgY1pHth1/+i/Cp c1TJSgh2k3XcuiUE0eF+2AY7utAQkUkqczFoIp82pHPtqMz8DIchFvtf91hfudN4BGum Pnz6N/smt/nnAxeuXU/4TZWLP+Kr4+548CSvPua8pYFhtnGVOY9+lDBwt5dX59XKQHZC aB2w== X-Gm-Message-State: ABuFfoiPRFU2JvTfmJaum2alZS308qfR0ym1PJJzri1sVPQ8Xq3jUDFo 1bT/2MvdUf7jXyPNULq8O5ypVDqXn40= X-Google-Smtp-Source: ACcGV6312s2wJ0t0RKh+nmxT0pK0F/Kj0OP8V30C/9FGvXBJ13vS97uP+uDdhHx5ASaFDvCEwLLTLA== X-Received: by 2002:adf:e387:: with SMTP id e7-v6mr33058741wrm.94.1539942217464; Fri, 19 Oct 2018 02:43:37 -0700 (PDT) Received: from cougar.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v129-v6sm1753981wme.45.2018.10.19.02.43.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Oct 2018 02:43:36 -0700 (PDT) From: Huaibin Wang To: dev@dpdk.org Cc: Beilei Xing , Qi Zhang , huaibin Wang , Laurent Hardy Date: Fri, 19 Oct 2018 11:43:13 +0200 Message-Id: <20181019094313.7013-1-huaibin.wang@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181016031405.28638-1-huaibin.wang@6wind.com> References: <20181016031405.28638-1-huaibin.wang@6wind.com> Subject: [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: huaibin Wang Promisc should not be disabled if the all multicast mode is enabled. Patch keeps the promiscuous on if all multicast mode is on, this behavior is also consistent with the implementation done on ixgbe pmd. Signed-off-by: huaibin Wang Signed-off-by: Laurent Hardy --- Cc: Beilei Xing Cc: Qi Zhang drivers/net/i40e/i40e_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index f7a685c8c..6c503debc 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous"); + /* must remain in all_multicast mode */ + if (dev->data->all_multicast == 1) + return; + status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid, false, NULL); if (status != I40E_SUCCESS)