From patchwork Wed Oct 17 09:12:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 46954 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35C291B110; Wed, 17 Oct 2018 11:12:31 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0050.outbound.protection.outlook.com [104.47.1.50]) by dpdk.org (Postfix) with ESMTP id 11617548B for ; Wed, 17 Oct 2018 11:12:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PaX4kBtrqOzhD0j1VFo9emWePjcXy/mYsIO9ainQNHw=; b=odcmyU1P9BMVSgb0kW71UisW3QXmmsu2A65Kagz/4CmxVr+SwuULmFBnbjzDJ2piTcJng7peu5TEBSZORq75jdnw9KIpGw9zUZ+8aypc2EBOx5mV+EgYlRhpzrReJoiOJhszDox42tn23sIpyYO41t3/tteDideTyVu/Re8fe84= Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by VI1PR04MB3103.eurprd04.prod.outlook.com (10.170.229.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.31; Wed, 17 Oct 2018 09:12:26 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::7988:5f2:be74:bf7a]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::7988:5f2:be74:bf7a%6]) with mapi id 15.20.1228.032; Wed, 17 Oct 2018 09:12:26 +0000 From: Shreyansh Jain To: "thomas@monjalon.net" CC: "dev@dpdk.org" , Shreyansh Jain Thread-Topic: [PATCH 1/3] common/dpaax: reduce logging level Thread-Index: AQHUZfmFrKCQ7UchREyNikIOr/r6Sg== Date: Wed, 17 Oct 2018 09:12:26 +0000 Message-ID: <20181017091151.15017-2-shreyansh.jain@nxp.com> References: <20181017091151.15017-1-shreyansh.jain@nxp.com> In-Reply-To: <20181017091151.15017-1-shreyansh.jain@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.142.187.166] x-mailer: git-send-email 2.17.1 x-clientproxiedby: BM1PR0101CA0062.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::24) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:71::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR04MB3103; 6:x2yfBlxBvSeu5/henshM1w6OmjWmulPuPZYjX1KiAZRjorZ4ktb1Z7El+NyfjfSrzajDCRLnXuTfCHl9Rq1+fKDKq5rWWbGJnExdfJ0TQN6vNOOPYm4G268dUzYGP7hj7tcWeWTW5fB38wSBlkhidjZLDHpsNh0e1WxMHIVdbTg2sSpZ5LO+5Tep1AG1zCMtGtIXeMgFCUXYNLQgjCGJT4OTfbBFk7xVnOrdpqZVvvuWwpnotjzwXLkIbzS+4h1nyDaGWIsT6dFTRbUAxDjLn/88C+vQqIIxaZ4WqhoaPpj5Ko4cuMEYcqfrzwt9U7Kez4Hs3+oRg0/ES2/7x9IT6C7lyzsSRbOGG71TVVG/9UgmqhkOaQS1Q36TKSx1NjaTqTHX4R+XjJkJy2/DXMA7FU2aOBsJeohizZvf2HVBDOa0ZnrSEtALUX8PVIEQWUQiD9hRkgDVW0y3O8IMOVYbew==; 5:2u3TQZOroEH2Lw9McgW06E3Oa+7GLQ25b1IBK+Fuy1d3ZbPtQNzyNt+OOSS3JpH5xu6mtFCTIj2t/nLkCSIwtI/8CPVQ9u0ga8AU9jnerxOlB5pHyEsKyU2EuOxFol9vp+NQKY9wvAMWRUa984/LodtkyvZK4Si+Vi+/dBkOVFw=; 7:5omrJO+kKdrcbSyxEjIswkQe9vcboWCIHwsVNwxnHvifRajbXz18W46su24EEqpORQe3pvhrmbdomtZhcLJxPYGG3yohZDl6yR+xRUWmd/TEFV7ScJ4ayp3+/3yv+jX8+nOCz5JqGhdvkYG+VZlElX8YblhwJQaDd0q4q5YuFtLZ6uIvwcmGQb6ymkyQkutiAP+m1Wa5ZQJbCqMk5G0+PWYW6hfD5I38JTNct21t90bLPWALBg/5G56qwDx/ELHL x-ms-office365-filtering-correlation-id: 84124589-ecec-4fa0-ccbc-08d63410a82b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB3103; x-ms-traffictypediagnostic: VI1PR04MB3103: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:VI1PR04MB3103; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB3103; x-forefront-prvs: 08286A0BE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(366004)(136003)(376002)(39860400002)(189003)(199004)(102836004)(76176011)(99286004)(44832011)(2900100001)(26005)(386003)(186003)(6506007)(14454004)(55236004)(54906003)(36756003)(316002)(2616005)(5250100002)(486006)(78486010)(478600001)(476003)(11346002)(81166006)(52116002)(8676002)(1730700003)(81156014)(86362001)(8936002)(14444005)(50226002)(256004)(68736007)(2906002)(446003)(66066001)(2501003)(6436002)(4326008)(6916009)(6486002)(6116002)(105586002)(106356001)(1076002)(3846002)(71200400001)(71190400001)(305945005)(25786009)(7736002)(5640700003)(6512007)(5660300001)(2351001)(53936002)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3103; H:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: oC1O1HVk07upODSQKPtOnsFce63DtJSKJs6oOYj/xtNBf9LpTjndZX7SCsSH5oaQk4tA8PqdPWFrLk7RiIydrvtRf2wyHn5X8ss4Ju4b7hyHyA0VseqlIEtGTud9JuJjet6goINS8RYErtgGor7bVXHqYPTAszc1nhqP0hfYM/gsLezK4F80S8qBrOdfPWL2ZCSLIIVvg+WDHIFPjk3SHMv3ZnrGhsPf2DA1bZHtu9pBQtg9uJKDPvI+xwdj2BAIbc9oNN/+5mnacI+bHqcoapec7kcF3VerCsnaNd94zVtoaPnT9DsDH61ZBbdbnREY0vqW1wWkypRR6sl6VDBH3rMKcgIOeLPSdhvhYqlX2Ck= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84124589-ecec-4fa0-ccbc-08d63410a82b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2018 09:12:26.8360 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3103 Subject: [dpdk-dev] [PATCH 1/3] common/dpaax: reduce logging level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Shreyansh Jain --- drivers/common/dpaax/dpaax_iova_table.c | 35 +++++++++++++------------ 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c index 075053b1a..213f75dff 100644 --- a/drivers/common/dpaax/dpaax_iova_table.c +++ b/drivers/common/dpaax/dpaax_iova_table.c @@ -69,8 +69,8 @@ read_memory_node(unsigned int *count) ret = glob(MEM_NODE_PATH_GLOB, 0, NULL, &result); if (ret != 0) { - DPAAX_ERR("Unable to glob device-tree memory node: (%s)(%d)", - MEM_NODE_PATH_GLOB, ret); + DPAAX_DEBUG("Unable to glob device-tree memory node: (%s)(%d)", + MEM_NODE_PATH_GLOB, ret); goto out; } @@ -78,8 +78,8 @@ read_memory_node(unsigned int *count) /* Either more than one memory@ node found, or none. * In either case, cannot work ahead. */ - DPAAX_ERR("Found (%zu) entries in device-tree. Not supported!", - result.gl_pathc); + DPAAX_DEBUG("Found (%zu) entries in device-tree. Not supported!", + result.gl_pathc); goto out; } @@ -87,28 +87,29 @@ read_memory_node(unsigned int *count) result.gl_pathv[0]); fd = open(result.gl_pathv[0], O_RDONLY); if (fd < 0) { - DPAAX_ERR("Unable to open the device-tree node: (%s)(fd=%d)", - MEM_NODE_PATH_GLOB, fd); + DPAAX_DEBUG("Unable to open the device-tree node: (%s)(fd=%d)", + MEM_NODE_PATH_GLOB, fd); goto cleanup; } /* Stat to get the file size */ ret = fstat(fd, &statbuf); if (ret != 0) { - DPAAX_ERR("Unable to get device-tree memory node size."); + DPAAX_DEBUG("Unable to get device-tree memory node size."); goto cleanup; } DPAAX_DEBUG("Size of device-tree mem node: %lu", statbuf.st_size); if (statbuf.st_size > MEM_NODE_FILE_LEN) { - DPAAX_WARN("More memory nodes available than assumed."); - DPAAX_WARN("System may not work properly!"); + DPAAX_DEBUG("More memory nodes available than assumed."); + DPAAX_DEBUG("System may not work properly!"); } ret = read(fd, file_data, statbuf.st_size > MEM_NODE_FILE_LEN ? MEM_NODE_FILE_LEN : statbuf.st_size); if (ret <= 0) { - DPAAX_ERR("Unable to read device-tree memory node: (%d)", ret); + DPAAX_DEBUG("Unable to read device-tree memory node: (%d)", + ret); goto cleanup; } @@ -117,15 +118,15 @@ read_memory_node(unsigned int *count) */ *count = (statbuf.st_size / 16); if ((*count) <= 0 || (statbuf.st_size % 16 != 0)) { - DPAAX_ERR("Invalid memory node values or count. (size=%lu)", - statbuf.st_size); + DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)", + statbuf.st_size); goto cleanup; } /* each entry is of 16 bytes, and size/16 is total count of entries */ nodes = malloc(sizeof(struct reg_node) * (*count)); if (!nodes) { - DPAAX_ERR("Failure in allocating working memory."); + DPAAX_DEBUG("Failure in allocating working memory."); goto cleanup; } memset(nodes, 0, sizeof(struct reg_node) * (*count)); @@ -420,9 +421,9 @@ dpaax_memevent_cb(enum rte_mem_event type, const void *addr, size_t len, ret = dpaax_iova_table_update(phys_addr, 0, map_len); if (ret != 0) { - DPAAX_ERR("PA-Table entry update failed. " - "Map=%d, addr=%p, len=%zu, err:(%d)", - type, va, map_len, ret); + DPAAX_DEBUG("PA-Table entry update failed. " + "Map=%d, addr=%p, len=%zu, err:(%d)", + type, va, map_len, ret); return; } @@ -460,5 +461,5 @@ RTE_INIT(dpaax_log) { dpaax_logger = rte_log_register("pmd.common.dpaax"); if (dpaax_logger >= 0) - rte_log_set_level(dpaax_logger, RTE_LOG_NOTICE); + rte_log_set_level(dpaax_logger, RTE_LOG_ERR); }