diff mbox series

test: fix compilation error in external memory test

Message ID 20181017002244.6117-1-dg@adax.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series test: fix compilation error in external memory test |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Dan Gora Oct. 17, 2018, 12:22 a.m. UTC 
  Fix a compilation error in test_external_mem.c:

  CC test_external_mem.o
test_external_mem.c: In function ‘test_external_mem’:
test_external_mem.c:375:2: error: ‘for’ loop initial declarations are
                           only allowed in C99 mode

  for (int i = 0; i < n_pages; i++) {
  ^
test_external_mem.c:375:2: note: use option -std=c99 or -std=gnu99 to
                           compile your code

Fixes: b270daa43b3d ("test: support external memory")
Cc: anatoly.burakov@intel.com

Signed-off-by: Dan Gora <dg@adax.com>
---
 test/test/test_external_mem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Anatoly Burakov Oct. 17, 2018, 10:12 a.m. UTC | #1 
On 17-Oct-18 1:22 AM, Dan Gora wrote:
> Fix a compilation error in test_external_mem.c:
> 
>    CC test_external_mem.o
> test_external_mem.c: In function ‘test_external_mem’:
> test_external_mem.c:375:2: error: ‘for’ loop initial declarations are
>                             only allowed in C99 mode
> 
>    for (int i = 0; i < n_pages; i++) {
>    ^
> test_external_mem.c:375:2: note: use option -std=c99 or -std=gnu99 to
>                             compile your code
> 
> Fixes: b270daa43b3d ("test: support external memory")
> Cc: anatoly.burakov@intel.com
> 
> Signed-off-by: Dan Gora <dg@adax.com>
> ---

Oops

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Thomas Monjalon Oct. 23, 2018, 9:09 a.m. UTC | #2 
17/10/2018 12:12, Burakov, Anatoly:
> On 17-Oct-18 1:22 AM, Dan Gora wrote:
> > Fix a compilation error in test_external_mem.c:
> > 
> >    CC test_external_mem.o
> > test_external_mem.c: In function ‘test_external_mem’:
> > test_external_mem.c:375:2: error: ‘for’ loop initial declarations are
> >                             only allowed in C99 mode
> > 
> >    for (int i = 0; i < n_pages; i++) {
> >    ^
> > test_external_mem.c:375:2: note: use option -std=c99 or -std=gnu99 to
> >                             compile your code
> > 
> > Fixes: b270daa43b3d ("test: support external memory")
> > Cc: anatoly.burakov@intel.com
> > 
> > Signed-off-by: Dan Gora <dg@adax.com>
> > ---
> 
> Oops
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/test/test/test_external_mem.c b/test/test/test_external_mem.c
index d0837aa35..998cafa68 100644
--- a/test/test/test_external_mem.c
+++ b/test/test/test_external_mem.c
@@ -362,6 +362,7 @@  test_external_mem(void)
 	rte_iova_t iova[len / pgsz];
 	void *addr;
 	int ret, n_pages;
+	int i;
 
 	/* create external memory area */
 	n_pages = RTE_DIM(iova);
@@ -372,7 +373,7 @@  test_external_mem(void)
 			__func__, __LINE__);
 		return -1;
 	}
-	for (int i = 0; i < n_pages; i++) {
+	for (i = 0; i < n_pages; i++) {
 		/* arbitrary IOVA */
 		rte_iova_t tmp = 0x100000000 + i * pgsz;
 		iova[i] = tmp;