net/ixgbe_ipsec: prevent ic_session leak on failure
Checks
Commit Message
For function ixgbe_crypto_create_session, fetches ic_session from the
mempool. But on failure scenarios, the object is not released back to
mempool. Using rte_mempool_put the ic_session is put back to mempool.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
drivers/net/ixgbe/ixgbe_ipsec.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
On 10/12/2018 10:53 AM, Vipin Varghese wrote:
> For function ixgbe_crypto_create_session, fetches ic_session from the
> mempool. But on failure scenarios, the object is not released back to
> mempool. Using rte_mempool_put the ic_session is put back to mempool.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Radu Nicolau
> Sent: Tuesday, October 16, 2018 6:32 AM
> To: Varghese, Vipin <vipin.varghese@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; dev@dpdk.org; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe_ipsec: prevent ic_session leak on
> failure
>
>
>
> On 10/12/2018 10:53 AM, Vipin Varghese wrote:
> > For function ixgbe_crypto_create_session, fetches ic_session from the
> > mempool. But on failure scenarios, the object is not released back to
> > mempool. Using rte_mempool_put the ic_session is put back to mempool.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
> >
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -364,6 +364,7 @@ ixgbe_crypto_create_session(void *device,
conf->crypto_xform->aead.algo !=
RTE_CRYPTO_AEAD_AES_GCM) {
PMD_DRV_LOG(ERR, "Unsupported crypto transformation mode\n");
+ rte_mempool_put(mempool, (void *)ic_session);
return -ENOTSUP;
}
aead_xform = &conf->crypto_xform->aead;
@@ -373,6 +374,7 @@ ixgbe_crypto_create_session(void *device,
ic_session->op = IXGBE_OP_AUTHENTICATED_DECRYPTION;
} else {
PMD_DRV_LOG(ERR, "IPsec decryption not enabled\n");
+ rte_mempool_put(mempool, (void *)ic_session);
return -ENOTSUP;
}
} else {
@@ -380,6 +382,7 @@ ixgbe_crypto_create_session(void *device,
ic_session->op = IXGBE_OP_AUTHENTICATED_ENCRYPTION;
} else {
PMD_DRV_LOG(ERR, "IPsec encryption not enabled\n");
+ rte_mempool_put(mempool, (void *)ic_session);
return -ENOTSUP;
}
}
@@ -395,6 +398,7 @@ ixgbe_crypto_create_session(void *device,
if (ic_session->op == IXGBE_OP_AUTHENTICATED_ENCRYPTION) {
if (ixgbe_crypto_add_sa(ic_session)) {
PMD_DRV_LOG(ERR, "Failed to add SA\n");
+ rte_mempool_put(mempool, (void *)ic_session);
return -EPERM;
}
}