diff mbox series

[v1] eventdev: fix build error

Message ID 20181009101322.83223-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] eventdev: fix build error |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Ferruh Yigit Oct. 9, 2018, 10:13 a.m. UTC 
  build error:
.../lib/librte_eventdev/rte_event_eth_tx_adapter.c:
  In function ‘txa_service_queue_del’:
.../lib/librte_eventdev/rte_event_eth_tx_adapter.c:800:7:
  error: ‘ret’ may be used uninitialized in this function
  [-Werror=maybe-uninitialized]
compilation terminated due to -Wfatal-errors.

https://mails.dpdk.org/archives/test-report/2018-October/065919.html

'ret' may be used uninitialized when 'dev->data->nb_tx_queues' is 0,
although this is not a practical value, initialize 'ret' to cover this
case.

Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Oct. 10, 2018, 7:43 p.m. UTC | #1 
09/10/2018 12:13, Ferruh Yigit:
> build error:
> .../lib/librte_eventdev/rte_event_eth_tx_adapter.c:
>   In function ‘txa_service_queue_del’:
> .../lib/librte_eventdev/rte_event_eth_tx_adapter.c:800:7:
>   error: ‘ret’ may be used uninitialized in this function
>   [-Werror=maybe-uninitialized]
> compilation terminated due to -Wfatal-errors.
> 
> https://mails.dpdk.org/archives/test-report/2018-October/065919.html
> 
> 'ret' may be used uninitialized when 'dev->data->nb_tx_queues' is 0,
> although this is not a practical value, initialize 'ret' to cover this
> case.
> 
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable@dpdk.org

The root cause is a new feature in 18.11, so no need to Cc stable.

> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied (without stable backport tag), thanks
diff mbox series

Patch

diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
index aae0378d5..3a21defba 100644
--- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
@@ -797,7 +797,7 @@  txa_service_queue_del(uint8_t id,
 
 	if (tx_queue_id == -1) {
 		uint16_t i;
-		int ret;
+		int ret = -1;
 
 		for (i = 0; i < dev->data->nb_tx_queues; i++) {
 			ret = txa_service_queue_del(id, dev, i);