[v2] event/dsw: fix icc build
Checks
Commit Message
Make the -Wno-format-nonliteral flag conditional, and only set in
clang and gcc builds, since this flag is not supported (nor needed)
when building dsw with icc.
Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/event/dsw/Makefile | 2 ++
1 file changed, 2 insertions(+)
Comments
-----Original Message-----
> Date: Thu, 4 Oct 2018 13:21:13 +0200
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, Mattias Rönnblom
> <mattias.ronnblom@ericsson.com>
> Subject: [PATCH v2] event/dsw: fix icc build
> X-Mailer: git-send-email 2.17.1
>
> Make the -Wno-format-nonliteral flag conditional, and only set in
> clang and gcc builds, since this flag is not supported (nor needed)
> when building dsw with icc.
>
> Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Applied to dpdk-next-eventdev/master. Thanks.
> drivers/event/dsw/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/event/dsw/Makefile b/drivers/event/dsw/Makefile
> index ea1e5259a..490ed0b98 100644
> --- a/drivers/event/dsw/Makefile
> +++ b/drivers/event/dsw/Makefile
> @@ -8,7 +8,9 @@ LIB = librte_pmd_dsw_event.a
> CFLAGS += -DALLOW_EXPERIMENTAL_API
> CFLAGS += -O3
> CFLAGS += $(WERROR_FLAGS)
> +ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
> CFLAGS += -Wno-format-nonliteral
> +endif
>
> LDLIBS += -lrte_eal
> LDLIBS += -lrte_mbuf
> --
> 2.17.1
>
@@ -8,7 +8,9 @@ LIB = librte_pmd_dsw_event.a
CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
+ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
CFLAGS += -Wno-format-nonliteral
+endif
LDLIBS += -lrte_eal
LDLIBS += -lrte_mbuf