diff mbox series

event/dsw: avoid supplying -Wno-format-nonliteral to icc

Message ID 20181003081353.6679-1-mattias.ronnblom@ericsson.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series event/dsw: avoid supplying -Wno-format-nonliteral to icc |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Mattias Rönnblom Oct. 3, 2018, 8:13 a.m. UTC 
  Make the -Wno-format-nonliteral flag conditional, and only set in
clang and gcc builds, since this flag is not supported (nor needed)
when building with icc.

Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
 drivers/event/dsw/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ferruh Yigit Oct. 3, 2018, 7:18 p.m. UTC | #1 
On 10/3/2018 9:13 AM, Mattias Rönnblom wrote:
> Make the -Wno-format-nonliteral flag conditional, and only set in
> clang and gcc builds, since this flag is not supported (nor needed)
> when building with icc.
> 
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

perhaps simply: "event/dsw: fix icc build"

Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon Oct. 4, 2018, 4:09 p.m. UTC | #2 
03/10/2018 21:18, Ferruh Yigit:
> On 10/3/2018 9:13 AM, Mattias Rönnblom wrote:
> > Make the -Wno-format-nonliteral flag conditional, and only set in
> > clang and gcc builds, since this flag is not supported (nor needed)
> > when building with icc.
> > 
> > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> 
> perhaps simply: "event/dsw: fix icc build"
> 
> Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
Thomas Monjalon Oct. 4, 2018, 4:30 p.m. UTC | #3 
04/10/2018 18:09, Thomas Monjalon:
> 03/10/2018 21:18, Ferruh Yigit:
> > On 10/3/2018 9:13 AM, Mattias Rönnblom wrote:
> > > Make the -Wno-format-nonliteral flag conditional, and only set in
> > > clang and gcc builds, since this flag is not supported (nor needed)
> > > when building with icc.
> > > 
> > > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > 
> > perhaps simply: "event/dsw: fix icc build"
> > 
> > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
> > 
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Applied, thanks

Cancelled as a v2 was applied in next-event tree.

Advices to avoid such confusion:
	- the v1 must be marked as superseded in patchwork
	- the v2 must be in the same thread thanks to --in-reply-to

And thanks Ferruh for spotting this :)
diff mbox series

Patch

diff --git a/drivers/event/dsw/Makefile b/drivers/event/dsw/Makefile
index ea1e5259a..490ed0b98 100644
--- a/drivers/event/dsw/Makefile
+++ b/drivers/event/dsw/Makefile
@@ -8,7 +8,9 @@  LIB = librte_pmd_dsw_event.a
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
+ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
 CFLAGS += -Wno-format-nonliteral
+endif
 
 LDLIBS += -lrte_eal
 LDLIBS += -lrte_mbuf