diff mbox series

[1/2] ethdev: add jump action to description table

Message ID 20181003015640.36306-2-yskoh@mellanox.com (mailing list archive)
State Changes Requested, archived
Delegated to: Shahaf Shuler
Headers
Series net/mlx5: support multiple groups and jump action |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

Yongseok Koh Oct. 3, 2018, 1:56 a.m. UTC 
  Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 app/test-pmd/config.c        | 2 +-
 lib/librte_ethdev/rte_flow.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Andrew Rybchenko Oct. 3, 2018, 7:12 a.m. UTC | #1 
On 10/3/18 4:56 AM, Yongseok Koh wrote:
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>   app/test-pmd/config.c        | 2 +-
>   lib/librte_ethdev/rte_flow.c | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 794aa5268..641ac5e17 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1141,7 +1141,7 @@ static const struct {
>   	MK_FLOW_ACTION(END, 0),
>   	MK_FLOW_ACTION(VOID, 0),
>   	MK_FLOW_ACTION(PASSTHRU, 0),
> -	MK_FLOW_ACTION(JUMP, 0),
> +	MK_FLOW_ACTION(JUMP, sizeof(struct rte_flow_action_jump)),
>   	MK_FLOW_ACTION(MARK, sizeof(struct rte_flow_action_mark)),
>   	MK_FLOW_ACTION(FLAG, 0),
>   	MK_FLOW_ACTION(QUEUE, sizeof(struct rte_flow_action_queue)),
> diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
> index cff4b5209..00ed67b5a 100644
> --- a/lib/librte_ethdev/rte_flow.c
> +++ b/lib/librte_ethdev/rte_flow.c
> @@ -80,6 +80,7 @@ static const struct rte_flow_desc_data rte_flow_desc_action[] = {
>   	MK_FLOW_ACTION(END, 0),
>   	MK_FLOW_ACTION(VOID, 0),
>   	MK_FLOW_ACTION(PASSTHRU, 0),
> +	MK_FLOW_ACTION(JUMP, sizeof(struct rte_flow_action_jump)),
>   	MK_FLOW_ACTION(MARK, sizeof(struct rte_flow_action_mark)),
>   	MK_FLOW_ACTION(FLAG, 0),
>   	MK_FLOW_ACTION(QUEUE, sizeof(struct rte_flow_action_queue)),

I think it should have Fixes tag and Cc to stable.
Yongseok Koh Oct. 3, 2018, 7:31 a.m. UTC | #2 
> On Oct 3, 2018, at 12:12 AM, Andrew Rybchenko <arybchenko@solarflare.com> wrote:
> 
> On 10/3/18 4:56 AM, Yongseok Koh wrote:
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>> 
>> ---
>>  app/test-pmd/config.c        | 2 +-
>>  lib/librte_ethdev/rte_flow.c | 1 +
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>> index 794aa5268..641ac5e17 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -1141,7 +1141,7 @@ static const struct {
>>  	MK_FLOW_ACTION(END, 0),
>>  	MK_FLOW_ACTION(VOID, 0),
>>  	MK_FLOW_ACTION(PASSTHRU, 0),
>> -	MK_FLOW_ACTION(JUMP, 0),
>> +	MK_FLOW_ACTION(JUMP, sizeof(struct rte_flow_action_jump)),
>>  	MK_FLOW_ACTION(MARK, sizeof(struct rte_flow_action_mark)),
>>  	MK_FLOW_ACTION(FLAG, 0),
>>  	MK_FLOW_ACTION(QUEUE, sizeof(struct rte_flow_action_queue)),
>> diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
>> index cff4b5209..00ed67b5a 100644
>> --- a/lib/librte_ethdev/rte_flow.c
>> +++ b/lib/librte_ethdev/rte_flow.c
>> @@ -80,6 +80,7 @@ static const struct rte_flow_desc_data rte_flow_desc_action[] = {
>>  	MK_FLOW_ACTION(END, 0),
>>  	MK_FLOW_ACTION(VOID, 0),
>>  	MK_FLOW_ACTION(PASSTHRU, 0),
>> +	MK_FLOW_ACTION(JUMP, sizeof(struct rte_flow_action_jump)),
>>  	MK_FLOW_ACTION(MARK, sizeof(struct rte_flow_action_mark)),
>>  	MK_FLOW_ACTION(FLAG, 0),
>>  	MK_FLOW_ACTION(QUEUE, sizeof(struct rte_flow_action_queue)),
>> 
> 
> I think it should have Fixes tag and Cc to stable.

Agree.

Thanks,
Yongseok
diff mbox series

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 794aa5268..641ac5e17 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1141,7 +1141,7 @@  static const struct {
 	MK_FLOW_ACTION(END, 0),
 	MK_FLOW_ACTION(VOID, 0),
 	MK_FLOW_ACTION(PASSTHRU, 0),
-	MK_FLOW_ACTION(JUMP, 0),
+	MK_FLOW_ACTION(JUMP, sizeof(struct rte_flow_action_jump)),
 	MK_FLOW_ACTION(MARK, sizeof(struct rte_flow_action_mark)),
 	MK_FLOW_ACTION(FLAG, 0),
 	MK_FLOW_ACTION(QUEUE, sizeof(struct rte_flow_action_queue)),
diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index cff4b5209..00ed67b5a 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -80,6 +80,7 @@  static const struct rte_flow_desc_data rte_flow_desc_action[] = {
 	MK_FLOW_ACTION(END, 0),
 	MK_FLOW_ACTION(VOID, 0),
 	MK_FLOW_ACTION(PASSTHRU, 0),
+	MK_FLOW_ACTION(JUMP, sizeof(struct rte_flow_action_jump)),
 	MK_FLOW_ACTION(MARK, sizeof(struct rte_flow_action_mark)),
 	MK_FLOW_ACTION(FLAG, 0),
 	MK_FLOW_ACTION(QUEUE, sizeof(struct rte_flow_action_queue)),