diff mbox series

net/netvsc: check return from kvargs_process

Message ID 20180926093112.24235-1-sthemmin@microsoft.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/netvsc: check return from kvargs_process |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger Sept. 26, 2018, 9:31 a.m. UTC 
  Should check return value from processing latency value.

Coverity issue: 322104
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
Patch against dpdk-next-net

 drivers/net/netvsc/hn_ethdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit Oct. 1, 2018, 2:56 p.m. UTC | #1 
On 9/26/2018 10:31 AM, Stephen Hemminger wrote:
> Should check return value from processing latency value.
> 
> Coverity issue: 322104
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Fixes: a25d39a3eb69 ("net/netvsc: allow tuning latency with devargs")

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index b67cce1ba8f5..8845fc0e6176 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -167,6 +167,7 @@  static int hn_parse_args(const struct rte_eth_dev *dev)
 		NULL
 	};
 	struct rte_kvargs *kvlist;
+	int ret;
 
 	if (!devargs)
 		return 0;
@@ -180,9 +181,12 @@  static int hn_parse_args(const struct rte_eth_dev *dev)
 		return -EINVAL;
 	}
 
-	rte_kvargs_process(kvlist, "latency", hn_set_latency, hv);
+	ret = rte_kvargs_process(kvlist, "latency", hn_set_latency, hv);
+	if (ret)
+		PMD_DRV_LOG(ERR, "Unable to process latency arg\n");
+
 	rte_kvargs_free(kvlist);
-	return 0;
+	return ret;
 }
 
 /* Update link status.