diff mbox series

[v2,4/9] build: add Meson files for avf PMD

Message ID 20180911160903.27226-4-bluca@debian.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v2,1/9] build: add Meson file for TAP PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi Sept. 11, 2018, 4:08 p.m. UTC 
  Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
 drivers/net/avf/meson.build      | 15 +++++++++++++++
 drivers/net/meson.build          |  1 +
 3 files changed, 36 insertions(+)
 create mode 100644 drivers/net/avf/base/meson.build
 create mode 100644 drivers/net/avf/meson.build

Comments

Bruce Richardson Sept. 13, 2018, 1:24 p.m. UTC | #1 
On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote:
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
>  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
>  drivers/net/avf/meson.build      | 15 +++++++++++++++
>  drivers/net/meson.build          |  1 +
>  3 files changed, 36 insertions(+)
>  create mode 100644 drivers/net/avf/base/meson.build
>  create mode 100644 drivers/net/avf/meson.build
> 

After applying this patch, I get lots of unused variable warnings. Gcc 6.3
on debian, you'll be glad to know.

/Bruce
Luca Boccassi Sept. 13, 2018, 1:27 p.m. UTC | #2 
On Thu, 2018-09-13 at 14:24 +0100, Bruce Richardson wrote:
> On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote:
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
> >  drivers/net/avf/meson.build      | 15 +++++++++++++++
> >  drivers/net/meson.build          |  1 +
> >  3 files changed, 36 insertions(+)
> >  create mode 100644 drivers/net/avf/base/meson.build
> >  create mode 100644 drivers/net/avf/meson.build
> > 
> 
> After applying this patch, I get lots of unused variable warnings.
> Gcc 6.3
> on debian, you'll be glad to know.
> 
> /Bruce

Yep got the same, but I'll leave that for the AVF maintainers to have
fun with :-)
Bruce Richardson Sept. 13, 2018, 2:48 p.m. UTC | #3 
On Thu, Sep 13, 2018 at 02:27:54PM +0100, Luca Boccassi wrote:
> On Thu, 2018-09-13 at 14:24 +0100, Bruce Richardson wrote:
> > On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote:
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > >  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
> > >  drivers/net/avf/meson.build      | 15 +++++++++++++++
> > >  drivers/net/meson.build          |  1 +
> > >  3 files changed, 36 insertions(+)
> > >  create mode 100644 drivers/net/avf/base/meson.build
> > >  create mode 100644 drivers/net/avf/meson.build
> > > 
> > 
> > After applying this patch, I get lots of unused variable warnings.
> > Gcc 6.3
> > on debian, you'll be glad to know.
> > 
> > /Bruce
> 
> Yep got the same, but I'll leave that for the AVF maintainers to have
> fun with :-)
> 
Ok, I've sent a patch to remove the unused stuff.
http://patches.dpdk.org/patch/44694/

I think this file still needs "cflags += '-Wno-strict-aliasing'" to make it
work though, since those errors are tougher to remove. There also needs to
be an "INC_VECTOR" define inside the x86-specific block, as is done for the
IXGBE and I40E drivers.

/Bruce
diff mbox series

Patch

diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build
new file mode 100644
index 0000000000..90fd6b445f
--- /dev/null
+++ b/drivers/net/avf/base/meson.build
@@ -0,0 +1,20 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
+
+sources = [
+	'avf_adminq.c',
+	'avf_common.c',
+]
+
+error_cflags = ['-Wno-pointer-to-int-cast']
+c_args = cflags
+foreach flag: error_cflags
+	if cc.has_argument(flag)
+		c_args += flag
+	endif
+endforeach
+
+base_lib = static_library('avf_base', sources,
+	dependencies: static_rte_eal,
+	c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/avf/meson.build b/drivers/net/avf/meson.build
new file mode 100644
index 0000000000..d341f029b2
--- /dev/null
+++ b/drivers/net/avf/meson.build
@@ -0,0 +1,15 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+	'avf_ethdev.c',
+	'avf_rxtx.c',
+	'avf_rxtx_vec_sse.c',
+	'avf_vchnl.c',
+)
+if arch_subdir == 'x86'
+	sources += files('avf_rxtx_vec_sse.c')
+endif
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 68ac42d67c..28efeda0b6 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -3,6 +3,7 @@ 
 
 drivers = ['af_packet',
 	'ark',
+	'avf',
 	'avp',
 	'axgbe', 'bonding',
 	'bnx2x',