ethdev: deprecate DEFERRED device state
Checks
Commit Message
Add a deprecation notice to remove RTE_ETH_DEV_DEFERRED state, but this
is mostly a reminder because of a missing target.
It doesn't worth to break the ABI because of this change and removal
can be done when ethdev ABI version increased.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Thomas Monjalon <thomas@monjalon.net>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Matan Azrad <matan@mellanox.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
Comments
On 08/24/2018 05:51 PM, Ferruh Yigit wrote:
> Add a deprecation notice to remove RTE_ETH_DEV_DEFERRED state, but this
> is mostly a reminder because of a missing target.
> It doesn't worth to break the ABI because of this change and removal
> can be done when ethdev ABI version increased.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Thomas Monjalon <thomas@monjalon.net>
> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
> Cc: Matan Azrad <matan@mellanox.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index e2dbee317..9cd12ccd8 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -95,3 +95,7 @@ Deprecation Notices
>
> This is due to a lack of flexibility and reliance on a type unusable with
> C++ programs (struct rte_flow_desc).
> +
> +* ethdev: remove deprecated RTE_ETH_DEV_DEFERRED device state.
> + Since this is an enum filed in the middle, removing this field will break
> + the ABI, so removing postponed to next ethdev ABI version increase.
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
On 8/27/2018 4:00 PM, Andrew Rybchenko wrote:
> On 08/24/2018 05:51 PM, Ferruh Yigit wrote:
>> Add a deprecation notice to remove RTE_ETH_DEV_DEFERRED state, but this
>> is mostly a reminder because of a missing target.
>> It doesn't worth to break the ABI because of this change and removal
>> can be done when ethdev ABI version increased.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
>> Cc: Matan Azrad <matan@mellanox.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index e2dbee317..9cd12ccd8 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -95,3 +95,7 @@ Deprecation Notices
>>
>> This is due to a lack of flexibility and reliance on a type unusable with
>> C++ programs (struct rte_flow_desc).
>> +
>> +* ethdev: remove deprecated RTE_ETH_DEV_DEFERRED device state.
>> + Since this is an enum filed in the middle, removing this field will break
>> + the ABI, so removing postponed to next ethdev ABI version increase.
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
In this release we already break the ABI for ethdev, instead of putting this
deprecation notice in, I will send a patch to remove RTE_ETH_DEV_DEFERRED, since
it is not used in current code, it should be trivial and safe change.
@@ -95,3 +95,7 @@ Deprecation Notices
This is due to a lack of flexibility and reliance on a type unusable with
C++ programs (struct rte_flow_desc).
+
+* ethdev: remove deprecated RTE_ETH_DEV_DEFERRED device state.
+ Since this is an enum filed in the middle, removing this field will break
+ the ABI, so removing postponed to next ethdev ABI version increase.