From patchwork Thu Aug 2 21:00:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 43540 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 83BE41B509; Thu, 2 Aug 2018 23:00:24 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10078.outbound.protection.outlook.com [40.107.1.78]) by dpdk.org (Postfix) with ESMTP id 49ED61B502; Thu, 2 Aug 2018 23:00:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Bz2x0ydajsb90hJi+ZuvuHXXCTgb3JV8m8HxQtZFXI=; b=oz4z8CDW2rY9udwGeDfg+JYIvmkpmfmlxBkqNKMfLHqQsYDcQDSg20eKE8mTsSv5jJyC840OY1zc5uO7sTOcWBD78C/dMQ3hk4N9d06IenhdknPBTi9S2I5utcjtKR0LdBD0KKpZ7MHRsuSM3uiFjYHUVcd6UKwCo+fqmM5EDAM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB6PR0501MB2038.eurprd05.prod.outlook.com (2603:10a6:4:6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Thu, 2 Aug 2018 21:00:20 +0000 From: Yongseok Koh To: shahafs@mellanox.com Cc: dev@dpdk.org, Yongseok Koh , stable@dpdk.org Date: Thu, 2 Aug 2018 14:00:07 -0700 Message-Id: <20180802210007.10671-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR1001CA0032.namprd10.prod.outlook.com (2603:10b6:405:28::45) To DB6PR0501MB2038.eurprd05.prod.outlook.com (2603:10a6:4:6::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4180ab07-63ce-4553-228b-08d5f8baf5a1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0501MB2038; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2038; 3:u3saC9QLUc9Rn7BV/itOFe/CyGla5eqvQmOCgjK4EAdX25rJAsDnK4E3GPeXLdiTbJ/TM3rJ+XK/iaOQBg5kB7Jb2YZ0V1HxWgwSXEhkbn08nC/gULi3UzexUc8Wbv/m0XLvuNQYDsEQlnX0J+mzZREHPsaMxvxkZ7WcdfIQojh6Gd8ndbl3emXxe9BIrNM3/MqeY6+DB0JPYza3jRynXlV2vPI6IXo8gZ41EhfpDH4dQURofTcXwaMcnsWcNkPB; 25:ip+PoXXfqBaEfEXq2UqfBjb4qYJLSXxsZSOJtkrlDlSczCjo206mi88eCc7BHTl1p7JCbJpTAroLEc/jTDM6ecuoKPqv6U+4m4HD82WPR84CKT0Nc2JWCPWMho+/iHe0aV8e2PG5qluvdvRTVPv9JLICen54P9pN1KAr1Q7DnGZJt8V3uDiDaPAM/Ler1ILFn2+yohO8nDNYru1s5dF2R3ztPYPHbnepd8wZmPbihIgUTmuEie1NHCDVM3g1Hzv643MsPVWePNVmU/f9eIfEZ0jrhpl6/w4YjuJqZzA3o02rcIFWnt/M4EKJ88lJ1AnFRDq3nq6UaA19rNAnataf6Q==; 31:RaZbMd+s5HlK5al9LdyFbrjLw3Lcagyo9d8K4UILMUAjQVtGROq14ElqLK36a05hK+w0emXBYnwMHVSoQCnhY7gBVyWRz4+9Sd/Bjmp6/y2YTkJlqAe3XbNgk74FYxfzm1FuEb4g04ZsKspFEmatpxNVYrDx/MK4H7Fwm51ake/rr1kb69kBKN59vc/H2Xg2Kh3zqujQriA/vS89+xMGlUS74ySS2LwVinmaFxN0pPI= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2038: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2038; 20:+c3PM88US2aifYKp4P4foOuwkY6/ByWDsWMOmSnNM6jr9UOhjpwJsOYycCEuIMfIdPIgj2cEeyGcxPCa266MYluHljyniRmJ0O7ZhstIjK4Seh7Pdyp6LBL5+WFaBgfy4nQewCTzzW6XirB40Ud6V4r//gn2mZsNnw3WOgfDGmhpcKIMCa4jKPJckd09DPNUayh/fHJG0tuZDEIqrbOrmcsubgNQnLd5Yg25EQAAp3qI6QPJqKAEgDCOIGQsOYbUTaN4UIm76rdTOhdkoDh0nd4YI0AEPeBaFYKXWyWHdcEI59lgTakyzn5ncC3C6htEhwngdBFBDrCG6e+g9meTYJGSrCotZaQ1hw0aouitnXiyaOWQ1mkgqQuSA8xrpr1QbfHbSSqke+iG8Dbj1B5DFGFKStOF/mzi4HUnLnH0PR9lsMyWI5bJGEFsOxCmZhYZlVCPTFBVh1H9jeNblVg51d8Eh4YA2BUk7Yrgs0QALRD4nkYvBiXLxI8Uok7/wlkW; 4:JVEWIPk+ueZa3i7hKEg3oXd3K7eEoxAPVMkItN/oitORqwdCIngXr4hCOnvEsA1v8leUF+wnIPNg6q8oY8osMTczseKvOSHle9j/yZRf36pHUjpLV/kDNpO5uNI8ZKC2JYYvr+W7/T77VCK/YotRSMUNXKIGnZHY11TIe9zXFYgk1fp640yOfROtgDT78kBSP75m8kYx1krZFBuYcsn9/lIM7ZYW7JeHJa9zfvJUxIBKYBkjvf9nY2HIiQzuOnvzwwo0o6YgXCs+2SiiydXjl4kwjFeGkyy8RwvFGGU8RoVS9LS6zzk6UiKQI6UUqloD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(131327999870524); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DB6PR0501MB2038; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2038; X-Forefront-PRVS: 07521929C1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(346002)(376002)(366004)(396003)(39860400002)(199004)(189003)(2906002)(1857600001)(26005)(34206002)(486006)(956004)(2616005)(6666003)(476003)(2361001)(6636002)(16526019)(1076002)(25786009)(21086003)(4326008)(450100002)(478600001)(36756003)(6116002)(575784001)(386003)(3846002)(97736004)(7736002)(305945005)(5660300001)(86362001)(55016002)(66066001)(81156014)(106356001)(105586002)(48376002)(50466002)(2351001)(81166006)(47776003)(8676002)(69596002)(68736007)(51416003)(52116002)(53936002)(7696005)(16586007)(37006003)(316002)(50226002)(14444005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2038; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2038; 23:IJKEPbpvHe0W9cypUr+8aAUKlURPDY6cB2Nfhvx?= e6XNJn9PFjlErZkIUleZI6xDVCuGu9lo/pZ7NvCIhp9pqG4yBP5Izore+ykeg219aE+J0PdwqvT9Vqt6A0Uqy9nc9eR7Moo3nOiY36zI89SuTKN7UCyCoS4o5ncXVYxuzHaMyf7Er3r6eb1QZ3piFp7JPNzLJ5pBwM/uxLcLk0xl6XL1x5TiPQ4YGvnY0qb+vQLoilNrxQFYobP09NDmDShq9zQOhPxEMsI7nC3HUB1vfSMudJUXZ+XaYZlWEEBos5y9gIIPo0mJAWmNN4uhDYIIK7T0hE65HSQWZWojfFEYZ7mj4o00RJgeILOEr/wA1AF49S/3a1CKmjKy5wcV6qAolKzPi0KQakAIt5kYO8pGdyBDf1imybFnIRQ5wFm4wRhgiNWHxLqQxA9sjREi3Rnr3bGmEOeRpCX2tdGU26MVmi+azYb8gN91Z1lYMFnzb1fEqbEPWrWCaZYLI+a1XPpTHyK0SB8CgM/ejKYpYr6R917VOCRZeHAiQOibvZNbBlu6lzuaQTQnyqsNnLrA+v+poJ61gBcGN95Q+cOp6/uRPQ7yDUzwdZcDQKzUYWGbppuVPF1BMOkguhMOkHehcX/XKIqg6gubYrhgSdBXkWYg/zu508fFT/U4SQSiNr191xljWZEPRHcLuN0UKXnb9AhayZMRNaWB8BWA37cwYJ8t+dP0chvp/vj5k7A6rYrumF1B2fEEGjkL7llMc4HPzYXmxVtSsJNzyFxhSc6rvMfdOfNd7WRLk67QnOuZFea68lQKCO0WaLc/7xykxQp5ecFIzBM4otw6SvACjqdSPL8oxH1mU3NtLrk+noJTZnTbIBm9b+n3Sc4Xd0z9UUnEvuN7wTmsGc9KSPKFwPrt8pTXpgUtmMZ2QYn6WfKzYhIM6opJSpgtMyBdgFAklYwdDRjJWEA8TC5S4Z+MAkXJMCaoAGzujasMkKRoLOn0kqS4KnFzAyhv34mVpwIyEyhknLG7bcGnL3WeQTnvwbgFQAzGvyJBL/dZo2usYlaN+zY1BuZJiFeClovh/tUcPUpH2g8J26OZn0lfVM8qciVbZUmg8CaZNVhobiGmYaFnfwMar/Ll04LFrdRwvmysP6eVyUaa6Go2WZPrwXCPwyaGvsWgTtOjKlDJF0gQG/TJhYWdFH83tmF5MM+ZLunbwXkaizCabH6XwLwCLrHg1chUm+dkwN/pIXnAdzvGAT/IUc0dfMwAHrcocFbkAUc8grpnHup+nHI2cqmR0RrdOhjuRz9heO4gKKthluzMFabVD4oR4VQc= X-Microsoft-Antispam-Message-Info: 4bBO92G3uwWqKDcGccDPAzYDFxeiwYVdw+djFbS9RGoDo3n1qJbsygHyia7eNnAAIZZFOkXbwad4ziU3TSAgdYko+X93+oUR3ZiIL+1EJUEYOzIajunLcvohH0RNPYTGsTLlUP0Ipn8dsuI5qf0zTqOeWS52MViXVzs1Cz/69qwK4bOnm+HUBILebJ92MCv/hx3Rek8vRnTQD0Vs+CD/ISl4zLHg3PoSj7L/fbktY+wnfVUAH7YobY3DiqIqTnywAODUqU0Uc1qenFEMzjoHL9I2r5jwm90BicxP6WCoIyof1eCvH1KgyZt3raE4T4A/Om8tM8PdQgZVJBByUcIcLe5KLkb29eoJnC4pzfBe0OM= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2038; 6:cC49czbU4iepGTk8PTWDfH7BTneUz0pDobkACKmPcK8y5naHZw/Y7qnV4lNMRPY7HQBNeSbeF7mMhU038rAaa015biQp1Q18TwBH9vlTyjII7dSPhWgP0/LQzfNxlRku/iJ8DEMXjgA1+ywBSg6miahPF99Fx929RrcHdau2otPvVNPd8i3H3KnzYL/6JhpcTonaK2gX49IL4FZIp01wpKKhg+vDVXHqf2wAOwJL1tgm8y33to0I3ITp7Og/6GIcMZAjdquJbAvMq0f43vJFcwZ9k0UKQkc9EpRaI9HdoRHJ51DQAr2Y6D4QqiWtFxWKXJGf51R+HK3sOy7ZqgTyPHXnljMoGXrlWAuwK7xk/RnZ2XhAe0ZYJ/8h3AkrajZYXZ2L741o6e2XPB0vGfv8UHirOX0sAv01To6VUzMIj8jifdsPH7aHsqjs0jNQQHbGPbIEDSyCiDK6V4qmd/I7JQ==; 5:LBeqwf3ihgCTZ/m/+lQUnrBBCVKI4ahkMkop3S8vGtDLfre3xkHgkgdhkKWL20sjdpNb+YW9uq43l2+V9CbmUtYs8xT4NSPZ8ZBLlVd0RhDpL04Yx4T9waxI7R06FCYeJcq18mHiM4q64Y7yjsTs3Q+Io2zmYoHEZD4Tx94zFlo=; 7:1IOXyGHwgj7vrYPxGhZ2xiawiBpxNMoQZSi8y/RmJafYeoROX1lU4iUOq/9QsWr7UTcbBMT5g9VvExIMeJ3OzoJRHmlA6kzEPmOFYFzVBRhkQEUKNtuabSCsjCXwBnMnlcEdHRGSRcjQRipmmlsDDBTJrcCFbAznbfSw3c1ZflSZxiY2Qtar4QeYlpXc+rkZ3Yn4dvCjUMdRGEcaXGmlYKUawJUxJ7A3ge561r4LoFggpttqUOUsGcohOsupkFIz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2018 21:00:20.1257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4180ab07-63ce-4553-228b-08d5f8baf5a1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2038 Subject: [dpdk-dev] [PATCH] net/mlx5: fix minimum number of Multi-Packet RQ buffers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If MPRQ is enabled, a PMD-private mempool is allocated. For ConnectX-4 Lx, the minimum number of strides is 512 which ConnectX-5 supports 8. This results in quite small number of elements for the MPRQ mempool. For example, if the size of Rx ring is configured as 512, only one MPRQ buffer can cover the whole ring. If there's only one Rx queue is configured. In the following code in mlx5_mprq_alloc_mp(), desc is 1 and obj_num will be 36 as a result. desc *= 4; obj_num = desc + MLX5_MPRQ_MP_CACHE_SZ * priv->rxqs_n; However, rte_mempool_create_empty() has a sanity check to refuse large per-lcore cache size compared to the number of elements. Cache flush threshold should not exceed the number of elements of a mempool. For the above example, the threshold is 32 * 1.5 = 48 which is larger than 36 and it fails to create the mempool. Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support") Cc: stable@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_defs.h | 2 +- drivers/net/mlx5/mlx5_rxq.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h index 439cc159f6..f2a1679511 100644 --- a/drivers/net/mlx5/mlx5_defs.h +++ b/drivers/net/mlx5/mlx5_defs.h @@ -126,7 +126,7 @@ #define MLX5_MPRQ_MIN_RXQS 12 /* Cache size of mempool for Multi-Packet RQ. */ -#define MLX5_MPRQ_MP_CACHE_SZ 32 +#define MLX5_MPRQ_MP_CACHE_SZ 32U /* Definition of static_assert found in /usr/include/assert.h */ #ifndef HAVE_STATIC_ASSERT diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 97b3e8ef0c..f785cdcebf 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -1234,6 +1234,13 @@ mlx5_mprq_alloc_mp(struct rte_eth_dev *dev) */ desc *= 4; obj_num = desc + MLX5_MPRQ_MP_CACHE_SZ * priv->rxqs_n; + /* + * rte_mempool_create_empty() has sanity check to refuse large cache + * size compared to the number of elemenets. + * CACHE_FLUSHTHRESH_MULTIPLIER is defined in a C file, so using a + * constant number 2 instead. + */ + obj_num = RTE_MAX(obj_num, MLX5_MPRQ_MP_CACHE_SZ * 2); /* Check a mempool is already allocated and if it can be resued. */ if (mp != NULL && mp->elt_size >= obj_size && mp->size >= obj_num) { DRV_LOG(DEBUG, "port %u mempool %s is being reused",