diff mbox series

test/power: fix 32-bit build

Message ID 20180713041240.2722-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Superseded, archived
Headers
Series test/power: fix 32-bit build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo July 13, 2018, 4:12 a.m. UTC 
  Compilation issue:

test/test/test_power_acpi_cpufreq.c:556:31:
error: format ‘%lx’ expects argument of type ‘long unsigned int’,
but argument 2 has type ‘uint64_t {aka long long unsigned int}’
-Werror=format=]

  printf("ACPI: Capabilities %lx\n", caps.capabilities);
                             ~~^     ~~~~~~~~~~~~~~~~~
                             %llx

Fixes: 39e38d583075 ("test/power: add unit test for get capabilities API")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 test/test/test_power_acpi_cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Radu Nicolau July 13, 2018, 12:36 p.m. UTC | #1 
On 7/13/2018 5:12 AM, Pablo de Lara wrote:
> Compilation issue:
>
> test/test/test_power_acpi_cpufreq.c:556:31:
> error: format ‘%lx’ expects argument of type ‘long unsigned int’,
> but argument 2 has type ‘uint64_t {aka long long unsigned int}’
> -Werror=format=]
>
>    printf("ACPI: Capabilities %lx\n", caps.capabilities);
>                               ~~^     ~~~~~~~~~~~~~~~~~
>                               %llx
>
> Fixes: 39e38d583075 ("test/power: add unit test for get capabilities API")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
De Lara Guarch, Pablo July 13, 2018, 12:52 p.m. UTC | #2 
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, July 13, 2018 5:13 AM
> To: Nicolau, Radu <radu.nicolau@intel.com>; Hunt, David
> <david.hunt@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] test/power: fix 32-bit build
> 
> Compilation issue:
> 
> test/test/test_power_acpi_cpufreq.c:556:31:
> error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2
> has type ‘uint64_t {aka long long unsigned int}’
> -Werror=format=]
> 
>   printf("ACPI: Capabilities %lx\n", caps.capabilities);
>                              ~~^     ~~~~~~~~~~~~~~~~~
>                              %llx
> 
> Fixes: 39e38d583075 ("test/power: add unit test for get capabilities API")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

NACK. Missing include. Will send v2.
diff mbox series

Patch

diff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c
index 6410969e0..ff908e4e1 100644
--- a/test/test/test_power_acpi_cpufreq.c
+++ b/test/test/test_power_acpi_cpufreq.c
@@ -553,7 +553,7 @@  test_power_acpi_caps(void)
 		return -1;
 	}
 
-	printf("ACPI: Capabilities %lx\n", caps.capabilities);
+	printf("ACPI: Capabilities %"PRIx64"\n", caps.capabilities);
 
 	rte_power_unset_env();
 	return 0;