From patchwork Tue Jul 3 10:31:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 42144 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4691A1BEF4; Tue, 3 Jul 2018 12:32:09 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D4B0C1BEE9 for ; Tue, 3 Jul 2018 12:32:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 03:32:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,303,1526367600"; d="scan'208";a="63749953" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.223.223]) by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2018 03:32:05 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Date: Tue, 3 Jul 2018 11:31:17 +0100 Message-Id: <20180703103119.15747-7-bruce.richardson@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180703103119.15747-1-bruce.richardson@intel.com> References: <20180608163807.66737-1-bruce.richardson@intel.com> <20180703103119.15747-1-bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v2 6/8] examples/kni: fix dependency check for building with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rather than hard-coding the example app to be built only when a set of conditions are met, we can simplify things by having the app built when KNI library itself is available. That saves us duplicating the same set of restrictions on both library and example app. Fixes: 89f0711f9ddf ("examples: build some samples with meson") Signed-off-by: Bruce Richardson Series-acked-by: Hemant Agrawal Acked-by: Ferruh Yigit --- examples/kni/meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/examples/kni/meson.build b/examples/kni/meson.build index 0443ab99b..791316394 100644 --- a/examples/kni/meson.build +++ b/examples/kni/meson.build @@ -6,9 +6,8 @@ # To build this example as a standalone application with an already-installed # DPDK instance, use 'make' -if host_machine.system() != 'linux' - build = false -endif +# this app can be built if-and-only-if KNI library is buildable +build = dpdk_conf.has('RTE_LIBRTE_KNI') deps += ['kni', 'bus_pci'] sources = files( 'main.c'