diff mbox series

[v3,22/23] net/softnic: add firmware script

Message ID 20180627163123.135686-23-jasvinder.singh@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Cristian Dumitrescu
Headers
Series [v3,01/23] net/softnic: restructuring |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jasvinder Singh June 27, 2018, 4:31 p.m. UTC 
  Add default firmware script for softnic.

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 drivers/net/softnic/firmware.cli | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 drivers/net/softnic/firmware.cli

Comments

Pattan, Reshma June 28, 2018, 10:13 a.m. UTC | #1 
Hi Jasvinder,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Wednesday, June 27, 2018 5:31 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Iremonger,
> Bernard <bernard.iremonger@intel.com>
> Subject: [dpdk-dev] [PATCH v3 22/23] net/softnic: add firmware script
> 
> Add default firmware script for softnic.

Might need more description here or in the file itself.
Need to explain how to structure basic firmware for application designing using softnic?
This default firmware will always fail on other systems, so users have to edit this before starting using it to match with their system resources. 
We need to highlight that in commit message.

Thanks,
Reshma
Jasvinder Singh June 28, 2018, 10:18 a.m. UTC | #2 
> -----Original Message-----
> From: Pattan, Reshma
> Sent: Thursday, June 28, 2018 11:13 AM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v3 22/23] net/softnic: add firmware script
> 
> Hi Jasvinder,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> > Sent: Wednesday, June 27, 2018 5:31 PM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Iremonger,
> > Bernard <bernard.iremonger@intel.com>
> > Subject: [dpdk-dev] [PATCH v3 22/23] net/softnic: add firmware script
> >
> > Add default firmware script for softnic.
> 
> Might need more description here or in the file itself.
> Need to explain how to structure basic firmware for application designing using
> softnic?
> This default firmware will always fail on other systems, so users have to edit
> this before starting using it to match with their system resources.
> We need to highlight that in commit message.
> 

I will update testpmd documentation (in preparation) on how to configure and use softnic. Don't want to add extensive details in commit message.

Jasvinder
diff mbox series

Patch

diff --git a/drivers/net/softnic/firmware.cli b/drivers/net/softnic/firmware.cli
new file mode 100644
index 0000000..0524ca1
--- /dev/null
+++ b/drivers/net/softnic/firmware.cli
@@ -0,0 +1,21 @@ 
+; SPDX-License-Identifier: BSD-3-Clause
+; Copyright(c) 2018 Intel Corporation
+
+link LINK dev 0000:02:00.0
+
+pipeline RX period 10 offset_port_id 0 cpu 0
+pipeline RX port in bsz 32 link LINK rxq 0
+pipeline RX port out bsz 32 swq RXQ0
+pipeline RX table match stub
+pipeline RX port in 0 table 0
+pipeline RX table 0 rule add match default action fwd port 0
+
+pipeline TX period 10 offset_port_id 0 cpu 0
+pipeline TX port in bsz 32 swq TXQ0
+pipeline TX port out bsz 32 link LINK txq 0
+pipeline TX table match stub
+pipeline TX port in 0 table 0
+pipeline TX table 0 rule add match default action fwd port 0
+
+thread 1 pipeline RX enable
+thread 1 pipeline TX enable