[v6,7/7] devtools: expand meson cross compiling coverage
Checks
Commit Message
The default test script covers only default host cc compiler, either gcc or
clang, the fix is to cover both, gcc and clang. And also the build dirs are
changed to *-host-$c, indicating the difference of cc used.
Fixes: a55277a788 ("devtools: add test script for meson builds")
Cc: stable@dpdk.org
Signed-off-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Song Zhu <song.zhu@arm.com>
---
devtools/test-meson-builds.sh | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
Comments
On Thu, Jun 14, 2018 at 05:51:27PM +0800, Gavin Hu wrote:
> The default test script covers only default host cc compiler, either gcc or
> clang, the fix is to cover both, gcc and clang. And also the build dirs are
> changed to *-host-$c, indicating the difference of cc used.
>
> Fixes: a55277a788 ("devtools: add test script for meson builds")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Song Zhu <song.zhu@arm.com>
> ---
Given that the only native code we have in a cross-build is pmdinfogen,
doing two copies of each cross-build seems overkill, and makes the test
longer than it should be. I suggest that we just do one of the
cross-builds, e.g. the generic armv8 one, for both clang and gcc, and do
the others only once.
/Bruce
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Thursday, June 14, 2018 6:45 PM
> To: Gavin Hu <Gavin.Hu@arm.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 7/7] devtools: expand meson cross
> compiling coverage
>
> On Thu, Jun 14, 2018 at 05:51:27PM +0800, Gavin Hu wrote:
> > The default test script covers only default host cc compiler, either
> > gcc or clang, the fix is to cover both, gcc and clang. And also the
> > build dirs are changed to *-host-$c, indicating the difference of cc used.
> >
> > Fixes: a55277a788 ("devtools: add test script for meson builds")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Song Zhu <song.zhu@arm.com>
> > ---
> Given that the only native code we have in a cross-build is pmdinfogen, doing
> two copies of each cross-build seems overkill, and makes the test longer than
> it should be. I suggest that we just do one of the cross-builds, e.g. the generic
> armv8 one, for both clang and gcc, and do the others only once.
>
> /Bruce
[Gavin Hu] I submitted a new v8 patch for this, thanks, please help review again.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Thanks Bruce, I submitted v10 patch set fixing the whitespace issues.
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Thursday, June 14, 2018 6:45 PM
> To: Gavin Hu <Gavin.Hu@arm.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 7/7] devtools: expand meson cross
> compiling coverage
>
> On Thu, Jun 14, 2018 at 05:51:27PM +0800, Gavin Hu wrote:
> > The default test script covers only default host cc compiler, either
> > gcc or clang, the fix is to cover both, gcc and clang. And also the
> > build dirs are changed to *-host-$c, indicating the difference of cc used.
> >
> > Fixes: a55277a788 ("devtools: add test script for meson builds")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Song Zhu <song.zhu@arm.com>
> > ---
> Given that the only native code we have in a cross-build is pmdinfogen, doing
> two copies of each cross-build seems overkill, and makes the test longer than
> it should be. I suggest that we just do one of the cross-builds, e.g. the generic
> armv8 one, for both clang and gcc, and do the others only once.
>
> /Bruce
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
@@ -47,7 +47,10 @@ for f in config/arm/arm*gcc ; do
echo "## ERROR: aarch64-linux-gnu-gcc is missing..."
exit 1
fi
- export CC="ccache gcc"
- build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f
- unset CC
+ for c in gcc clang ; do
+ export CC="ccache $c"
+ build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-$c \
+ --cross-file $f
+ unset CC
+ done
done