diff mbox

[dpdk-dev] compressdev: clarify mbuf offsets

Message ID 20180522105432.36821-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo May 22, 2018, 10:54 a.m. UTC 
  Add extra clarification about offset in source and
destination mbuf used in compressdev, when they
are a chain of mbufs.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_compressdev/rte_comp.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Verma, Shally May 22, 2018, 11:40 a.m. UTC | #1 
>-----Original Message-----
>From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 22 May 2018 16:25
>To: fiona.trahe@intel.com; Gupta, Ashish <Ashish.Gupta@cavium.com>; Verma, Shally <Shally.Verma@cavium.com>
>Cc: dev@dpdk.org; Pablo de Lara <pablo.de.lara.guarch@intel.com>
>Subject: [PATCH] compressdev: clarify mbuf offsets
>
>Add extra clarification about offset in source and
>destination mbuf used in compressdev, when they
>are a chain of mbufs.
>
>Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>---
Reviewed-by: Shally Verma <shally.verma@caviumnetworks.com>
De Lara Guarch, Pablo May 22, 2018, 12:45 p.m. UTC | #2 
> -----Original Message-----
> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
> Sent: Tuesday, May 22, 2018 12:41 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] compressdev: clarify mbuf offsets
> 
> 
> 
> >-----Original Message-----
> >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com]
> >Sent: 22 May 2018 16:25
> >To: fiona.trahe@intel.com; Gupta, Ashish <Ashish.Gupta@cavium.com>;
> >Verma, Shally <Shally.Verma@cavium.com>
> >Cc: dev@dpdk.org; Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >Subject: [PATCH] compressdev: clarify mbuf offsets
> >
> >Add extra clarification about offset in source and destination mbuf
> >used in compressdev, when they are a chain of mbufs.
> >
> >Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >---
> Reviewed-by: Shally Verma <shally.verma@caviumnetworks.com>
> 

Applied to dpdk-next-crypto.
Thanks,

Pablo
Fiona Trahe May 22, 2018, 12:58 p.m. UTC | #3 
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, May 22, 2018 11:55 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; ashish.gupta@caviumnetworks.com;
> shally.verma@cavium.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] compressdev: clarify mbuf offsets
> 
> Add extra clarification about offset in source and
> destination mbuf used in compressdev, when they
> are a chain of mbufs.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
diff mbox

Patch

diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h
index 9826086b1..5b513c77e 100644
--- a/lib/librte_compressdev/rte_comp.h
+++ b/lib/librte_compressdev/rte_comp.h
@@ -315,6 +315,8 @@  struct rte_comp_op {
 		/**< Starting point for compression or decompression,
 		 * specified as number of bytes from start of packet in
 		 * source buffer.
+		 * This offset starts from the first segment
+		 * of the buffer, in case the m_src is a chain of mbufs.
 		 * Starting point for checksum generation in compress direction.
 		 */
 		uint32_t length;
@@ -328,7 +330,10 @@  struct rte_comp_op {
 		uint32_t offset;
 		/**< Starting point for writing output data, specified as
 		 * number of bytes from start of packet in dest
-		 * buffer. Starting point for checksum generation in
+		 * buffer.
+		 * This offset starts from the first segment
+		 * of the buffer, in case the m_dst is a chain of mbufs.
+		 * Starting point for checksum generation in
 		 * decompress direction.
 		 */
 	} dst;