diff mbox

[dpdk-dev] compressdev: remove unused driver id

Message ID 20180521223843.7003-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo May 21, 2018, 10:38 p.m. UTC 
  Driver id field is not set/used anywhere,
so it should be removed from rte_compressdev structure.

Fixes: ed7dd94f7f66 ("compressdev: add basic device management")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_compressdev/rte_compressdev_internal.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Fiona Trahe May 22, 2018, 9:26 a.m. UTC | #1 
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, May 21, 2018 11:39 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; ashish.gupta@caviumnetworks.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] compressdev: remove unused driver id
> 
> Driver id field is not set/used anywhere,
> so it should be removed from rte_compressdev structure.
> 
> Fixes: ed7dd94f7f66 ("compressdev: add basic device management")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
De Lara Guarch, Pablo May 22, 2018, 10:08 a.m. UTC | #2 
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, May 22, 2018 10:26 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> ashish.gupta@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] compressdev: remove unused driver id
> 
> 
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Monday, May 21, 2018 11:39 PM
> > To: Trahe, Fiona <fiona.trahe@intel.com>;
> > ashish.gupta@caviumnetworks.com
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH] compressdev: remove unused driver id
> >
> > Driver id field is not set/used anywhere, so it should be removed from
> > rte_compressdev structure.
> >
> > Fixes: ed7dd94f7f66 ("compressdev: add basic device management")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/lib/librte_compressdev/rte_compressdev_internal.h b/lib/librte_compressdev/rte_compressdev_internal.h
index 9ec44f2c1..22ceac66e 100644
--- a/lib/librte_compressdev/rte_compressdev_internal.h
+++ b/lib/librte_compressdev/rte_compressdev_internal.h
@@ -79,9 +79,6 @@  struct rte_compressdev {
 	struct rte_device *device;
 	/**< Backing device */
 
-	uint8_t driver_id;
-	/**< comp driver identifier*/
-
 	__extension__
 	uint8_t attached : 1;
 	/**< Flag indicating the device is attached */