From patchwork Mon May 14 14:46:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 40009 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE4011C8D1; Mon, 14 May 2018 16:47:02 +0200 (CEST) Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id BFF8C1C8D1; Mon, 14 May 2018 16:47:01 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 236D1406F123; Mon, 14 May 2018 14:47:01 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE7D42026DEF; Mon, 14 May 2018 14:47:00 +0000 (UTC) From: Aaron Conole To: stable@dpdk.org Cc: Alejandro Lucero , Luca Boccassi , Eelco Chaudron , Yuanhan Liu , dev@dpdk.org Date: Mon, 14 May 2018 10:46:58 -0400 Message-Id: <20180514144658.9671-1-aconole@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 14 May 2018 14:47:01 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 14 May 2018 14:47:01 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'aconole@redhat.com' RCPT:'' Subject: [dpdk-dev] [PATCH] nfp: restore the unlink operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For the stable versions of DPDK, the NFP driver's NSP user space driver was modified to account for non-root usage. When that happened, commit 515933ad8385 ("nfp: allow for non-root user") inadvertently removed the unlink() call. Fixes: 515933ad8385 ("nfp: allow for non-root user") Cc: Alejandro Lucero Cc: Luca Boccassi Cc: Eelco Chaudron Cc: Yuanhan Liu Signed-off-by: Aaron Conole Acked-by: Eelco Chaudron Acked-by: Alejandro Lucero --- drivers/net/nfp/nfp_nfpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c index ae2e07220..c003640c7 100644 --- a/drivers/net/nfp/nfp_nfpu.c +++ b/drivers/net/nfp/nfp_nfpu.c @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc) close(desc->lock); nspu_get_lockfile_path(lockname, sizeof(lockname), desc); + unlink(lockname); return 0; }