[dpdk-dev,v2,1/2] net/i40e: fix missing Port Representor data-path

  This patch adds Rx and Tx burst functions to the i40e Port
Representors, so that the implementation within this PMD
can be tested using applications such as testpmd which
require data-path functionality.

Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")

Signed-off-by: Remy Horton <remy.horton@intel.com>
---
 drivers/net/i40e/i40e_vf_representor.c | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)
  

On 11/05/2018 13:28, Remy Horton wrote:
> This patch adds Rx and Tx burst functions to the i40e Port
> Representors, so that the implementation within this PMD
> can be tested using applications such as testpmd which
> require data-path functionality.
>
> Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
>   drivers/net/i40e/i40e_vf_representor.c | 22 +++++++++++++++++++---
>   1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c
> index 96b3787..6026ec9 100644
> --- a/drivers/net/i40e/i40e_vf_representor.c
> +++ b/drivers/net/i40e/i40e_vf_representor.c
> @@ -337,6 +337,20 @@ struct eth_dev_ops i40e_representor_dev_ops = {
>   
>   };
>   
> +static uint16_t
> +i40e_vf_representor_rx_burst(__rte_unused void *rx_queue,
> +	__rte_unused struct rte_mbuf **rx_pkts, __rte_unused uint16_t nb_pkts)
> +{
> +	return 0;
> +}
> +
> +static uint16_t
> +i40e_vf_representor_tx_burst(__rte_unused void *tx_queue,
> +	__rte_unused struct rte_mbuf **tx_pkts, __rte_unused uint16_t nb_pkts)
> +{
> +	return 0;
> +}
> +
>   int
>   i40e_vf_representor_init(struct rte_eth_dev *ethdev, void *init_params)
>   {
> @@ -365,9 +379,11 @@ i40e_vf_representor_init(struct rte_eth_dev *ethdev, void *init_params)
>   	/* Set representor device ops */
>   	ethdev->dev_ops = &i40e_representor_dev_ops;
>   
> -	/* No data-path so no RX/TX functions */
> -	ethdev->rx_pkt_burst = NULL;
> -	ethdev->tx_pkt_burst = NULL;
> +	/* No data-path, but need stub Rx/Tx functions to avoid crash
> +	 * when testing with the likes of testpmd.
> +	 */
> +	ethdev->rx_pkt_burst = i40e_vf_representor_rx_burst;
> +	ethdev->tx_pkt_burst = i40e_vf_representor_tx_burst;
>   
>   	vf = &pf->vfs[representor->vf_id];
>   

Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
  

On 5/11/2018 3:04 PM, Mohammad Abdul Awal wrote:
> 
> 
> On 11/05/2018 13:28, Remy Horton wrote:
>> This patch adds Rx and Tx burst functions to the i40e Port
>> Representors, so that the implementation within this PMD
>> can be tested using applications such as testpmd which
>> require data-path functionality.
>>
>> Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
>>
>> Signed-off-by: Remy Horton <remy.horton@intel.com>

> Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>

Applied to dpdk-next-net/master, thanks.