[dpdk-dev] ethdev: fix meson build

Message ID 20180427090103.158725-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit April 27, 2018, 9:01 a.m. UTC
  kvargs dependency added to ehtdev which is not updated in meson build

Fixes: 9d5c2725ed8c ("ethdev: add common devargs parser")
Cc: remy.horton@intel.com

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_ethdev/meson.build | 2 +-
 lib/meson.build               | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
  

Comments

Thomas Monjalon April 27, 2018, 9:10 a.m. UTC | #1
27/04/2018 11:01, Ferruh Yigit:
> kvargs dependency added to ehtdev which is not updated in meson build
> 
> Fixes: 9d5c2725ed8c ("ethdev: add common devargs parser")
> Cc: remy.horton@intel.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Ack
I guess you want to squash it in next-net?
  
Ferruh Yigit April 27, 2018, 9:25 a.m. UTC | #2
On 4/27/2018 10:10 AM, Thomas Monjalon wrote:
> 27/04/2018 11:01, Ferruh Yigit:
>> kvargs dependency added to ehtdev which is not updated in meson build
>>
>> Fixes: 9d5c2725ed8c ("ethdev: add common devargs parser")
>> Cc: remy.horton@intel.com
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Ack
> I guess you want to squash it in next-net?
Squashed into relevant commit in next-net, thanks.
  

Patch

diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
index 12bdb6b61..aed5d2265 100644
--- a/lib/librte_ethdev/meson.build
+++ b/lib/librte_ethdev/meson.build
@@ -24,4 +24,4 @@  headers = files('rte_ethdev.h',
 	'rte_tm.h',
 	'rte_tm_driver.h')
 
-deps += ['net']
+deps += ['net', 'kvargs']
diff --git a/lib/meson.build b/lib/meson.build
index 0d58c556f..166905c1c 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -9,10 +9,9 @@ 
 # given as a dep, no need to mention ring. This is especially true for the
 # core libs which are widely reused, so their deps are kept to a minimum.
 libraries = [ 'compat', # just a header, used for versioning
-	'eal', 'ring', 'mempool', 'mbuf', 'net', 'ethdev', 'pci', # core
+	'eal', 'ring', 'mempool', 'mbuf', 'net', 'kvargs', 'ethdev', 'pci', # core
 	'metrics', # bitrate/latency stats depends on this
 	'hash',    # efd depends on this
-	'kvargs',  # cryptodev depends on this
 	'timer',   # eventdev depends on this
 	'acl', 'bbdev', 'bitratestats', 'cfgfile',
 	'cmdline', 'cryptodev',