[dpdk-dev,v2] net/i40e: fix checking offloading fail for Tx
Checks
Commit Message
Missing "return -ENOTSUP" will alays leads to
illegal offload passing through offload checking.
Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
rework fix line
---
drivers/net/i40e/i40e_rxtx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Friday, April 27, 2018 4:14 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Zhang, Qi Z; Dai, Wei; Wu, Yanglong
> Subject: [PATCH v2] net/i40e: fix checking offloading fail for Tx
>
> Missing "return -ENOTSUP" will alays leads to illegal offload passing through
> offload checking.
>
> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
@@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
" or supported offloads 0x%" PRIx64,
(void *)dev, tx_conf->offloads,
dev->data->dev_conf.txmode.offloads,
- dev_info.tx_offload_capa); }
+ dev_info.tx_offload_capa);
+ return -ENOTSUP;
+ }
if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);