From patchwork Fri Apr 27 01:41:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yanglong Wu X-Patchwork-Id: 39075 X-Patchwork-Delegate: helin.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6DF397EC0; Fri, 27 Apr 2018 03:46:52 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A112C7D0E for ; Fri, 27 Apr 2018 03:46:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 18:46:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,333,1520924400"; d="scan'208";a="49481802" Received: from wuyanglong.sh.intel.com ([10.67.111.162]) by fmsmga004.fm.intel.com with ESMTP; 26 Apr 2018 18:46:48 -0700 From: Yanglong Wu To: dev@dpdk.org Cc: helin.zhang@intel.com, qi.z.zhang@intel.com, wei.dai@intel.com, Yanglong Wu Date: Fri, 27 Apr 2018 09:41:45 +0800 Message-Id: <20180427014145.40693-1-yanglong.wu@intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180419063924.29802-1-yanglong.wu@intel.com> References: <20180419063924.29802-1-yanglong.wu@intel.com> Subject: [dpdk-dev] [PATCH v2] net/i40e: fix checking offloading fail for Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Missing "return -ENOTSUP" will alays leads to illegal offload passing through offload checking. Fixes: b43290f1ade2 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- drivers/net/i40e/i40e_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index bc660596b..2ce930827 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev, " or supported offloads 0x%" PRIx64, (void *)dev, tx_conf->offloads, dev->data->dev_conf.txmode.offloads, - dev_info.tx_offload_capa); } + dev_info.tx_offload_capa); + return -ENOTSUP; + } if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) { vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);