diff mbox

[dpdk-dev,1/2] net/dpaa: non supported offloads are ignored with warning

Message ID 20180420104541.21987-2-sunil.kori@nxp.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Sunil Kumar Kori April 20, 2018, 10:45 a.m. UTC 
  Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs")
Cc: sunil.kori@nxp.com

Signed-off-by: Sunil Kumar Kori <sunil.kori@nxp.com>
---
 drivers/net/dpaa/dpaa_ethdev.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Stephen Hemminger April 20, 2018, 3:20 p.m. UTC | #1 
On Fri, 20 Apr 2018 16:15:40 +0530
Sunil Kumar Kori <sunil.kori@nxp.com> wrote:

>  	dpaa_eth_dev_info(dev, &dev_info);
>  	if (((~(dev_info.rx_offload_capa) & rx_offloads) != 0)) {
> -		DPAA_PMD_ERR("Some Rx offloads are not supported "
> +		DPAA_PMD_WARN("Some Rx offloads are not supported "
>  			"requested 0x%" PRIx64 " supported 0x%" PRIx64,

The if statement has more parens than necessary.

Please don't break error messages across lines, it is better to have a long source
line since it allows users to use tools like grep to search for error messages.
diff mbox

Patch

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index b2740b4..b368f7e 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -151,17 +151,15 @@  dpaa_eth_dev_configure(struct rte_eth_dev *dev)
 
 	dpaa_eth_dev_info(dev, &dev_info);
 	if (((~(dev_info.rx_offload_capa) & rx_offloads) != 0)) {
-		DPAA_PMD_ERR("Some Rx offloads are not supported "
+		DPAA_PMD_WARN("Some Rx offloads are not supported "
 			"requested 0x%" PRIx64 " supported 0x%" PRIx64,
 			rx_offloads, dev_info.rx_offload_capa);
-		return -ENOTSUP;
 	}
 
 	if (((~(dev_info.tx_offload_capa) & tx_offloads) != 0)) {
-		DPAA_PMD_ERR("Some Tx offloads are not supported "
+		DPAA_PMD_WARN("Some Tx offloads are not supported "
 			"requested 0x%" PRIx64 " supported 0x%" PRIx64,
 			tx_offloads, dev_info.tx_offload_capa);
-		return -ENOTSUP;
 	}
 
 	if (((rx_offloads & DEV_RX_OFFLOAD_IPV4_CKSUM) == 0) ||