diff mbox

[dpdk-dev] eventdev: fix icc build

Message ID 20180417131342.32027-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo April 17, 2018, 1:13 p.m. UTC 
  ICC complains about variable being used before its value is set.
Since the variable is only assigned in the for loop,
its declaration is moved inside and is initialized.

lib/librte_eventdev/rte_event_timer_adapter.c(708): error #592:
variable "ret" is used before its value is set
        RTE_SET_USED(ret);

Fixes: 6750b21bd6af ("eventdev: add default software timer adapter")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_eventdev/rte_event_timer_adapter.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Ferruh Yigit April 17, 2018, 1:28 p.m. UTC | #1 
On 4/17/2018 2:13 PM, Pablo de Lara wrote:
> ICC complains about variable being used before its value is set.
> Since the variable is only assigned in the for loop,
> its declaration is moved inside and is initialized.
> 
> lib/librte_eventdev/rte_event_timer_adapter.c(708): error #592:
> variable "ret" is used before its value is set
>         RTE_SET_USED(ret);
> 
> Fixes: 6750b21bd6af ("eventdev: add default software timer adapter")
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Carrillo, Erik G April 17, 2018, 2:13 p.m. UTC | #2 
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, April 17, 2018 8:14 AM
> To: jerin.jacob@caviumnetworks.com; Carrillo, Erik G
> <erik.g.carrillo@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] eventdev: fix icc build
> 
> ICC complains about variable being used before its value is set.
> Since the variable is only assigned in the for loop, its declaration is moved
> inside and is initialized.
> 
> lib/librte_eventdev/rte_event_timer_adapter.c(708): error #592:
> variable "ret" is used before its value is set
>         RTE_SET_USED(ret);
> 
> Fixes: 6750b21bd6af ("eventdev: add default software timer adapter")
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---

Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Thomas Monjalon April 19, 2018, 11:30 a.m. UTC | #3 
> > ICC complains about variable being used before its value is set.
> > Since the variable is only assigned in the for loop, its declaration is moved
> > inside and is initialized.
> > 
> > lib/librte_eventdev/rte_event_timer_adapter.c(708): error #592:
> > variable "ret" is used before its value is set
> >         RTE_SET_USED(ret);
> > 
> > Fixes: 6750b21bd6af ("eventdev: add default software timer adapter")
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
index 6eba6b44d..9a863f5cb 100644
--- a/lib/librte_eventdev/rte_event_timer_adapter.c
+++ b/lib/librte_eventdev/rte_event_timer_adapter.c
@@ -695,7 +695,7 @@  check_destination_event_queue(struct rte_event_timer *evtim,
 static int
 sw_event_timer_adapter_service_func(void *arg)
 {
-	int ret, i, num_msgs;
+	int i, num_msgs;
 	uint64_t cycles, opaque;
 	uint16_t nb_evs_flushed = 0;
 	uint16_t nb_evs_invalid = 0;
@@ -705,8 +705,6 @@  sw_event_timer_adapter_service_func(void *arg)
 	struct rte_timer *tim = NULL;
 	struct msg *msg, *msgs[NB_OBJS];
 
-	RTE_SET_USED(ret);
-
 	adapter = arg;
 	sw_data = adapter->data->adapter_priv;
 
@@ -720,6 +718,10 @@  sw_event_timer_adapter_service_func(void *arg)
 						  (void **)msgs, NB_OBJS, NULL);
 
 		for (i = 0; i < num_msgs; i++) {
+			int ret = 0;
+
+			RTE_SET_USED(ret);
+
 			msg = msgs[i];
 			evtim = msg->evtim;