diff mbox

[dpdk-dev,v2] eal/linux: use strlcpy in uevent parsing

Message ID 20180417122329.19492-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Thomas Monjalon April 17, 2018, 12:23 p.m. UTC 
  Support of strlcpy has recently been added to DPDK.

This replacement has been generated by the coccinelle script:
	devtools/cocci.sh devtools/cocci/strlcpy.cocci

Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: add missing include
---
 lib/librte_eal/linuxapp/eal/eal_dev.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Bruce Richardson April 23, 2018, 2:15 p.m. UTC | #1 
On Tue, Apr 17, 2018 at 02:23:29PM +0200, Thomas Monjalon wrote:
> Support of strlcpy has recently been added to DPDK.
> 
> This replacement has been generated by the coccinelle script:
> 	devtools/cocci.sh devtools/cocci/strlcpy.cocci
> 
> Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
LGTM

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon April 23, 2018, 2:23 p.m. UTC | #2 
23/04/2018 16:15, Bruce Richardson:
> On Tue, Apr 17, 2018 at 02:23:29PM +0200, Thomas Monjalon wrote:
> > Support of strlcpy has recently been added to DPDK.
> > 
> > This replacement has been generated by the coccinelle script:
> > 	devtools/cocci.sh devtools/cocci/strlcpy.cocci
> > 
> > Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> LGTM
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied
diff mbox

Patch

diff --git a/lib/librte_eal/linuxapp/eal/eal_dev.c b/lib/librte_eal/linuxapp/eal/eal_dev.c
index 9478a39a5..1cf6aebff 100644
--- a/lib/librte_eal/linuxapp/eal/eal_dev.c
+++ b/lib/librte_eal/linuxapp/eal/eal_dev.c
@@ -7,6 +7,7 @@ 
 #include <sys/socket.h>
 #include <linux/netlink.h>
 
+#include <rte_string_fns.h>
 #include <rte_log.h>
 #include <rte_compat.h>
 #include <rte_dev.h>
@@ -94,15 +95,15 @@  dev_uev_parse(const char *buf, struct rte_dev_event *event, int length)
 		if (!strncmp(buf, "ACTION=", 7)) {
 			buf += 7;
 			i += 7;
-			snprintf(action, sizeof(action), "%s", buf);
+			strlcpy(action, buf, sizeof(action));
 		} else if (!strncmp(buf, "SUBSYSTEM=", 10)) {
 			buf += 10;
 			i += 10;
-			snprintf(subsystem, sizeof(subsystem), "%s", buf);
+			strlcpy(subsystem, buf, sizeof(subsystem));
 		} else if (!strncmp(buf, "PCI_SLOT_NAME=", 14)) {
 			buf += 14;
 			i += 14;
-			snprintf(pci_slot_name, sizeof(subsystem), "%s", buf);
+			strlcpy(pci_slot_name, buf, sizeof(subsystem));
 			event->devname = strdup(pci_slot_name);
 		}
 		for (; i < length; i++) {