From patchwork Tue Apr 17 11:57:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 38305 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76EA5AAAC; Tue, 17 Apr 2018 13:58:06 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AB161A48F for ; Tue, 17 Apr 2018 13:58:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5438621C5B; Tue, 17 Apr 2018 07:58:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 17 Apr 2018 07:58:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=mesmtp; bh=TAQIC6TavIJtAsMK5QEyXH0ylhGkbKZ2hv6TbI FpwuI=; b=PweKe1zjdhRuM/Az0b3RE2ZSA8grGFBfhJq+V1FuFiC2oCZojs6qhJ Gu/Qf2+556KbKQvMSVFoqvBX1RLxGGB1qwjdZWXCURDWZ9wY0X2mnEH8rbQFm0SU Oz62IuadfqoZQ7lVIQDAm+5kRCo8qmVX9JwUMzEXnhRZscGkKXq8k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TAQIC6TavIJtAsMK5 QEyXH0ylhGkbKZ2hv6TbIFpwuI=; b=dZkfeVYHnXPlnWgnXj3txLZ0YCYl4eULA aIr5L4b+vOanIqdNllf+xRcM5zaGwuGClj3oLRDHRSWbZoODpa2xp3BuuVRF7kV7 i+icj1LA/VgEpTC1A/soqlIJmea2/hEMLFWnQCR5AHNfAmynbWjyQCPGYY1kxfpr kmJBvGTG8+p0cEYi/IN0azKU48aP5zF25KqMq6xQk7uJSKumcSDM/TEjshga0p7j rZLOq8RWfOTbxO3tlyDj1vo7Gealqpc91M9TiU6F3Wnl+b3fpzvOEoQwmn9JJEcv eHg2DL3OIUQR//uFsnZR2dn12Tzkz2YfJmn3vS1ve9Syr6zxW1MBw== X-ME-Sender: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6ED95E498C; Tue, 17 Apr 2018 07:58:02 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: anatoly.burakov@intel.com, bruce.richardson@intel.com, jia.guo@intel.com Date: Tue, 17 Apr 2018 13:57:57 +0200 Message-Id: <20180417115757.17633-1-thomas@monjalon.net> X-Mailer: git-send-email 2.16.2 Subject: [dpdk-dev] [PATCH] eal/linux: use strlcpy in uevent parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Support of strlcpy has recently been added to DPDK. This replacement has been generated by the coccinelle script: devtools/cocci.sh devtools/cocci/strlcpy.cocci Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Cc: jia.guo@intel.com Signed-off-by: Thomas Monjalon --- lib/librte_eal/linuxapp/eal/eal_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_dev.c b/lib/librte_eal/linuxapp/eal/eal_dev.c index 9478a39a5..d02bba11e 100644 --- a/lib/librte_eal/linuxapp/eal/eal_dev.c +++ b/lib/librte_eal/linuxapp/eal/eal_dev.c @@ -94,15 +94,15 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length) if (!strncmp(buf, "ACTION=", 7)) { buf += 7; i += 7; - snprintf(action, sizeof(action), "%s", buf); + strlcpy(action, buf, sizeof(action)); } else if (!strncmp(buf, "SUBSYSTEM=", 10)) { buf += 10; i += 10; - snprintf(subsystem, sizeof(subsystem), "%s", buf); + strlcpy(subsystem, buf, sizeof(subsystem)); } else if (!strncmp(buf, "PCI_SLOT_NAME=", 14)) { buf += 14; i += 14; - snprintf(pci_slot_name, sizeof(subsystem), "%s", buf); + strlcpy(pci_slot_name, buf, sizeof(subsystem)); event->devname = strdup(pci_slot_name); } for (; i < length; i++) {