[dpdk-dev,v3] drivers/net: update link status
Checks
Commit Message
Update link status related feature document items and minor updates in
some link status related functions.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
Cc: Nélio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: Tiwei Bie <tiwei.bie@intel.com>
Cc: Qi Z Zhang <qi.z.zhang@intel.com>
v2:
* update virtio.ini (Tiwei)
* update i40e_vf_vec.ini (Qi)
* update avf.ini avf_vec.ini
v3:
* Put "Link status" back for vhost (Tiwei)
---
doc/guides/nics/features/avf.ini | 1 -
doc/guides/nics/features/avf_vec.ini | 1 -
doc/guides/nics/features/fm10k.ini | 2 ++
doc/guides/nics/features/fm10k_vf.ini | 2 ++
doc/guides/nics/features/i40e_vf.ini | 1 +
doc/guides/nics/features/i40e_vf_vec.ini | 1 +
doc/guides/nics/features/igb_vf.ini | 1 +
doc/guides/nics/features/qede.ini | 1 -
doc/guides/nics/features/qede_vf.ini | 1 -
doc/guides/nics/features/vhost.ini | 1 -
doc/guides/nics/features/virtio.ini | 1 +
doc/guides/nics/features/virtio_vec.ini | 1 +
drivers/net/e1000/em_ethdev.c | 2 +-
drivers/net/ena/ena_ethdev.c | 2 +-
drivers/net/fm10k/fm10k_ethdev.c | 6 ++----
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
drivers/net/mlx4/mlx4_ethdev.c | 2 +-
drivers/net/mlx5/mlx5_ethdev.c | 2 +-
19 files changed, 17 insertions(+), 15 deletions(-)
Comments
On 4/17/2018 12:30 PM, Ferruh Yigit wrote:
> Update link status related feature document items and minor updates in
> some link status related functions.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
@@ -6,7 +6,6 @@
[Features]
Speed capabilities = Y
Link status = Y
-Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
@@ -6,7 +6,6 @@
[Features]
Speed capabilities = Y
Link status = Y
-Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
@@ -5,6 +5,8 @@
;
[Features]
Speed capabilities = P
+Link status = Y
+Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
Jumbo frame = Y
@@ -5,6 +5,8 @@
;
[Features]
Speed capabilities = P
+Link status = Y
+Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
Jumbo frame = Y
@@ -5,6 +5,7 @@
;
[Features]
Rx interrupt = Y
+Link status = Y
Queue start/stop = Y
Jumbo frame = Y
Scattered Rx = Y
@@ -5,6 +5,7 @@
;
[Features]
Rx interrupt = Y
+Link status = Y
Queue start/stop = Y
Jumbo frame = Y
Scattered Rx = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Link status = Y
Rx interrupt = Y
Scattered Rx = Y
TSO = Y
@@ -6,7 +6,6 @@
[Features]
Speed capabilities = Y
Link status = Y
-Link status event = Y
MTU update = Y
Jumbo frame = Y
Scattered Rx = Y
@@ -6,7 +6,6 @@
[Features]
Speed capabilities = Y
Link status = Y
-Link status event = Y
MTU update = Y
Jumbo frame = Y
Scattered Rx = Y
@@ -5,7 +5,6 @@
;
[Features]
Link status = Y
-Link status event = Y
Free Tx mbuf on demand = Y
Queue status event = Y
Basic stats = Y
@@ -6,6 +6,7 @@
[Features]
Speed capabilities = P
Link status = Y
+Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
Scattered Rx = Y
@@ -6,6 +6,7 @@
[Features]
Speed capabilities = P
Link status = Y
+Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
Promiscuous mode = Y
@@ -1183,7 +1183,7 @@ eth_em_link_update(struct rte_eth_dev *dev, int wait_to_complete)
link.link_autoneg = !(dev->data->dev_conf.link_speeds &
ETH_LINK_SPEED_FIXED);
} else if (!link_check && (link.link_status == ETH_LINK_UP)) {
- link.link_speed = 0;
+ link.link_speed = ETH_SPEED_NUM_NONE;
link.link_duplex = ETH_LINK_HALF_DUPLEX;
link.link_status = ETH_LINK_DOWN;
link.link_autoneg = ETH_LINK_FIXED;
@@ -728,7 +728,7 @@ static int ena_link_update(struct rte_eth_dev *dev,
{
struct rte_eth_link *link = &dev->data->dev_link;
- link->link_status = 1;
+ link->link_status = ETH_LINK_UP;
link->link_speed = ETH_SPEED_NUM_10G;
link->link_duplex = ETH_LINK_FULL_DUPLEX;
@@ -1260,13 +1260,11 @@ fm10k_link_update(struct rte_eth_dev *dev,
FM10K_DEV_PRIVATE_TO_INFO(dev->data->dev_private);
PMD_INIT_FUNC_TRACE();
- /* The speed is ~50Gbps per Gen3 x8 PCIe interface. For now, we
- * leave the speed undefined since there is no 50Gbps Ethernet.
- */
- dev->data->dev_link.link_speed = 0;
+ dev->data->dev_link.link_speed = ETH_SPEED_NUM_50G;
dev->data->dev_link.link_duplex = ETH_LINK_FULL_DUPLEX;
dev->data->dev_link.link_status =
dev_info->sm_down ? ETH_LINK_DOWN : ETH_LINK_UP;
+ dev->data->dev_link.link_autoneg = ETH_LINK_FIXED;
return 0;
}
@@ -2112,7 +2112,7 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,
new_link.link_status = vf->link_up ? ETH_LINK_UP :
ETH_LINK_DOWN;
new_link.link_autoneg =
- dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED;
+ !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED);
return rte_eth_linkstatus_set(dev, &new_link);
}
@@ -3900,7 +3900,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
memset(&link, 0, sizeof(link));
link.link_status = ETH_LINK_DOWN;
- link.link_speed = 0;
+ link.link_speed = ETH_SPEED_NUM_NONE;
link.link_duplex = ETH_LINK_HALF_DUPLEX;
link.link_autoneg = ETH_LINK_AUTONEG;
@@ -713,7 +713,7 @@ mlx4_link_update(struct rte_eth_dev *dev, int wait_to_complete)
}
link_speed = ethtool_cmd_speed(&edata);
if (link_speed == -1)
- dev_link.link_speed = 0;
+ dev_link.link_speed = ETH_SPEED_NUM_NONE;
else
dev_link.link_speed = link_speed;
dev_link.link_duplex = ((edata.duplex == DUPLEX_HALF) ?
@@ -539,7 +539,7 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev,
}
link_speed = ethtool_cmd_speed(&edata);
if (link_speed == -1)
- dev_link.link_speed = 0;
+ dev_link.link_speed = ETH_SPEED_NUM_NONE;
else
dev_link.link_speed = link_speed;
priv->link_speed_capa = 0;