diff mbox

[dpdk-dev] net/sfc: fix meson build warning with gcc

Message ID 20180416170930.56225-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit April 16, 2018, 5:09 p.m. UTC 
  icc flag is causing build error with gcc, build error:
cc1: warning: unrecognized gcc debugging option: i
cc1: warning: unrecognized gcc debugging option: g
cc1: warning: unrecognized gcc debugging option: -
cc1: warning: unrecognized gcc debugging option: d
cc1: warning: unrecognized gcc debugging option: i
cc1: warning: unrecognized gcc debugging option: s
cc1: warning: unrecognized gcc debugging option: b
cc1: warning: unrecognized gcc debugging option: l
cc1: warning: unrecognized gcc debugging option: e
cc1: warning: unrecognized gcc debugging option:
cc1: warning: unrecognized gcc debugging option: 3
cc1: warning: unrecognized gcc debugging option: 6
cc1: warning: unrecognized gcc debugging option: 5
cc1: warning: unrecognized gcc debugging option: 6
cc1: warning: unrecognized command line option
‘-Wno-address-of-packed-member’

Removing icc flag completely since it is not supported right now.

Fixes: f16d0b36f816 ("drivers/net: fix icc deprecated parameter warning")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/sfc/meson.build | 4 ----
 1 file changed, 4 deletions(-)

Comments

Thomas Monjalon April 16, 2018, 5:31 p.m. UTC | #1 
16/04/2018 19:09, Ferruh Yigit:
> icc flag is causing build error with gcc, build error:
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: g
> cc1: warning: unrecognized gcc debugging option: -
> cc1: warning: unrecognized gcc debugging option: d
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: s
> cc1: warning: unrecognized gcc debugging option: b
> cc1: warning: unrecognized gcc debugging option: l
> cc1: warning: unrecognized gcc debugging option: e
> cc1: warning: unrecognized gcc debugging option:
> cc1: warning: unrecognized gcc debugging option: 3
> cc1: warning: unrecognized gcc debugging option: 6
> cc1: warning: unrecognized gcc debugging option: 5
> cc1: warning: unrecognized gcc debugging option: 6
> cc1: warning: unrecognized command line option
> ‘-Wno-address-of-packed-member’
> 
> Removing icc flag completely since it is not supported right now.
> 
> Fixes: f16d0b36f816 ("drivers/net: fix icc deprecated parameter warning")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
Bruce Richardson April 17, 2018, 8:59 a.m. UTC | #2 
On Mon, Apr 16, 2018 at 06:09:29PM +0100, Ferruh Yigit wrote:
> icc flag is causing build error with gcc, build error:
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: g
> cc1: warning: unrecognized gcc debugging option: -
> cc1: warning: unrecognized gcc debugging option: d
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: s
> cc1: warning: unrecognized gcc debugging option: b
> cc1: warning: unrecognized gcc debugging option: l
> cc1: warning: unrecognized gcc debugging option: e
> cc1: warning: unrecognized gcc debugging option:
> cc1: warning: unrecognized gcc debugging option: 3
> cc1: warning: unrecognized gcc debugging option: 6
> cc1: warning: unrecognized gcc debugging option: 5
> cc1: warning: unrecognized gcc debugging option: 6
> cc1: warning: unrecognized command line option
> ‘-Wno-address-of-packed-member’
> 
> Removing icc flag completely since it is not supported right now.
> 
> Fixes: f16d0b36f816 ("drivers/net: fix icc deprecated parameter warning")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> ---
And just by way of further info, the underlying problem here is that gcc is
returning 0 i.e. not reporting error, when called normally with
-diag-disable flag. This prevents meson from detecting that the flag is
unsupported. :-(

/Bruce
diff mbox

Patch

diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build
index a37fc44a7..0de2e17fe 100644
--- a/drivers/net/sfc/meson.build
+++ b/drivers/net/sfc/meson.build
@@ -30,10 +30,6 @@  extra_flags += [
 	'-Wbad-function-cast'
 ]
 
-# Suppress ICC false positive warning on 'bulk' may be used before its
-# value is set
-extra_flags += '-diag-disable 3656'
-
 foreach flag: extra_flags
 	if cc.has_argument(flag)
 		cflags += flag