diff mbox

[dpdk-dev,v5,10/11] ethdev: fix missing boolean values in flow command

Message ID 20180416150058.2620-11-adrien.mazarguil@6wind.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Adrien Mazarguil April 16, 2018, 4:22 p.m. UTC 
  Original implementation lacks the on/off toggle.

This patch shows up as a fix because it has been a popular request ever
since the first DPDK release with the original implementation but was never
addressed.

Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command")
Cc: stable@dpdk.org

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 app/test-pmd/cmdline_flow.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Matan Azrad April 16, 2018, 7:17 p.m. UTC | #1 
Hi Adrien

I think the title should be "app/testpmd: ..." ...

From: Adrien Mazarguil, Monday, April 16, 2018 7:22 PM
> Original implementation lacks the on/off toggle.
> 
> This patch shows up as a fix because it has been a popular request ever since
> the first DPDK release with the original implementation but was never
> addressed.
> 
> Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
>  app/test-pmd/cmdline_flow.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index fcd76b56e..f0b4b7bc4 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -2692,6 +2692,7 @@ static const char *const boolean_name[] = {
>  	"false", "true",
>  	"no", "yes",
>  	"N", "Y",
> +	"off", "on",
>  	NULL,
>  };
> 
> --
> 2.11.0
Adrien Mazarguil April 17, 2018, 8:25 a.m. UTC | #2 
On Mon, Apr 16, 2018 at 07:17:44PM +0000, Matan Azrad wrote:
> Hi Adrien
> 
> I think the title should be "app/testpmd: ..." ...

Indeed, I'll update it in the next iteration, thanks.
Ferruh Yigit April 18, 2018, 5:16 p.m. UTC | #3 
On 4/17/2018 9:25 AM, Adrien Mazarguil wrote:
> On Mon, Apr 16, 2018 at 07:17:44PM +0000, Matan Azrad wrote:
>> Hi Adrien
>>
>> I think the title should be "app/testpmd: ..." ...
> 
> Indeed, I'll update it in the next iteration, thanks.

If this is the only issue, it can be fixed while applying.
Are there more outstanding issues, will there be a new version of the set?
Adrien Mazarguil April 19, 2018, 10:18 a.m. UTC | #4 
On Wed, Apr 18, 2018 at 06:16:18PM +0100, Ferruh Yigit wrote:
> On 4/17/2018 9:25 AM, Adrien Mazarguil wrote:
> > On Mon, Apr 16, 2018 at 07:17:44PM +0000, Matan Azrad wrote:
> >> Hi Adrien
> >>
> >> I think the title should be "app/testpmd: ..." ...
> > 
> > Indeed, I'll update it in the next iteration, thanks.
> 
> If this is the only issue, it can be fixed while applying.
> Are there more outstanding issues, will there be a new version of the set?

Yes, submitted after rebasing it [1].

[1] http://dpdk.org/ml/archives/dev/2018-April/098035.html
diff mbox

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index fcd76b56e..f0b4b7bc4 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -2692,6 +2692,7 @@  static const char *const boolean_name[] = {
 	"false", "true",
 	"no", "yes",
 	"N", "Y",
+	"off", "on",
 	NULL,
 };