[dpdk-dev] vhost/crypto: fix Makefile

  Fixes: d090c7f86a76 ("vhost/crypto: update makefile")

Vhost-Crypto shall not be compiled if rte_cryptodev is disabled.
This patch fix this by adding checking to Makefile.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 lib/librte_vhost/Makefile | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
  

16/04/2018 16:08, Fan Zhang:
> Fixes: d090c7f86a76 ("vhost/crypto: update makefile")
> 
> Vhost-Crypto shall not be compiled if rte_cryptodev is disabled.
> This patch fix this by adding checking to Makefile.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  lib/librte_vhost/Makefile | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)

What about meson.build?
  

Hi Thomas,

In fact Meson compile enables all library builds so you cannot turn off cryptodev
manually. So the condition checking to disable vhost crypto build is not necessary.

Regards,
Fan
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, April 16, 2018 10:43 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; shahafs@mellanox.com;
> Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile
> 
> 16/04/2018 16:08, Fan Zhang:
> > Fixes: d090c7f86a76 ("vhost/crypto: update makefile")
> >
> > Vhost-Crypto shall not be compiled if rte_cryptodev is disabled.
> > This patch fix this by adding checking to Makefile.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> >  lib/librte_vhost/Makefile | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> What about meson.build?
> 
>
  

On Mon, Apr 16, 2018 at 11:42:57PM +0200, Thomas Monjalon wrote:
> 16/04/2018 16:08, Fan Zhang:
> > Fixes: d090c7f86a76 ("vhost/crypto: update makefile")
> > 
> > Vhost-Crypto shall not be compiled if rte_cryptodev is disabled.
> > This patch fix this by adding checking to Makefile.
> > 
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> >  lib/librte_vhost/Makefile | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> What about meson.build?
>
It's not needed. Meson build does not allow you to go arbitrarily disabling
libraries - exactly for this reason, to save us littering other build files
with all sorts of checks for various libraries. Only those libraries which
are unsupported on a particular platform need to be checked for - all core
libraries are always available. I'm sure if you looked at it, we should
have an awful lot more checks in our Makefiles for library disabling, not
to mention the fact that EAL, mbuf, mempool libraries are possible to
disable, even though doing so will result in an unbuildable mess.

/Bruce
  

16/04/2018 16:08, Fan Zhang:
> Fixes: d090c7f86a76 ("vhost/crypto: update makefile")
> 
> Vhost-Crypto shall not be compiled if rte_cryptodev is disabled.
> This patch fix this by adding checking to Makefile.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

Applied with title "vhost/crypto: fix build without cryptodev"

Note: "Fixes" line should be between the explanations and the SoB.

Thanks