From patchwork Fri Apr 6 13:22:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 37382 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7FC11D085; Fri, 6 Apr 2018 15:22:55 +0200 (CEST) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 2D0AA1D075 for ; Fri, 6 Apr 2018 15:22:52 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id g8so3493436wmd.2 for ; Fri, 06 Apr 2018 06:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ukSHPNnxQsqh4dbS7MFYQkL+QlTHUJn+Tz/Bv4Ygrn4=; b=Wxk6Y+rNeooN/IWmx/SwGREQ5zrmdG0ytPd7lxWCh8O0+J8u2mraQL2k68cG4dAjgt dqi86c4q8dOtZb9JhQixYspP30ndAj7jowTiaegqw6hpRFSXI13Nxj8i/TbBJI3ABj0q oKnMVytUG6dcLtquNkHJrkeFeAZyUpg1NB5QtFosmWMAGmqsJ3hB8IZ+Vc9GcVN1/gSy jNuBCFlnoIPrto35N/P6e0lO/ZEUFdvg9run4HxUiX4mzq8XYJ60voWDEQRG3Z4dt/eu 2FLGN1ruCmFIL24QOGVhetd/Y3rRPy6vOUTZXUIaFi+RFaiDO+c7zbe7g69ECctHzYF1 pZiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ukSHPNnxQsqh4dbS7MFYQkL+QlTHUJn+Tz/Bv4Ygrn4=; b=K5dIsimHIj2jtY08JchcH9smt7LlentEvr7cEiWJ6NdOKLNwd/kY398oV5Ljc0HcAD CjaDB4/tb4Oc+fQBkPPdrNK4GlJ/XJuEQWVZ4XZw3eQreK+7bSzfEeW4ZfPyKp74mpHY QVCiov+gHR5IOG8T8nlbBBOszWixYJYBgzhDa9TdQ/QbKNLPXMXdG1l1E5voQQk2V4Bx GhqMJYx1efZ+HNg+EAAokt+UtYXarY5dKTBiSzCsHJb+Oq9iarzFY+UySZB88wdnLlhD 63VZYNCFRn4C+DveQ3mi9uxUmrRQCiNgPGZxgtlG8ika7yW+0b5lSt61HKNW0cVnQcCo /5ZQ== X-Gm-Message-State: ALQs6tA98elA8BWPkZTbj6rZKyWY0w0HA1ZnkAYUia8TBmWU0vKu5h15 1s+iNF1LcBkZmm4lKYYoNAbKonwC X-Google-Smtp-Source: AIpwx49bvzHOOx2bOXYRE05q8qHDE9NfBi/QpPSdDjkCGwu5XDqfI/8yikDGIJE/nra0HcSgsGbEcA== X-Received: by 10.28.0.4 with SMTP id 4mr1042119wma.118.1523020971847; Fri, 06 Apr 2018 06:22:51 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s65sm9078623wms.26.2018.04.06.06.22.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Apr 2018 06:22:51 -0700 (PDT) Date: Fri, 6 Apr 2018 15:22:38 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Nelio Laranjeiro Message-ID: <20180406131243.19037-4-adrien.mazarguil@6wind.com> References: <20180404144805.11966-1-adrien.mazarguil@6wind.com> <20180406131243.19037-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180406131243.19037-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v3 03/11] net/mlx5: fix RSS flow action bounds check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The number of queues provided by the application is not checked against parser's supported maximum. Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") Cc: stable@dpdk.org Cc: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index e6af3243d..f051fbef5 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -16,6 +16,7 @@ #pragma GCC diagnostic error "-Wpedantic" #endif +#include #include #include #include @@ -713,6 +714,14 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } } + if (rss->num > RTE_DIM(parser->queues)) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "too many queues for RSS" + " context"); + return -rte_errno; + } for (n = 0; n < rss->num; ++n) { if (rss->queue[n] >= priv->rxqs_n) { rte_flow_error_set(error, EINVAL,