[dpdk-dev] app/bbdev: remove improper WARNING printouts

Message ID 20180404140602.9344-6-kamilx.chalupnik@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Kamil Chalupnik April 4, 2018, 2:06 p.m. UTC
  From: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>

Improper WARNING printouts in BBDev Test Application removed

Signed-off-by: KamilX Chalupnik <kamilx.chalupnik@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c   |  3 ++-
 app/test-bbdev/test_bbdev_vector.c | 12 ++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)
  

Comments

Mokhtar, Amr April 13, 2018, 11:20 p.m. UTC | #1
> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Wednesday 4 April 2018 15:06
> To: dev@dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; Chalupnik, KamilX
> <kamilx.chalupnik@intel.com>
> Subject: [PATCH] app/bbdev: remove improper WARNING printouts
> 
> From: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>
> 
> Improper WARNING printouts in BBDev Test Application removed
> 
> Signed-off-by: KamilX Chalupnik <kamilx.chalupnik@intel.com>

Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>
  

Patch

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 812787c..c48d60e 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -161,7 +161,7 @@  check_dev_cap(const struct rte_bbdev_info *dev_info)
 					!(cap->capability_flags &
 					RTE_BBDEV_TURBO_SOFT_OUTPUT)) {
 				printf(
-					"WARNING: Device \"%s\" does not support soft output - soft output flags will be ignored.\n",
+					"INFO: Device \"%s\" does not support soft output - soft output flags will be ignored.\n",
 					dev_info->dev_name);
 				clear_soft_out_cap(
 					&test_vector.turbo_dec.op_flags);
@@ -1166,6 +1166,7 @@  dequeue_event_callback(uint16_t dev_id,
 	double in_len;
 
 	struct thread_params *tp = cb_arg;
+
 	RTE_SET_USED(ret_param);
 	queue_id = tp->queue_id;
 
diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c
index a37e35f..324f2c4 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app/test-bbdev/test_bbdev_vector.c
@@ -644,7 +644,7 @@  check_decoder_llr_spec(struct test_bbdev_vector *vector)
 			!(turbo_dec->op_flags &
 			RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN)) {
 		printf(
-			"WARNING: input LLR sign formalism was not specified and will be set to negative LLR for '1' bit\n");
+			"INFO: input LLR sign formalism was not specified and will be set to negative LLR for '1' bit\n");
 		turbo_dec->op_flags |= RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN;
 	}
 
@@ -663,7 +663,7 @@  check_decoder_llr_spec(struct test_bbdev_vector *vector)
 			!(turbo_dec->op_flags &
 			RTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOFT_OUT)) {
 		printf(
-			"WARNING: soft output LLR sign formalism was not specified and will be set to negative LLR for '1' bit\n");
+			"INFO: soft output LLR sign formalism was not specified and will be set to negative LLR for '1' bit\n");
 		turbo_dec->op_flags |=
 				RTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOFT_OUT;
 	}
@@ -724,7 +724,7 @@  check_decoder(struct test_bbdev_vector *vector)
 	}
 	if (!(mask & TEST_BBDEV_VF_RV_INDEX))
 		printf(
-			"WARNING: rv_index was not specified in vector file and will be set to 0\n");
+			"INFO: rv_index was not specified in vector file and will be set to 0\n");
 	if (!(mask & TEST_BBDEV_VF_ITER_MIN))
 		printf(
 			"WARNING: iter_min was not specified in vector file and will be set to 0\n");
@@ -744,7 +744,7 @@  check_decoder(struct test_bbdev_vector *vector)
 	} else if (!(turbo_dec->op_flags & RTE_BBDEV_TURBO_MAP_DEC) &&
 			mask & TEST_BBDEV_VF_NUM_MAPS) {
 		printf(
-			"WARNING: RTE_BBDEV_TURBO_MAP_DEC was not set in vector file and num_maps will be set to 0\n");
+			"INFO: RTE_BBDEV_TURBO_MAP_DEC was not set in vector file and num_maps will be set to 0\n");
 		turbo_dec->num_maps = 0;
 	}
 	if (!(mask & TEST_BBDEV_VF_EXPECTED_STATUS))
@@ -829,10 +829,10 @@  check_encoder(struct test_bbdev_vector *vector)
 	}
 	if (!(mask & TEST_BBDEV_VF_RV_INDEX))
 		printf(
-			"WARNING: rv_index was not specified in vector file and will be set to 0\n");
+			"INFO: rv_index was not specified in vector file and will be set to 0\n");
 	if (!(mask & TEST_BBDEV_VF_OP_FLAGS))
 		printf(
-			"WARNING: op_flags was not specified in vector file and capabilities will not be validated\n");
+			"INFO: op_flags was not specified in vector file and capabilities will not be validated\n");
 	if (!(mask & TEST_BBDEV_VF_EXPECTED_STATUS))
 		printf(
 			"WARNING: expected_status was not specified in vector file and will be set to 0\n");