From patchwork Thu Mar 29 16:55:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 36680 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3D832BF7; Thu, 29 Mar 2018 18:55:38 +0200 (CEST) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id 0EB2F2C58 for ; Thu, 29 Mar 2018 18:55:35 +0200 (CEST) Received: by mail-pf0-f195.google.com with SMTP id q9so3642632pff.1 for ; Thu, 29 Mar 2018 09:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RzR0TsjFqZkmaDlcFvuBe+c8OtqRFcfKQFfymEydwJE=; b=EoaRUhY0+JJypKduCtm69CoeIpRX+NOCGBzn4wGkT+9U5gKQ+q9KBZNiTwItx27Ogo iuO125FDJwtB3muwB8fSV7jhzz0hgdrdBoAvD7n7D9B3hSHxpFZNODRkF7yRIQ5jEKDo DR88YKO4LoGOKG5U9Xkos9yyJATxoAa0woVDop4GRhq0jugP3/2lJSD08PL/TapSztvY 6QLSsRCFuS3EHXy1Jvsa8HT53CoQkJYTR6lRdZIg+hKw7VMDjI9TZ4O6lnY2Ju9By1MR q18o/GsqaCNRLni5A2W1M8KEhrhSpDBcPSIdNb+ju3Vm6/JPu7NNSloUR9plESr96c99 3BTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RzR0TsjFqZkmaDlcFvuBe+c8OtqRFcfKQFfymEydwJE=; b=dyAWA88uRGj3F/RzkexgoPf0shnr9HNIENoFK84Jfmu1FHAOe3OARmtahM+lpdgcC0 tVDipgq0/xuNEEHZKO19jFXuHKf2m06+8Zfd+5JswU/xFa1DFupgYTfrTsYMaTJXJ07t UJksxeZJNHuD8cXwqT3Ndpcg+tnLr9vsmT0+cT4gcG4iEIA15MocJQZ0I2IHYxU/SKkN zkr1uqR+BlCQFoaqZEv/tjg3yZFhUlCZvQD9b9PDhCvk/7CApfJhO/Q1XEKMKvcFnDUY 1ox3ZtzEQ2o1So9WzVuvzZ9sxDAFRG9cpRdCghcXNOR8M7hsRXeydfsKaMd29KIqMGe3 zQ/g== X-Gm-Message-State: AElRT7GMGqxzhRrTgQJDJDYJLPyqNiGhiothCmOxRRnb8K+8B6THixAu o/FOFgA6oS3eyzcKBC9sAynWB9Kc8gI= X-Google-Smtp-Source: AIpwx48Gfb/Vf6g5859u7YC6hKvvDG2E8m0N06h5MUvNxvYEVC7Bf1SeqVBLotG6hjXZvgUCj5LcTA== X-Received: by 2002:a17:902:4003:: with SMTP id b3-v6mr9417994pld.15.1522342532902; Thu, 29 Mar 2018 09:55:32 -0700 (PDT) Received: from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id t137sm4180381pgc.16.2018.03.29.09.55.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Mar 2018 09:55:31 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Thu, 29 Mar 2018 09:55:27 -0700 Message-Id: <20180329165527.13109-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180329165527.13109-1-stephen@networkplumber.org> References: <20180329165527.13109-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/2] rte_metrics: fix strncpy truncation warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: librte_metrics/rte_metrics.c:218:4: error: ‘strncpy’ specified bound 64 equals destination size [-Werror=stringop-truncation] strncpy(names[idx_name].name, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ stats->metadata[idx_name].name, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ RTE_METRICS_MAX_NAME_LEN); ~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Stephen Hemminger --- lib/librte_metrics/rte_metrics.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c index 556ae1ba8b4d..e0f803ef0880 100644 --- a/lib/librte_metrics/rte_metrics.c +++ b/lib/librte_metrics/rte_metrics.c @@ -214,10 +214,13 @@ rte_metrics_get_names(struct rte_metric_name *names, rte_spinlock_unlock(&stats->lock); return return_value; } - for (idx_name = 0; idx_name < stats->cnt_stats; idx_name++) + + for (idx_name = 0; idx_name < stats->cnt_stats; idx_name++) { strncpy(names[idx_name].name, stats->metadata[idx_name].name, - RTE_METRICS_MAX_NAME_LEN); + RTE_METRICS_MAX_NAME_LEN - 1); + names[idx_name].name[RTE_METRICS_MAX_NAME_LEN - 1] = '\0'; + } } return_value = stats->cnt_stats; rte_spinlock_unlock(&stats->lock);