From patchwork Thu Mar 29 16:55:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 36679 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF7EE2C2B; Thu, 29 Mar 2018 18:55:34 +0200 (CEST) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id A82002BD8 for ; Thu, 29 Mar 2018 18:55:32 +0200 (CEST) Received: by mail-pf0-f194.google.com with SMTP id a16so3631345pfn.9 for ; Thu, 29 Mar 2018 09:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1AJNRikp32hESj2+ZMQqtdnCgV1t/0wpXjbiztBdJWU=; b=KOFHItXJFRrff329lk9A+yofSk16z7jNV15IhiB8D4StAJrimnlfgKHCEyYadZFkqc 7+Np0FA4k4zISCNIru1TNLiaZtOxeGS5nUXxKRKIZs1rjyyrs59Qg5G1aa8q4NsVp75m Kiuw52LDvCLZQPjtgCYUxOkXd86EK5EwhWrVVaBZeFkQ/sZWJCZsp/ScPHt3EOIaPzIA NkrfYjdJyPSCG/IehabA+TexAjXM38updY+zsIHM8oIF0fiGao/vM11CXgqZKfwetNNk ohebxvEdidWH+9AImBHsA+WHLZt4MruftLnFNM85mQEJE7Y0NoumLhwsw7iAwNRhXoBy 10pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1AJNRikp32hESj2+ZMQqtdnCgV1t/0wpXjbiztBdJWU=; b=CuwWRA/ScBG6EgbBauO8NIaeYUm556lDXckc3j+hOkiBMItM0Wu14o0ZTeywbn/ZkZ prkmtyEzAFQer89lPyHPdrpk88tsYnj0ChX7UVjPiTN/6OHXzk/N+kKOAzdwfIUsejJi qW6dm/GsBHTFATydF+1DRKMOrzCJHU3hqms3C6N4eTnIH9P546QwYYUWiZIa0J/6TRBa 2IoPEp3rYJT3lZTFDLrK1ilZWWOw2PcvVvxPHwy1Oue23S+RUHHHvxTgV198POtrPAm4 Qp4SNTZClzhUxcxuXpadd8+l3wN3Nr6fQO8my/lVWqOZIYy6GD2ZooczHdkvnVl5cHCz QdDw== X-Gm-Message-State: AElRT7FaIc9voUuyIJL0XMfIUXBt80505jdle5Acs5OCu1BlABZ8btRB K8y9tVFa5zcwT0TEESm3lhNNn8OJ/us= X-Google-Smtp-Source: AIpwx4/Y7sUT2dbfZwPfL5PAGfy7hcE7LlWiQ0pt0IUcSezDzRWmQWxyPCHXFTB64n2oUinkqdedTQ== X-Received: by 10.101.99.129 with SMTP id h1mr5937865pgv.27.1522342531584; Thu, 29 Mar 2018 09:55:31 -0700 (PDT) Received: from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id t137sm4180381pgc.16.2018.03.29.09.55.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Mar 2018 09:55:30 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Thu, 29 Mar 2018 09:55:26 -0700 Message-Id: <20180329165527.13109-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180329165527.13109-1-stephen@networkplumber.org> References: <20180329165527.13109-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/2] rte_mbuf: fix strncpy warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Gcc-8 discovers issue with platform_mempool_ops. rte_mbuf_pool_ops.c:26:3: error: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] strncpy(mz->addr, ops_name, strlen(ops_name)); Since the ops_name is already checked for size, using strncpy here is unnecessary; just use strcpy. Fixes: a3acc3144a76 ("mbuf: add pool ops selection functions") --- lib/librte_mbuf/rte_mbuf_pool_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.c b/lib/librte_mbuf/rte_mbuf_pool_ops.c index 48cc342002a5..a1d4699f67fe 100644 --- a/lib/librte_mbuf/rte_mbuf_pool_ops.c +++ b/lib/librte_mbuf/rte_mbuf_pool_ops.c @@ -23,7 +23,7 @@ rte_mbuf_set_platform_mempool_ops(const char *ops_name) RTE_MEMPOOL_OPS_NAMESIZE, SOCKET_ID_ANY, 0); if (mz == NULL) return -rte_errno; - strncpy(mz->addr, ops_name, strlen(ops_name)); + strcpy(mz->addr, ops_name); return 0; } else if (strcmp(mz->addr, ops_name) == 0) { return 0; @@ -62,7 +62,7 @@ rte_mbuf_set_user_mempool_ops(const char *ops_name) return -rte_errno; } - strncpy(mz->addr, ops_name, strlen(ops_name)); + strcpy(mz->addr, ops_name); return 0; }