Message ID | 20180326101219.91229-2-shahafs@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Shahaf Shuler |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C459B7CFA; Mon, 26 Mar 2018 12:13:14 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by dpdk.org (Postfix) with ESMTP id 1D7B05F27; Mon, 26 Mar 2018 12:13:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Arl+XUX3AfiqKpkmitkR8ULnq31GaRM4l2bRh0zTyiM=; b=d58tTJ0/6xl8YtRFGj5rj1ThqtOH0yqeo97qEt5OxHqiNWgOYpSC35xZ8sPok1zBfJtJ33TxAayuMBjYiiUBhPdu6q8KPdz5muX1YeYSPmaWq4nL/jtdNpEAIH+leVE8wv8cdoSACSqU0GpIpdZJ+p0goCoZ3aqefCZmj7A748Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by AM0PR05MB4420.eurprd05.prod.outlook.com (2603:10a6:208:5a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Mon, 26 Mar 2018 10:13:10 +0000 From: Shahaf Shuler <shahafs@mellanox.com> To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, stable@dpdk.org Date: Mon, 26 Mar 2018 13:12:19 +0300 Message-Id: <20180326101219.91229-2-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180326101219.91229-1-shahafs@mellanox.com> References: <20180326101219.91229-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: VI1PR0102CA0013.eurprd01.prod.exchangelabs.com (2603:10a6:802::26) To AM0PR05MB4420.eurprd05.prod.outlook.com (2603:10a6:208:5a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: edc60920-16ff-4668-ce37-08d593022dc9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB4420; X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4420; 3:KqTGXfNIxLFU15DAJIHuVj7JblOK0g429bM1b1TqbcGUvHz1kGN2eRnHHzYT5IFNY3kc7skfT26bfu0yuJsqTFoyTocgy6vMIb0hzRLUAKAW6S5ZcpLTlWkmnNSMM5i8Se0rO1VxZVuljSmo7dJuiOCu8wdxh7s4aA5KFkJFWBesxYNjW2gIAEMT4omiUdl3oqTIXCKMCK29cbYxbIegwgXoKW4p+jEhTQG/9kxcNG1BYp9jNpX8lg9xahYe9MPN; 25:fUEn15EwksCTq+hEZAHM4N9Um1eIn9M2tIjM+Bq2x3j9SQxruJ7U2ZzVb48Z7/i7YKlF+qEI5MW/fRcFKmdHe79tcWFrmpoQLw1KNrjUj+LatjOhq/hmC/84NhHyzBLFwHTYVUTLZIHuZwN5w90Zqn0ojsnwwRgFaicMueydpdQIAF8zsid7DFlxy+ZS6bD2tB7Prq47+ZWlYTBbFW/gegupe4IyO0F7EPLkbsj2sbtbBlkEoeKvPNrkETuAIv6P4ZeQOV66ZV/Q8vnlZ9iQF9piCRamfyYJTRP52tXQ3V+oNtnc8dj3839SK0jNuKA8hHhNwO2B3xvyJ8mJR17lfg==; 31:aBMtgs/aJcrMK2piiEx0/6BOW+mpI06gjj68oG9N6wXmh7hbnhOsdvH1RWym9UlLkc2FqiyPQ2V5+zrtkpVSc4w8uSWWxruxnY2vHBnSYxRkARjAoyRw9dUdVm+Qa1k2RvzeSm2QYvhsCIg4PkfoN0Iu5XqlDj659qREVu7TvIbkydqNTb2vUEbeft5g5FfZDccChbSh3e+iQSVODGKPz8ezFWQTIxLILsKv44lKWEk= X-MS-TrafficTypeDiagnostic: AM0PR05MB4420: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4420; 20:P6v4vsXbZYfM/iD4Qj3R7be356HAJIiVMNSrGle96rm0lSEF165uEf+qHsXXVFvLs4gTYEJ0Fc4i3eld54pC2PBtJDDKUOHdNRDgn3IPAXYHsDE0sgK35Ntbryw4beYjLDjNEjIcY1PEc5H7zPM5h36Uj0A2HIFJyDhpj0mJKdZfvr+FHeUbsY709cPxb2tE6lSsyrgreqW0Xw5UuTdpoj4wyqB0wjbFRKbEsk2U0pLEmJMArHfZaNsM56Y9f/n6Gpd1bPTmf33i27wpS8UzXHZsIkeho6IE0SDxK9vCZmn4Lo8wv5LDCOoQH3XnuimuZ/qCozDrwgiS2ZSlcXpqnSORvk2IzGYgQvOUoN9VKEGYqKqmdoGfOthQQ4suKNpE6Zdx0lQxtGw2gtnM78vCrU6axQevXEhXLSVgVp7pvHUr7ACVk2EzzFeyrGE//x9UTmcnTruR0CP9EPnSepHPq9vbf5oSuFX9GbLJzyHxtkqDBvFy77IJ0zZTTfT+BBRA; 4:QbvR319puZmBXUTHFRuGZ6PhTokt4X6cnDgdisPr0nQQycx7Qu94256KB5/Tp7RfqQAC3XTm0JbdDh+a0QLyGYeQ/IECFXHI7z0fU6z/FddP9eqX7GJw+1XGKmd5C/6sGC1CCpKJeX00Jl8FxHvyZh/4mLzZ61RtwpYIeH+ss3rBMo2/huniBW5sJNCzddFIpKr+shdXDGBM6PqOsCj1Pc0RrSmr4qIMKC+Rz77fuLctlJt5m/d4zSmG9q/93nB8ot6/g0tn1Lv6RBZrfqcSpa5nVpa0qP3GhI4ydaZiMgG0R7pIIXwZk6YoLkH5hjWq X-Microsoft-Antispam-PRVS: <AM0PR05MB44201FA3F04B98612FE455E0C3AD0@AM0PR05MB4420.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:AM0PR05MB4420; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4420; X-Forefront-PRVS: 06237E4555 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(16586007)(76176011)(25786009)(316002)(26005)(186003)(6116002)(3846002)(66066001)(2616005)(956004)(53936002)(16526019)(68736007)(8936002)(48376002)(8676002)(11346002)(55016002)(81166006)(81156014)(50466002)(52116002)(1076002)(50226002)(2906002)(386003)(478600001)(6636002)(105586002)(21086003)(47776003)(59450400001)(5660300001)(86362001)(7736002)(51416003)(106356001)(7696005)(69596002)(4326008)(36756003)(97736004)(446003)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4420; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR05MB4420; 23:3xWmqqOJ5AsZyghz+eSs7urbNLqjU6B5BXfrhgWUf?= 2m7vkpwS66++EXPmKWwnNwzP8KWgARTNoEnSscsoT3RHALFJCoRyIVMcxRnyPu2bNyYfreXDwmFEK3EIc1Z5yGpeUDoaTMXVwSvTce/doR9HMcrdmqsCBbm2us7/0qr7YVgYS51NxLQHlM9HE5zY/Ea+I4QlxqPCOzK79WoSfg/Gds3myPJzoosAag07y6qQHsl7LysIJ3m7R1HPPwN3L2wilkhHIKDwCdRLcvj6+kpEoYy/9cfBMnREwzsz8pywNt42QbVvtiA0ylNUMHweYfDrKTpUOLSRxxLakkH7/ZK44T3m3vZcd7CCDNJ7xlSJyRg6sQAzAKtFZHMJRhn3ii4d3ghgw55d5vInTGemMCzXdYxSc4KF1PLmooIomD/1z9s1QYDd3GfeyCG1kt2OlsIq1gVB0ovqaQvnIiHa8jNtPHIPNCMwJZL+tOg/2ehDG3MBkvQsYXAGc0LC8bRJZLTJKWM8X069lKgRxj/FYQi4cllN0uRVh65X46NRdrIcpT9NrP5PKW9aq3upZESCbvAOUrye71xolB6CWqRTIQ28m2Zt01e0ipA2wkbGW90tKn2+xK3gLMFlOX9dghHF+7wtmcog/yTuU+i5UBTnaHcCOjTbBRxdIBNBxcnayxbO2esU1orwUcrnK77WQyALYS8snm7p6Ntt/7i0eri3FzNY0SeZ4KBFyhJkEdCT3ttesQrmKTLcet015NToI2xQiccjqT1CJgbDe8ZeIXEcspv7a7x457w3t3OiUG5Bo5RNxPzQo1URu5vwoIJJ5qj75JidFgg4cZ/n35t24+jc043SYO2bLB8ec3/NKRJYSovxOJwSO0PaAcj9IgVHbwNO/oP0YZsg6x7Mk09CK3KXBpQi88qyTzU1iGQiZbS/jUBwhkRH3ll0U5CAZxd2agZ/l71Pc0gDbgV0Jtw7awAzJQA48djrq8hkpqiEmN+Bv0L7/aZtqYQ5rX+BXrmWQEc5h2DX1TUydPN9F5ukMLWwHHasB7GR9LcPnzKCBSXzrsMy+aR3mCF4ahToryqY/xhTIk9ZQeLouNz8iiJv/8yxgRdRP+kJTyk0IAW1dWHPdUSnvPoqUUSdojRgKA2s57Q+L/99DG9OAYPMejwYJWvAizlB7s99Cn6AHJk0EKRN58Py+5rZGypalVA/P8ZS3onoz4V X-Microsoft-Antispam-Message-Info: Q3uh+H9wqUO6NrgEIoR8t9HSkMmFO3GV44WaHdYWqGWoLDSKw8mOWZm5tcDYd2RcJCnc9f7CJj5sdOEK9EO/nUIBlAq9WStY0iDBNabBAe1SvBFJNepwGcK/i1FEXrhSb4BOvK+9hrGtXeBNxouSi/iQJDO1KTIGN+QqBpfkLWs3IPhTrxJghhu+Z2LlXxbo X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4420; 6:MauM1sRhPmG6hqFPG/Jr5soUUuAs+QeOW8LRqUeb1ZuN7vLNfo214gSIwbM8uUNxasNHetFRBhyU/xNOCvhKXkC16cKNxZa/7P8PZgHL3kWYP6DJrHtoI4gjIECyqQfIBmd2wXrOItYQefX19Z1wHRKuMmLL/cj/Xs+/R1N6/YSnk41PkjhhHu/xkJBjORdBrwI4RpWAcDChNp1clxAh7WHyRW3VMLF9kAx1tKJA9nZkHIJgZhg0wf5KI22mW1vg2/e+UJxRmxvLPCBOfiPHiXrjgIm4mePL5MVqmHe2sD3eywNivYw8iQ/eslxlGjimbAZ6LbFyCSlkO7hTZNKNSBQc9XWA9oJnn45ZfQ6VqnYpGLONnoyXje7BCIKdq7h1uQ+CUR+pxW5qozuYSfo2vClemt/AKEChW/VDrHqOR2vPKQsLak574Wjhwo3S5hgZRUxZy9m4MR7JAJpZOZTZ1g==; 5:osY+HTtfsfdBO9eDJoLQuxUivI5A8cAEmCwMjyWQR25zvAKxEDX97xOTPZX24g+8L4/QR/bHmkvgkQtVq/orFg3ivEHyIYxfFpQmJ4qADQiWjvH9y2N7pVdcDLJHYasPajOQz7vzqauO3xVhMA/DaX4GSD+eC8C6WAF9rMnpoyA=; 24:6nS3/ngNM/ZB89MLVxLumuxrhxxjMmbRZ15sBsHt7FUGpRlzqnPEgTj/9qchjQFxHGHkrqPgDYAjz7379oNH3nfKw3VpfgrYdEpT1ENkOTg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4420; 7:CdsO5JgN05YQBCBX8QCBdCofLGm+Cn+5kxo5zN8zxjtdp8rhD0wgu3f8FE8lhQOJi8ygngAMvP40ZFEoP2UZnW+rmUfFZOm5lrUI/mR+tJr/43SGF7NfJ1W7wcXyAFiFku0ms6CAFoACmnfyYdptYvZGzgCWRldwH2JuSZY45FJi0RGq0D7x2Pk+8bI9VL5zxY4AmsiSGA72LwD6dxA52qbZrPeu+kDZwBacV1ZODMRmcCo0NKHXwbxP+r1wJExv X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2018 10:13:10.1148 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edc60920-16ff-4668-ce37-08d593022dc9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4420 Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix RSS key len query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | fail | Compilation issues |
Commit Message
Shahaf Shuler
March 26, 2018, 10:12 a.m. UTC
The RSS key length returned by rte_eth_dev_info_get command was taken
from the
PMD private structure. This structure initialization was done only after
the port configuration.
Considering Mellanox device supports only 40B long RSS key, reporting
the fixed number instead.
Fixes: 29c1d8bb3e79 ("net/mlx5: handle a single RSS hash key for all protocols")
Cc: stable@dpdk.org
Cc: nelio.laranjeiro@6wind.com
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Mar 26, 2018 at 01:12:19PM +0300, Shahaf Shuler wrote: > The RSS key length returned by rte_eth_dev_info_get command was taken > from the > PMD private structure. This structure initialization was done only after > the port configuration. > > Considering Mellanox device supports only 40B long RSS key, reporting > the fixed number instead. > > Fixes: 29c1d8bb3e79 ("net/mlx5: handle a single RSS hash key for all protocols") > Cc: stable@dpdk.org > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> > --- > drivers/net/mlx5/mlx5_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index 365101af9..b6f5101cf 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -428,7 +428,7 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) > info->if_index = if_nametoindex(ifname); > info->reta_size = priv->reta_idx_n ? > priv->reta_idx_n : config->ind_table_max_size; > - info->hash_key_size = priv->rss_conf.rss_key_len; > + info->hash_key_size = rss_hash_default_key_len; > info->speed_capa = priv->link_speed_capa; > info->flow_type_rss_offloads = ~MLX5_RSS_HF_MASK; > } > -- > 2.12.0 Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Regards,
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 365101af9..b6f5101cf 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -428,7 +428,7 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) info->if_index = if_nametoindex(ifname); info->reta_size = priv->reta_idx_n ? priv->reta_idx_n : config->ind_table_max_size; - info->hash_key_size = priv->rss_conf.rss_key_len; + info->hash_key_size = rss_hash_default_key_len; info->speed_capa = priv->link_speed_capa; info->flow_type_rss_offloads = ~MLX5_RSS_HF_MASK; }