[dpdk-dev,2/4] net/bnxt: add support for Stingray PF devices ids

Message ID 20180321180629.58318-3-ajit.khaparde@broadcom.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Ajit Khaparde March 21, 2018, 6:06 p.m. UTC
  From: Scott Branden <scott.branden@broadcom.com>

Add support for Stingray PF devices ids:
BCM58802 = 0xd802
BCM58804 = 0xd804
BCM58808 = 0x16f0

Signed-off-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

Ferruh Yigit March 30, 2018, 10:35 a.m. UTC | #1
On 3/21/2018 6:06 PM, Ajit Khaparde wrote:
> From: Scott Branden <scott.branden@broadcom.com>
> 
> Add support for Stingray PF devices ids:
> BCM58802 = 0xd802
> BCM58804 = 0xd804
> BCM58808 = 0x16f0
> 
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++

Can you please update driver documentation (doc/guides/nics/bnxt.rst) with new
device information.

Also it can be good to update release notes to announce new device support.
  
Scott Branden March 30, 2018, 6:24 p.m. UTC | #2
On 18-03-30 03:35 AM, Ferruh Yigit wrote:
> On 3/21/2018 6:06 PM, Ajit Khaparde wrote:
>> From: Scott Branden <scott.branden@broadcom.com>
>>
>> Add support for Stingray PF devices ids:
>> BCM58802 = 0xd802
>> BCM58804 = 0xd804
>> BCM58808 = 0x16f0
>>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>> ---
>>   drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++
> Can you please update driver documentation (doc/guides/nics/bnxt.rst) with new
> device information.
>
> Also it can be good to update release notes to announce new device support.
OK, will update.  I was not familiar with all the changes necessary.  
Thanks for pointing this out.

Thanks,
  Scott
  
Ajit Khaparde April 10, 2018, 12:20 a.m. UTC | #3
Patchset adding support for Broadcom Stingray product family

Scott Branden (3):
  introduce Broadcom Stingray
  net/bnxt: add support for Stingray PF devices ids
  doc: add Broadcom Stingray SoC support to release notes

 config/defconfig_arm64-stingray-linuxapp-gcc | 16 ++++++++++++++++
 doc/guides/nics/bnxt.rst                     |  6 +++---
 doc/guides/rel_notes/release_18_05.rst       | 15 ++++++++++++---
 drivers/net/bnxt/bnxt_ethdev.c               |  6 ++++++
 4 files changed, 37 insertions(+), 6 deletions(-)
 create mode 100644 config/defconfig_arm64-stingray-linuxapp-gcc
  

Patch

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 21c46f833..a4042420c 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -97,6 +97,9 @@  int bnxt_logtype_driver;
 #define BROADCOM_DEV_ID_57407_MF 0x16ea
 #define BROADCOM_DEV_ID_57414_MF 0x16ec
 #define BROADCOM_DEV_ID_57416_MF 0x16ee
+#define BROADCOM_DEV_ID_58802 0xd802
+#define BROADCOM_DEV_ID_58804 0xd804
+#define BROADCOM_DEV_ID_58808 0x16f0
 
 static const struct rte_pci_id bnxt_pci_id_map[] = {
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
@@ -135,6 +138,9 @@  static const struct rte_pci_id bnxt_pci_id_map[] = {
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57317_SFP) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_MF) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57416_MF) },
+	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_58802) },
+	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_58804) },
+	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_58808) },
 	{ .vendor_id = 0, /* sentinel */ },
 };