From patchwork Tue Jan 30 15:57:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh X-Patchwork-Id: 34731 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB7EB1B657; Tue, 30 Jan 2018 16:58:36 +0100 (CET) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0088.outbound.protection.outlook.com [104.47.32.88]) by dpdk.org (Postfix) with ESMTP id E4FCC1B655 for ; Tue, 30 Jan 2018 16:58:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=anOVZsiLG6vf/EwERhPz1UT87QYUi0IAZGMHhu4iF0g=; b=ZWebjuGBxxEQpsGIOFY3ZCiRJ1QIPxXsFkdZR27yhk/wvIToDwDSdkpmiOp7/JmeDBVQ5M2jlwDgy5Li1X2y5Ubr0TmeajXSwrpWvPFQaN4eST2DDwAUu9tC0+6q1E9nj1t1JQqqWchCbiayCcmDrt2v7KxCOeSuyTS1WFRn32U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from localhost.localdomain (111.93.218.67) by DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Tue, 30 Jan 2018 15:58:30 +0000 From: Pavan Nikhilesh To: hemant.agrawal@nxp.com, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com, jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org, Pavan Nikhilesh Date: Tue, 30 Jan 2018 21:27:47 +0530 Message-Id: <20180130155747.12501-1-pbhagavatula@caviumnetworks.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (10.174.208.144) To DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55009770-e98b-45ce-44a7-08d567fa5061 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 3:RVZv0zvWm5p/MTPYwVbYhKhg4BOqLaHzlqC1Qg+xujQJoP4MLDQ/0GTYOzzKW79XKX1lHH8S2intaqRBrDCwGOGbt2U8xypycu4tlUYLowbPNO8YjwPIZsXZ43QFIZK0WGfDTzmLrjX+OPzPIBOmRs41z3YE+Dab0YFx2oNiwadd8LoHkPLz9W5JIFWhAkDFf7gM7j/dYOWlsdIiI+T1TyiFlc5DIhmsARLG3RIlJarScKUh0kqiRsC9v2EIc87v; 25:UQZ/dMkaYE7t3nbIN1Trdr6tanSrcJJps72xYEmN1bbMrFiOfpJPSDLZrfcegtG78b4uDvaH7Av125mDlrsEyQ0+QFM+fyjam04SKAzD1fIZyKRUvN687Y0rSFuSxElcn64jKMuLcsAcVhxA/E7GDYrfV+/RUPpYIlrZd6Wj4z5bh74QsL9rblTBw72ktg/8Sjpr5ZXJBNQjoSsYp6DsdfLBO4P1UHUZm3WkZqFowMji+J69HwXP1Qtkyn9xqW+ox1+HlTwUabLteYqA6/9stK9DYzDb1Fw+IovWvtZd+SYkf40GWmumRPu2Uu5t6GM9iE4mCzdOCjKxoU3Ds1y4NQ==; 31:42+UkI4AsViz5bYBdyWGie+gdkxdOXgvqP+FWnwwsrRFYvW0GopTqJPmVyZJTkN+2uqRAYXCRZ7ewlSLjYbF60I23+mIGDDkXHnbslfRorrH+31V+nWxYO6elLFVeerNSL9jqzxOgH3eGgyqFYYWj+8jTZvZ45r94lVh+H4AOITz/3SaskwgVU1ou/15Mizjmi9zSHA3W2FYZvsu+/6L2vUSSdOeEy7a81xaTmNC2mQ= X-MS-TrafficTypeDiagnostic: DM5PR07MB3465: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 20:WQSWK/Nb46eyGdp66kRBXYl3FfoOQ3qZM/QiXDof18jYrKEBkTJCZHuKyUprmW0Ehzod1L6R4UiR1EEiIgrfM1Ih0mX128HltShjt5xW1gkCr2E+5s04TXbWYTOiPaLuVhaPDayRBrRo0WyC9v8kz0w8QipZSrlTorZRHHOBUAfPGNYGM0iUHaE3a8wenbk3V3Gqf/ZYsISOBy6Qh49iwiXyaZXY8Hbiw8hjRkRZD4M8HKb6IZOyY4k09N+uNAEmNytIbA8b+OR/V2I3QJ6rpVJsC62eU0jn9sbDIWJz39FZoVnb8ygz/6+K48vbY+M9q9++1KlXzVgWOMpxP5wPvx0rf4U5lf9uNE2Fck1BuVrfXi5KfUCz1B2Ye/Sb+q3J1wD+TosyYLDmjjnoQ0AVWnu4leOebj2OtfhXTyImXjO5I9KqXDQzYDBm+SI+qodBxuCR+/VVbFCeM1gIb+4jz563J8PzG5W8PuWuJjJTutlITOIKJ7L1mS2niltPQA4hJRFkkxIeORZB94PbrIBsq3bCMiNz/LuLP9vXiowT+3B+aqKUburiS7e8gLOxYdZdAPknn6MK6PLkN9PMd5dA9ti9I9JxYl1MEIiPyDxDw/I=; 4:jgitDcZ+LafmONM6aH38X+ULXDByD282Sh/y4qEruymw/MNS0CAwD3DheZD2yjSrh7Vrfju+o8xz4M3tiOcVTX8ITYOsLqK8k4mgRABGwpGfAvJHxmHQdv0MvVz4cO8kRmvGNA+zPgtgsu5np8Y7BscjCkg4ITmWkTkcDB5EhHRUvJbHzBfp4kRqLXgvTwzGk/lIae4TgzrvTSb39JLeHTj54JRYlkuEGnP4fYgqnaA7v+iJ+dgBvZfJ1wR3WofCsRcJYdowNeibSYDnw6GFxg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(944501161)(93006095)(3002001)(6041288)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR07MB3465; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3465; X-Forefront-PRVS: 0568F32D91 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(39380400002)(376002)(346002)(39850400004)(366004)(396003)(189003)(199004)(42882006)(25786009)(5009440100003)(16526019)(1076002)(107886003)(97736004)(5660300001)(47776003)(105586002)(66066001)(8936002)(52116002)(186003)(2906002)(305945005)(81166006)(81156014)(7736002)(316002)(72206003)(575784001)(8676002)(3846002)(6506007)(4326008)(6116002)(36756003)(50226002)(16586007)(6636002)(68736007)(6512007)(386003)(8656006)(48376002)(6486002)(50466002)(106356001)(478600001)(51416003)(53936002)(26005)(6666003)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3465; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3465; 23:5a/78H20f52nw7LVgKINP3InvTaYvhRGt/rap42Kt?= i6QV5/n63lHbUENz3Wqd/xSZvYarGxS1Z4wZmwbWIiLerdRaXms1558l3is0JHX8Sc2LuothJY0zVN0R/NwIBAHxe8uNu/ZLTY9fhl7MsyniRZt+AiTgixVNabVPR1+Yj0X9FNikdoZlMm5BWEfcVvIrhYJtNegiqm4nOHOU94z+3tH2d+Lt7FhllygvxI+rOQ6GQBTCnZ7W6u7i48ET6IR3btX+Q9BNGnIldPMB2mB6ONdSKxYids/786QTGSE0Fh8biFiKrgUmgyb0SeAq9Xg6kQBoxJc4sR+ZEqrHicK5sByYGHEvRzLanW473dqml1XJX7v0MtgHlZsAC0dQWkX2HOMkVu6lJGsAauifR6INyTqg6JdQs5Beky0vp25CxkscZpH+wbPyS4+04S9HSbfoM5Mb4mYfV7r3ahK5WFkXvJYytd9IRdd920KRMxLhOfhIZNNqATPN7u3Kx44Co9Q5x+e67UnSoKRDrHwoZlpjHMj5mEf4Uku1e6lu7lRzaDxGOEIODu/SItrZ9bopQPq+hxk7eh2zCh6tk4m9cqIsc7gnXzeRnzz8dJF0BHZXiQI7wnDYm40iLf2vPJC3sEoydjW3e4pVsMTx++IY2X91dQqOGyBCr6WhwTehuvBAFnfQOS+ngJ4Splwy2F+GQSYS3zvENzbwCxj6Pnww5ZaA9bDEAbwgQxJ/6ccDR8IK3XdUGneqUrpzbzB3vRee1jBjxPrW30AMd1oMTrJE64WAWqNn0lxBMxy7TD7s+BmOykNPOEPRfHR/kt2XBk7mkIwD4d2A+G4KaTrA+tIMtS6aIqqbvYSHWaTOt5twth6SJpQDx17JlzuZJFGP3nSg0RqehGxPsoY9Qas3tZjTQjzBBU1Mc20LgBPlBDhqz+1oNKOMG0tE273tzX/HE07Td1NHUAwgrPpUCytjaVz8GJhsaksqWvsWewcImRyuLGu1zBzZrlQf8yB8R9Ri1ITOzD6CvIaWYo7rum7cestrGxYQb3QEYMvTcAcOYeEOlI9pF15i5ER7txhDH4tTk3R6b8Mue/tOivAMEHfeIzxK0VhC2+i33XSoIAzeRTeJ9UOPJ5en4g0TXAAiyfE4Eep7RYACSpht8S6AI7sCeDWtzHCMMCEkc3jNEOz7Gey+HIDUI5DhglkwamCTn9nhDEpHucmuR2iufRNl+ynGHS92Sck6g== X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:wnYRUBeRhrm+ALrR4jZOpqUG9aLbArLugyrIDb7Fq7ZEKHa4G8ik0BYLap3te2EdCBspNzoZ+GyhcevcQ9iNXM2JF+X6DeZzN8eaNiv/B4xlZgp36kD3gxvChtWtqsAQh0w5X5o1jgx5zr/r987hJCCr9BLTJA25U0ESx0vbrGCnUUGYBG8OXjSzX9I6AZrbpmBDYzq3ppa7pyq7/bYVjHRvKOkFo8ScTkDb4xFc0sYDwRQ70WDfx6GBy7HXeVjMsQkRQGFvFV4pUsdkBbWjsXZoGocTjEMMZ9bOOyNYQDigFZwB9UTLZzqvAP4J6dWlUu23Tyn5XD6bS8M43BlRxP7TGZhjrMyFaPDiiXtISgk=; 5:2Kjo6Cp/u9r6YtOaNBjaUanSi0AwESYGHcn6aZIiBe4MBdtfqZXbxRayAgasgp0bsEeNUHyxJyTBb/UmxojfMjrYSUJhOhP2qPYy/MLwe/nwVoHhjuaav9VgS6xcG5kaUrW1jTlUc2s6L4VyT66x45+9qtpouTCWI6YEVPsNlY4=; 24:2lKP0DFv2MSEJna8uW0mtmBJ41Ms/JEdIbv7GRdrWIh/ZYdLCkB6sNZGjicMNPXiMHX+8CVs5mNDd656+F4N6FkgEkltrYs++PdCC/k87Xk=; 7:uqpQyyxUDYpmoecLp4STwIUByAPZc6f8il+WdaFUWSsBbvH9CWjhCy5bCSw+cy+itLFd7FFscqUhYVkDGDAxxf233JiGJjB4xgd/95w0/yGodmyRAeEy41z4rWoV8uyQFcQtDsWyIlxvOTW7PdPG0mfpWESf37XR66X4TQ8HiJPQoX7B1FP5MnXQdEbBMQ/YThmYVxqHIjtjqajbpWMNfyMnmP4+QBctmBh3XpBTZna9MEOXj5BlLOrLx2Yk0p6Q SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2018 15:58:30.2392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55009770-e98b-45ce-44a7-08d567fa5061 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465 Subject: [dpdk-dev] [PATCH] eal: fix default mempool ops returning NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If '--mbuf-pool-ops' is not passed to EAL as command line argument then rte_eal_mbuf_default_mempool_ops will return NULL. Instead check if internal_config.user_mbuf_pool_ops_name is NULL and return compile time RTE_MBUF_DEFAULT_MEMPOOL_OPS. Fixes: 8b0f7f43413 ("mbuf: maintain user and compile time mempool ops name") Signed-off-by: Pavan Nikhilesh --- Currently, test/test/test_mempool_autotest is broken as it relies on rte_eal_mbuf_default_mempool_ops(). lib/librte_eal/bsdapp/eal/eal.c | 3 +++ lib/librte_eal/linuxapp/eal/eal.c | 3 +++ 2 files changed, 6 insertions(+) -- 2.16.0 diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index ba1811a00..07b229fc7 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c @@ -115,6 +115,9 @@ int rte_cycles_vmware_tsc_map; const char * rte_eal_mbuf_default_mempool_ops(void) { + if (internal_config.user_mbuf_pool_ops_name == NULL) + return RTE_MBUF_DEFAULT_MEMPOOL_OPS; + return internal_config.user_mbuf_pool_ops_name; } diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 66f7585a3..ddcdb6e1f 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -125,6 +125,9 @@ int rte_cycles_vmware_tsc_map; const char * rte_eal_mbuf_default_mempool_ops(void) { + if (internal_config.user_mbuf_pool_ops_name == NULL) + return RTE_MBUF_DEFAULT_MEMPOOL_OPS; + return internal_config.user_mbuf_pool_ops_name; }