From patchwork Thu Jan 11 15:13:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Harton X-Patchwork-Id: 33595 X-Patchwork-Delegate: helin.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D37E2BBE; Thu, 11 Jan 2018 16:14:04 +0100 (CET) Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id A5A951D9E for ; Thu, 11 Jan 2018 16:14:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1328; q=dns/txt; s=iport; t=1515683642; x=1516893242; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=u0JyoaWqFjCallZVLr9UctPDdrFrEePlucy49ogDqgg=; b=KXfcsZMk0NYSZpcqn1WkRb++4KoJr6XSKlp1xhxaUk9sMnAhHLkdErfP t8xduRHy+ck3FDrdSAbkn2lu3qJMkNdx2kx8Ls8kXsvyyC4QWQ16KwtpP KBHIqgkfZuXiJbecVMZi9fCpfyQ8V3fbOrvFFmxmyxprEnQjAWpyniUzv g=; X-IronPort-AV: E=Sophos;i="5.46,344,1511827200"; d="scan'208";a="345093585" Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 15:14:01 +0000 Received: from cpp-rtpbld-31.cisco.com (cpp-rtpbld-31.cisco.com [172.18.5.114]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id w0BFE1Yr019007; Thu, 11 Jan 2018 15:14:01 GMT Received: by cpp-rtpbld-31.cisco.com (Postfix, from userid 140087) id 600657D0; Thu, 11 Jan 2018 10:14:01 -0500 (EST) From: David C Harton To: jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, David C Harton , wei.zhao1@intel.com Date: Thu, 11 Jan 2018 10:13:58 -0500 Message-Id: <20180111151358.20102-1-dharton@cisco.com> X-Mailer: git-send-email 2.10.3.dirty In-Reply-To: <20180111134814.1224-1-dharton@cisco.com> References: <20180111134814.1224-1-dharton@cisco.com> Subject: [dpdk-dev] [PATCH v3] net/i40e: fix VF reset stats crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Calling i40evf_dev_xstats_reset can sometimes crash. Fixed issue by checking return code before using pstats. Fixes: 8210e9e0d805e ("net/i40e: fix clear xstats bug in VF") Cc: wei.zhao1@intel.com Signed-off-by: David C Harton Acked-by: Harry van Haaren Acked-by: Wei Zhao --- v2: * Fixed fixes line in commit message. v3: * Modified conditional to check ret code instead of pointer. drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index b96d77a..d5a9edb 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -916,14 +916,16 @@ i40evf_update_stats(struct i40e_vsi *vsi, static void i40evf_dev_xstats_reset(struct rte_eth_dev *dev) { + int ret; struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); struct i40e_eth_stats *pstats = NULL; /* read stat values to clear hardware registers */ - i40evf_query_stats(dev, &pstats); + ret = i40evf_query_stats(dev, &pstats); /* set stats offset base on current values */ - vf->vsi.eth_stats_offset = *pstats; + if (ret == 0) + vf->vsi.eth_stats_offset = *pstats; } static int i40evf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,