From patchwork Tue Dec 26 07:40:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 32695 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67FCF1B361; Tue, 26 Dec 2017 08:40:57 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40050.outbound.protection.outlook.com [40.107.4.50]) by dpdk.org (Postfix) with ESMTP id 55DD51B340; Tue, 26 Dec 2017 08:40:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FdGLrgINCZwwMIdJg/qiY3DGMVH9LlXnKrdUB8u4BTc=; b=o67wH3PuTUWRaZKXqsoOSBwCuNn+qNZrvE3Q92AxGepCrQ/Lh2pXBaRt+jG6Xhd7cVLFK+NdhNPzXNQYZlgUl8i7WhkzjUNWX5O2ZIqXiF9VP9krBrV/vnF8ouXqa78TqsU+f6ygu7ajwGxliAI/sn/wNn6BYbcYe/KQLE31JBE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by AM4PR05MB3140.eurprd05.prod.outlook.com (2603:10a6:205:3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.345.14; Tue, 26 Dec 2017 07:40:53 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, yskoh@mellanox.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 26 Dec 2017 09:40:41 +0200 Message-Id: <20171226074041.38030-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: DB6PR1001CA0025.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::11) To AM4PR05MB3140.eurprd05.prod.outlook.com (2603:10a6:205:3::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b4e9247c-a10e-4d5b-d853-08d54c33fe93 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060); SRVR:AM4PR05MB3140; X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3140; 3:oBegeXuMc3JvH8K6T3CLh8VbIbLh87nSmcFkon3N4VEUXQuFi0OslIPrtWu+CWEdVkclbocz45x52sxs/s8NWNlBOkFT5WqtZqET9FsuhpEK2/BhV+New38aNdFmtUK4KqBBSRNjy0JTvK+v3RnJu5Ao5AMLwQYD2lH5EDB5shnfn/bh6+lrKo7v1yHMMrYYhoaY5melFFMybCg3FyoIiG6d4po0gi/3iYZXDnTnxCxt5yvMtglPYKmnGhbdakKn; 25:gPdCrbyaGyBRvb7RDAzU62qoFt+8wanGVtfPDKgEImqYxUmFhM4wOK0lm6Hd6xNgxSKqnJiZJN7iKIfnNTHdgoQD6ghZwARaiBeCmzvP7JeK5A6XtBOCWX5/ZocFP6S9EToAG7HNvtXw2NNZ6s33gJ+I2AbFcP5gk0+rm1GZEO/Nk4/kd89n2kk/jav/i4EVjFhrtd2N+qPOH1LxDPKs3zhYunrd716Hrw2IdPY93tG0p1GW7S9PQQy/ahYqn98sF8QtouCRGtfZxhMMzYupOa6AZaerlMqy4tseVDTzfBJgu1YnACtFFCV4YhHd3he4Fm9JjYm3reFkyqS4Ibu5ZQ==; 31:RLEOlSHZUiViCcqSi1pgJHawsMZ7Ip7PsI4xCguMIsEWAYjGPO+FrN+BMTz8MPppYwpX1GTI7PJv3Ve11fAzOcsJcCepOE9rLQVwoavW6aNvOfEK4ekMHSMwnws1nZPVp9tL3XifN1nlf+kgInjKi/lYQd/qVZW82zBrz2+1kDmcbZ5ZsTj8pOyVKR8EJpo/eBEmMXCwWVldqlW+YV3mbTLDod6ZvoSPr646jIbdXcY= X-MS-TrafficTypeDiagnostic: AM4PR05MB3140: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3140; 20:S1zjFiK2BXlIiXgxBVSJpYlBRstSMV5whW1AnRSr9wipxKO9f3dPlXfj1ErHUvoZ+AMaIXJIsLhyBwWVxdnpfEBaHQ3f5/+xgkEk+WfrdF5fjKstIMV8gkqXp5x5nOem9K4su84WeNNJ7gBM1t2KpjajszkVXiWQQm/iB1Z6jQm0Ol9C+dPOQnG3tw4cMtI7G9mff/fyqFiGe+YWv2dkG0UbrBlilge20vNFNFlwRXjum8D4mnqa+Ms/mUIQgzfoEqINGhg5/UJCsFE3DFMBou6MBt58oxZ9YdFUW6wUJARjtO3MC3WMe85HKUS42tIoUs2igGk0lDmJmerDHKEP7mp3zZpvP1sKGPeJney6JoaC+U0TX0K39COqydfsWPw0Zriq1HW1JZEn0LLgKXp9SHh/xhsmIas0se/vjJMuGKcGswXdDh22ruHGbilPzfrF4Nu85d8xUJsHdrii/KGmjmenhBehAjIZVtOPq1HXGu3KGotOcKYUPX3LD5RoFTgn; 4:2NqHG9LsB32yhW/8lBqSSvoUCkJlrnHnDJ8iXvz+FBnqeBAoKChvkq27Zvz51fGmr0T7ygxQbEyo8VcuYI9kl28aLf9FDLL8h1uy+NgSwCbvkW3gmWsAnJmQ6N74g7O1PgIuOBc68nT7JGFrIxzVds4+jXGzvTXQFKALMhuQ8KzcdSwlKrtQqZHcSkLcGJYstoXbqvnVNVRTK4IphthQhMoGD7ov89eJt2722LS0rj37RikTr7Pe1SZ0rog14KLolQeu1rJQ7L1gec4iuxGmAw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231023)(944501075)(6055026)(6041268)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR05MB3140; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM4PR05MB3140; X-Forefront-PRVS: 053315510E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(376002)(39860400002)(396003)(346002)(189003)(199004)(55016002)(105586002)(106356001)(52116002)(50226002)(51416003)(7696005)(8936002)(68736007)(59450400001)(16586007)(305945005)(66066001)(386003)(97736004)(316002)(16526018)(47776003)(575784001)(86362001)(1076002)(81156014)(8676002)(81166006)(6116002)(3846002)(21086003)(48376002)(50466002)(7736002)(6666003)(53936002)(36756003)(4326008)(5660300001)(33026002)(2906002)(69596002)(478600001)(25786009)(309714004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3140; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR05MB3140; 23:kWeNODvGxlOpSmx4lgvUSchX1j2EV4dN18mpCytRm?= 1HhdBQgTO1UGTFITPiirQ6cJeNh3rHLbP5nQktybL5JdFNDiXpEcyWsK4SPMHcLQAyAd397L0rZDOwDC6MNGdcYkZ+5+iF+tucI15LVYuoyf2RRgjv2gA7motB3lVuErqaPnMrsEctquY4HI6CChu+n945zDOjFJkew+4iREahV+Oyx5OWJ37juMwjIW9YQENDZJ/HoKLRRgLHF0BGmDbjdULkSc0F0buzMW97R5aoPTeUzSmrDIfoIZJMMYMjVhAefGpEka93MGEMzm9wTkwhvBv/3FhqwdU2pMK++rBXjSvm0l99FwWUA0XZnlShkYmXbWXqz47ZjpMpNdsHXxwRC+QBzrHEEzD7nTTjoboBzMVzqfh8Lx+bj1agTAJJ6af1XwlhhQaTMKZcF3Lb9GV1quTml1yAlShWUeD/wrid/MjuQuwbZWZyB2esXDiKwfcttPFhyzX1tdIY5ow29TD216Rw4rqB9TREPRm/mxXI27MU5lCFsVna3+fslKMUWo1LtFu9msgpeJpAgfVgoD3nPn4QLY7UV5vthNB9Iu484ojbnD7eKvnezeqad3XAlbI0xNuYsbRFXn+xrFW+D+DJiGBKt17rATmIQmm4uVPFJH4RqZpe4YaNQk4CGZqed1K1dy9byBXFnOtXlsqPMQP5ulLcP06fvQ9HXgZzACGh3FFGV/RAmuDf8ynJNMJkq+3w155slAL0TEj51sJuLWh6+yxVxOv0TCzDyiR7jr4o0cT+JTNFhyiD3eshOITCRaVAt19XlSYApPbij3+Vu7KTa5HMJbSUhtI8QfjPAwTaqNBDuvn7mC1TacTMvljtFiqlrdyX47uUZY0ho/ZR52Yj4CaqeFubXyULMewNOrJzcxaammA50ckLW85M6VADfR099XCTuzz1nMf2h6XMmOZSkuXI/hf2/MzlydmWyIBH6mJNjRN27NF5+h/qPzlgB9oE7dSRYTdGZ4g2hFZ/+it8YFKCMYF6HItEeDdaLhBQ26odtqG/YSZJs5NNNYO1CN+UIQ3suxAgWW3q1CrGHb7y35LbhDycbJJpvpUSFv2ACI+O3V5PGbug4BvWdCPM9cDdXqtQHsNPiUGQm/hvGff6v X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3140; 6:4IE+/4W0BfpFvnqJL5hhSx60r7eqf2aPqThQh+GwarsyRClt9A1Lr8ad0nupDj/Nc9vhvVs5nFfeKMV3M4SPr5e44cFZT1h/SDE+Ybw/gtVPOTNXbLDQffg3RnapgdWAUlvurcFGATWdp7mUbqBLiY2n3rHnB/uXYD27yTddcB0IFq6DRbqZMiijQJUzpgng3HyDzGVwSNuyFIPJXYPgciNHxmixbCNBB3L+cKBoHv8QKTxMPx8AbKQb2JmoQ+UbtDcl878tLJrxAMYWGblg2ZfWdjYaWI8luvJWSBMdNw3sJoQ9CilecKrL/QR1YTSpOMMPSq9pZl27A64J7T7igtOcKUH4gfTCoxBhEBvQnB4=; 5:pm1JodG8Uq1rc3GRBKCSin1ycLIrqb6cnp9RICx/F9Plpd15rg4AJOiTvtoTPB1y+djz8TpKGmxuklIVXLA5sTnesRlY2ZELN8LuYQqkae//8xwPnSXLkWCQwSQzHn5Z08CKDfsmlSw3Xn3ylz3IB8Jx3fOiStrmNCdKgYl1w2I=; 24:I5SN9vy0nCvZEgdBywnFn9rOQwrJuUrWX5CMmhxd4ZtkwhiNEhEeLvegm+54ef7W514ZK7Dhu7oX5Zo7HLrkHfK06qf++hDd1l+AcdjOTao=; 7:BG5lwG4p9/In3bM+M0bx0AHgHXdwbCjGfN45L4/fnZPKLsfLKSu01b7JLyRR8EoLjZd0zOFjNtAF359AVRt8BkAn1gxVjjdKiQgMhAgGMbAuDLuJLA2P8DZpdPyOoUBw5nEt3XdrTVlp/KUu6FrFnO1qz2ahlWvLRlKkg8TPj73JBi52lHlhGWqlRK8KmxkEWK8tuRp5bxZywJvdSCrzsD2FdWDNzKyPuX/+PR9h/7yuWl1mX/+k0/cwU3IPmiJh SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Dec 2017 07:40:53.3438 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4e9247c-a10e-4d5b-d853-08d54c33fe93 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3140 Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS key configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The trigger for PMD to use the application RSS configuration should be based on the validity of rss_key and not the rss_key_len. Otherwise segmentation fault can occur if application provide valid RSS key length but without any RSS key. Fixes: 29c1d8bb3e79 ("net/mlx5: handle a single RSS hash key for all protocols") Cc: nelio.laranjeiro@6wind.com Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index ca9ad0fef..282ef241e 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -550,7 +550,7 @@ dev_configure(struct rte_eth_dev *dev) unsigned int j; unsigned int reta_idx_n; const uint8_t use_app_rss_key = - !!dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len; + !!dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key; if (use_app_rss_key && (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len !=