From patchwork Fri Dec 15 01:59:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 32294 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CCE21B00C; Fri, 15 Dec 2017 02:59:42 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0066.outbound.protection.outlook.com [104.47.1.66]) by dpdk.org (Postfix) with ESMTP id 5152A107A; Fri, 15 Dec 2017 02:59:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8Eyi1C4GTaK0vpqkA956jpnjWa/CfZSfUCG0qwjtoJU=; b=x1Ef9Ct7hl1ZkLH/AjE7/Un30QECDR6kq+YVWDnGm7Zs/bK5QrNujyny9I4/NhujXdfLKu0OBsiWxXEThXW1jobwBXC0gMWK7ON7gbB10Vbx1IF4T7D9LLCmRZpf6PxfnFmTiAmdyZ+tbWucHeQW7U66uljSGrtdAqqmLYiqXsI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2047.eurprd05.prod.outlook.com (2603:10a6:800:36::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Fri, 15 Dec 2017 01:59:36 +0000 From: Yongseok Koh To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, hhaim@cisco.com, Yongseok Koh , stable@dpdk.org Date: Thu, 14 Dec 2017 17:59:18 -0800 Message-Id: <20171215015918.30981-2-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171215015918.30981-1-yskoh@mellanox.com> References: <20171215015918.30981-1-yskoh@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: YQXPR0101CA0061.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:14::38) To VI1PR0501MB2047.eurprd05.prod.outlook.com (2603:10a6:800:36::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a4118d1-c90f-47f7-c444-08d5435f7f1c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307); SRVR:VI1PR0501MB2047; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2047; 3:NNjZQjMCPqPU5bhGChLh/wU+qAaY1ULHey7Pk50oAcpAZ7Of/j/9xhJCvmcN1SqzSJqeMsFcbFfpd8Hxek9Domo5FUQ3tJ+CM+ur5cxNzCbM9kcY05N2V3Ym9jywtSwUNKQ+B0fEX3oTmCVGpVdLdUmxV3mr7FzRXkkJny4rIzpT7U7fJWgyOx6rLd8PxqsG5HJkPCToOgHI88U2ZkbR5m6IEv+jaEnSjhdsH7FBpfAMoVaqtw3xnyGbyOcBSk7h; 25:fWs1BgnHrnoW/g03DUYWyylizQZbGVTxNG/6vqn4gAaIAMn2Ryy5a8fLo5gz19StVaquL2MdPr1ImUEgW/lIFwSz3uc2ZTS6q9y5TyrUuPGSWNbqp/wKfZIs6TQbZdj3rB/dQIYLkiz0W2DjsE0t0ecTyRa9xHmQO6zYJkjpVew1saQu25/EqSmS4Oq/E2VkuWBSrZsCrsZbPI2p71DH15hL9dmDGE1egnrmEmFJXdcDEgQksuafr9n/WXd+NCC/GpGWXWYJuCPRXnn1AZCSFg9Lk81VBDaPwf1sxkwHPSE/RuO8zp08W/oRK2H28M+RbJVo0FJeawolKuuK+LFV0g==; 31:uNqRB9jgPT4lDJYNnE/p2DKUUhNPnCHnkvQrPemZ3Aeenv+OmaLy36IIzENdBU23kuDTnVGzTxucJs4dDhe3TCsU/RaGzDYayJSQ8H0jxewjW9h5SpNyHE3gjaI6mq2zdNftdTQ1F1YUaaOZ1ArXiSTED6LoyFTyiTSPIPeHi4xHyXDd4aqbIOBwN7jqs7fl7fz2jBQ0keS49MKQLtrMCv8tFQlnkehBuK9NK3Sc1wA= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2047: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2047; 20:Fo5e9GtbI9Un4xzQ3H8Kn+VubydUzy/iZlwoS1rHIc2K6PS02kEo5z58ItUbrByFdQmgHNqP+KYUI27wntFWzcXBsdZ9ui8Ti2ovzoub4YX4xa6a2HtQ/BjNFS/VtNkP6h3SuSDDDIgpWNyVrsy44sPvy8k6zQU+Ji45IZYteQXTUwp5yl58NI2KP/b97/+dD082u06EGIiQ822tJIh0qBWRwU+GE69W1fnXC0/VO32++l2d9kMuIvJgPRDsmWQcUej2dNcMQGI9GPzxWnpJeD9PwOUtv4UjI4FD/94aQOBlNFnbxZZR2lkTeJBTbaSxXjDtStFBkt7ayuQ5+C/FnqmQNSTJdzoi61QHnVrUTQ1eXl296VldYYXFPIfOwT574Nxpza6HyZvN6lR/8N8sHB9o7qX6ckhLQ00QQy9OYvMT/D2woDh8RO831wBGF69nWWD8Yz5rmwSI5CdQJPXHZWOm3/aYxl/uyVfBssSql5CaZqSmmdT4rwxx1M0K+TdI; 4:8yUprZAMagZJS4+5ZuZspPf8QnIMfygmHcL+N3aGcrekyVxvi+sh3lKrTMUVYAK0fIcExEtJLalSqeMeaUcMpGsx4lo69B4RYQzcIhoK/wl0r4YjGNwt1FsrhvEMRvqZdSYt4M21GjBYAhPLPZSgZ/e7LoSmYtTvB8BuwjeiYrljq+r8cy5iya95YtGop5L58q3AsXNmh61mhKGhoGH+LFlAOA17E5QkfIO1R8k4YTv9wYR9M119l/OOrzAeqw18dYb2Oz9SOPKnOXTu3P4TFw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231023)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(6072148)(201708071742011); SRVR:VI1PR0501MB2047; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR0501MB2047; X-Forefront-PRVS: 05220145DE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(396003)(366004)(199004)(189003)(53936002)(2906002)(69596002)(7696005)(52116002)(68736007)(25786009)(36756003)(8936002)(50226002)(478600001)(51416003)(97736004)(5660300001)(4326008)(106356001)(3846002)(6116002)(1076002)(105586002)(16526018)(2950100002)(305945005)(7736002)(48376002)(6666003)(81156014)(81166006)(50466002)(8676002)(16586007)(76176011)(47776003)(66066001)(316002)(86362001)(386003)(59450400001)(55016002)(21086003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2047; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2047; 23:qSm5QTQFoECZx+qulYLXvmPW0zTy5zPG6A0aFQP?= Ub3KKI8m/yfOx/ta7tpxqSK5o21E75bVpxih3qPmfv2SRJzOxN9R197PftJceBHztg07x6r+T/T8IhdAVCscLIa7wwW+o2CAu6lzKbBZkXezrEi02QHbsBQ3S/vA6ArGyn2BFA/p9rll1vMJRQgJIywiR9dWELJh2D/+r7JMB58EeAeVU1tqFq35ypxa7rh7HGxvM7WITKDAuCBUyofm2oX+XN6xF0NcfPS4+KQsnmCSw+BkXz/NNu/wspVFOw9eQYt+7k30qAeYSwBqXptFSqTH3UNRv3wkLw+0+ktX/FC7YqXwsuAOCZzV2kucWzO8ieDe/p0ppj6MI/8DXsfx8QMuv+zwlFyjZob6Q5oPR7PeoohCI6G2timPvFhuccGBVtG2M2fCy9CuaGy/JDmpYtidrKwSH8fHrNri7YG1tptBMuaM5GlG7UmFfVP1mqFi6468qgTeIxRS0JyPFSKSrte3YEELgKGQxaj0IDtqAV5DfSSXp+99f7s8oynReZyIEU5nNUIg24YCdvz1RjolHi6BlgFbF3odXN2C82peQQEo9VSxUd38MsQYhuLnyFr/AppNJuGHOzHq+VmpaFFNp8hPlbWOlfpJnrTjyzGoStZYbHG11j41/wj467vN1/trL3l8+Cf9VTLkC61i67AT44nWN06KSrkZUYWkcayv3LrHuROXTzIqfWaNy9d6Ev/Q2Xmo48j5NkOtOGhUDXgJvCsT1sMfvLIZ1GOF2PIemt9PeESsB7OXVj1fU1ztzTi64eIBIFOvemLfdP/Q9ta3OEE4rZOHqKgXWft1OswVyKByaoLPHf8OMGwbUS1K8hypnX0k9khmbEPq5EU/A5TMmxwFRxvcIEhLSLUyZzJc+S+1Eo6fYfDd9nb4k1MXXIW5T71tLT7vBkkp7jWNqE3HhQF1gNCV2GLdjKO+PeKXax0K3bGhMFKNhvmzig5SahGXDn6i1A3FBvIMCt44zPWHmajpMCQJLL1rQOuIMcYi2U6qf6Duqz8b87pZMeQbogfX+eQs0FlR+X7F3evywBxWx8c2ldjLZ71FqvYmQvUUn823hvA== X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2047; 6:Fh9hvR76Bqq6xxm4hS/DMHVABszS+Dm9zuBi746w5w2YbuXPAAjLSLNdCXTtFRmj5tSy8eeLyw+9ozMzw2fZPgg1vEiZXSa97aoCIFdj2i6Aq4iqEUl4ciFdi6obaKNQrPDv+JgA2qkv9AjPfs7V9YGricp2in5gUpfza73vdf3PPdBkWwY8Zwa5yRMh/YczGSN6pkv9IgMtZaTdyDe8QlWB95bht5RBFkATbQLZASvaOuBrHyy28+ZMghTTYAVrg8cbFCJaIFIgMUnVKdgIIyPK1Mbe+KzqwZj5H58/NDxGTN7/wBmtoMTu/k9REHB/9l9sZwNCRdcPR8SXfJICCF/19Rldj60i7bjkz/+CWbY=; 5:xOltQSYbKqeoCgc3uUlWoNkjveUtXEbvV12LfXCqt0E3QpY0U4hIVOuQ5jqcaFlxb2dmIY9AaBqnhN6e7I4Vm1aikoWTeWkoWSONDjfZtZyL0ueTOwVf8pF5SJWpSBnV0DtIWpwqY2tQIvVmCDbwzrMrplrYllKIuO1VtW6kMD4=; 24:wUhV8/XynTOx2K3YBOztmhz9Rsg9eYf0Nslqi1J70seBTRmOZtxp0VykqDrg6ZkQtVu1QY5zGMd94BHeZVMWvpdzoYUjwuCcPunVbU0kQ1A=; 7:Wf+yopspnq8qbEucT5uqNrFLqh20pQFgialZjncesF+K6+22uHvfpRiVLxst9DLgDa3bg8BGM9pcbXQKbxgS38rkIo5xRBuZyGDyLoAkRCX1NIPCx38yMlxsuHXVQkp2Wp86KUQA206M2m6l9Nhv/Fyl+9j7wbgMaFUvjjO7hgvsIRG2fn2MbmtctF1YEQi3FLLJwMt6VbfICKUFfZH9IuIv7slCV6Evh92fC/dONGZDgsiNDh4H0iqAtY4rVaF9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2017 01:59:36.0400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a4118d1-c90f-47f7-c444-08d5435f7f1c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2047 Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix overflow of Memory Region cache X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If there're more MR(Memroy Region)'s than the size of per-queue cache, the cache can be overflowed and corrupt the following data structure in mlx5_txq_data. Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx queues") Cc: stable@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_trigger.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index ed80a6bee..88f60a01d 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -64,8 +64,11 @@ priv_txq_start(struct priv *priv) if (!txq_ctrl) continue; - LIST_FOREACH(mr, &priv->mr, next) + LIST_FOREACH(mr, &priv->mr, next) { priv_txq_mp2mr_reg(priv, &txq_ctrl->txq, mr->mp, idx++); + if (idx == MLX5_PMD_TX_MP_CACHE) + break; + } txq_alloc_elts(txq_ctrl); txq_ctrl->ibv = mlx5_priv_txq_ibv_new(priv, i); if (!txq_ctrl->ibv) {