From patchwork Fri Dec 15 01:59:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 32293 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B709014E8; Fri, 15 Dec 2017 02:59:39 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0085.outbound.protection.outlook.com [104.47.1.85]) by dpdk.org (Postfix) with ESMTP id 48D76107A; Fri, 15 Dec 2017 02:59:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OFqMb50yVQO8CeLEhWJwFKN5zTX7rR5BGM9QrEtVwQc=; b=dA2mHVOuKTpyZLd2wY8AHMLV0Nm7DB4LjwuFewUL0NDP04iPy6+gdRsr5CGVj4scN7Z+NN+yl5goatZUMlWLwtn8r6Su7VtiKtBN8+e39jKi6U55OLqi/gimK0vviEhCGeMdcd5fq59iRA6FI/b1v6ZSJj4ALu0k4cB70D4BKmk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2047.eurprd05.prod.outlook.com (2603:10a6:800:36::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Fri, 15 Dec 2017 01:59:33 +0000 From: Yongseok Koh To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, hhaim@cisco.com, Yongseok Koh , stable@dpdk.org Date: Thu, 14 Dec 2017 17:59:17 -0800 Message-Id: <20171215015918.30981-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: YQXPR0101CA0061.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:14::38) To VI1PR0501MB2047.eurprd05.prod.outlook.com (2603:10a6:800:36::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea0275a3-093b-4abf-1bc0-08d5435f7dd6 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307); SRVR:VI1PR0501MB2047; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2047; 3:ZoHoctpGEsWpMMmzwUO1i3rDdfcFrT+gIp0AG6fRScAIiPjx+bn3sx6AMCT0c5aYOIF8PgXlp55btY38KDIVYTCohLjtWJ1gJWmhdgQq8FIruobIcvWHEwjmooUQWCY1qwy+UBiGAm3eqQY7ApJ00sWCr5h/Eaf9or0R+EmQ0N5MkbxVBFb6TL1EZMBeB2vRSynVE0dEMGDV/HYGsZDelhqLApRbWtgy9ls8YwgGDP/9nSUuoknwWRwOCqAnDIfw; 25:fo3Sdzueb4MlKZ0jfJPmOBXk06PFqvF5e+MiHqrfq+/Y3Z8RoHfg7BIfj3+JmhTj/xic6nLGBdwS1EvnAEf6CrYRDIvTiovQxSAxhKiezyp9jGkUDQXq6LoCO8oDIgRPUMTBBP9FXVxIU3Ejh+7NlTPuPy6zpKX65g2hyyI7F23FZZ252fXmofQfOFrX9K6/v8Z+asqSCpJy2Ys6fRo+InwIS175GoY4wL/p1OgNyYJttT6rjbihlJoyZAUjdV/2TtAlYCjmo0KiLP3v806BsdyTiwEwzNqAGYIwnLCbeiNaDQIptp8VGebAApyjQH144aoTuEhRuXgCWQAzZVzn4g==; 31:FHtiewSPqu6K8RKYaixKVMN4Ic+4eI4P4UyRYOFZg2nTs+tju03TnfgfZuv987pWbjdoIReWRNPa4vfEk5mAnNFQGw+RrZjsA3f6V7lALt9/F3UbdyAVqiapyYGQDGdaxfFBVEr/SdO+3zzKZTqB6P4NXBybyOb4/knNzZiEGit2O/sQfAroW37qFqQqoIKb8lRb56sQ1Dv0FQNHChj3bIOsuUB2zitSX+23vhLqN6Q= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2047: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2047; 20:QuzwOPDOiVJtr0CTZebyHQXxi3BslyuEjyxvZQgJas3JcAqcKKkYO9pSKetH6VmeYcdSDg89gvQz8xOM7v5180gFisVViXvDlH/LhW6CUnBiJ96Xgx4yq8kRlJeSE0mJWqosbu+8EaMbMsEsbs3pnzsItKy2ynjtnGxtDNp1hgrISUwyOFs7GbtZLYwaeRD4SgLQMkA0liqP/zL9uA0U99iSQOQU68KxwN49kXxQyoaJwUyEUkzdu7xPxOxSaSRqZg9vD0SJcsL/hqkgb58ImKvbgyFpryAWYsn3l3Ra+n22wqvZc/zoxbq2vVTWOxrhLz2TL5dvbEvcXnc87IqjejxNgNwxmovGgC3HRY1paIof3YcOZ8AkTtfHgL21gtzHseBMfgYuNOgivMuQ0YLSKVqCOnl6vrdG+rCjz9Z7kvfEDSJfYa9jGcfaOkL7WJjAV6rzXRymtbTybV7iBoOjyz6yGcAxCGxBWSw3Ow9bdNlx6wjbP/lOhZlFspMEWlf7; 4:DKneF/eDJKktglsQbislwgykL/FSTGxv86Tkos7R13VHZFEWYiKkrHaEYmaTx1Ovh33VwmwirSJQkqCMLsFlQgXXMP0cw69UIL/wo2mh3z/KtZ4ot7X/3feMJ40biVmRFQPa5Wf5ohYSMsVY1ftpI/LgsXcuV4MVLs+WRV5axjhmGKY7pFXYCpZgrgjzDoTqHxXuxZKVyTUoZ7hzK2Eh3xJ6dTIm+NLumJ+Oe2rftfcMJMQEwzqRYUJ0EM7tQFGtH0oU+pLse7HfyPcDcbx3NJjkPyLOXcX72/YCTneFbpXNpPmRFLV2FdLJvV/4uyEP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(95692535739014); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231023)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(6072148)(201708071742011); SRVR:VI1PR0501MB2047; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR0501MB2047; X-Forefront-PRVS: 05220145DE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(396003)(366004)(199004)(189003)(53936002)(2906002)(69596002)(7696005)(52116002)(68736007)(25786009)(36756003)(8936002)(50226002)(478600001)(51416003)(97736004)(5660300001)(4326008)(106356001)(3846002)(6116002)(1076002)(105586002)(16526018)(305945005)(7736002)(48376002)(6666003)(81156014)(81166006)(50466002)(8676002)(16586007)(47776003)(66066001)(316002)(575784001)(86362001)(386003)(59450400001)(55016002)(21086003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2047; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2047; 23:OE6q0VWkvr/cyA/m4cmFNPCg/Wt/Teer6mTfDwW?= UKarHq8eB/5i0Y209zs76mfJ6sK4b3QeOfMWhTKYcppG8CF5KmOitjEU/EkDcPnFKqE4TNyHrrg71kWksE2TKHKXi029dciUoBgKo6DXkUSYZC0qrm4VaJLHEIPfloHOBPatPUgvpX7U4/DbPSH7qIet4Q/kMW9eiu/GR2IHMQwYSjgL2/xdXFrJwHKE5jLVO1B3P8zvszqtzyjQ1WlWhVQQbqN20xwjY8iIzcvhhIgbKbpjbrNvacKfiquizIuQb5+TtZ3hDjjYW9YhspiMQFauqUrvcyNaZBZxDcUmghI4wJA8kFgbEw4bbhkL7olLjFCpnK7m5mvOfXbcwlNDs8yV2EBuSQQNvYPUX0Evv0r7ouvINTAmbEA6VAHBmO1ZajwYJCDET0YmYPYNsWVJH3MNzHgJGnWbufBYdIG4IvLdlsM+5C1AGD5CclI55a2/4/0H+ivSkn7FEDWVuIH+I6jJcyGkfHOau1xyPL0egJyKV35xEujGiUwTTByiE07YZ1Gqh9RKTp7sxsKl+Z3/HSDGrJuasO13WBifYkc0LqVhL09s/grdc/ybznlHi3nVOIWZJ+prUI3xML6vpbS5JGGsNBWKGXUJKYLNIG7QoiGzvLvpdU+H7e7PDd0rhQf/whX2Wg0fHlHEe2dBPYW+mYHQJOH2ZSJOZwTcIYD7ccB9PI757w5RGU6OVtgVgFKXy8PZRBdcPLjXJ/P0/LyFH58laXGFBIyjIp34C4eBDnCGmzcdmyaqPZhqYCM2nyQqOs+Yy0HwRtyRT8H5qcaRAO8WGTzgNUIcqU0UBHKeXMhYF97vmz+kT1FwWxZQKZUjhnDbtB+JLImxFHCyjjzx4RgiEqUzaif9j4B4NehSax7VzW/r4LhoEMoRFzwRXPztqOICHn31MTYa1n03lb3bsnbD3NXTqDslY75/hoxq7m5K830vvxSGjJh+AadjVRzQPNGxZDk1cF1fk+OO1a6eXyEPDmkXXwzaD2fuUrPbB3f1Z7nd8ZCm8C4cLj5eAo5XcadY1QRvH2sdcb17HtUmrE+8E X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2047; 6:WCLncx+VAyvx1EAEIQTBzVJMPwjvOG4UFfT5Nc68irKh4tNGVGzMRThdM6fegjR75QIcUTnjxfyjua5FwJIxvc663mqp7e+gXI/9NdksSVvq8Y0CLkstKZQO1wvMAodUjBrLiztHZSnAJYblUoTWyL4D3tXgVXtczwBU+VGKEaLJiWQnzSSn+SsRoRVvGFZ7tNlnaMkfvjBlO991g6tjd3zlirDWBxBC1DdbWZbHDGTfLRTATtIe4wG8BENPp8H0r2lqLU2zN6N59YkZ/YEGPX0tB8DXmkOH5vOV11KkCaSxSrNl2/iz0Y48mbg0CEAiWkLlQEZfrNNsTkJ7eQ6xbl2oR/lWFppDLEDo6BOiw9s=; 5:elfHlufStmUVY8Ej6dcXD2sfaVAEJXdO0dsT5UWsJg3vsHCGFG09MnSyzR5lUf+cQh4xJfyEuhDJ7X4uLFsPTqt+UOKn175lx3qJzi/y6h73BTlVVBsA+pJw5rvrskdKqgcX6+WD8DJTv8DJYsMZM44n7cE+ywlWsTrmP2Y04Z8=; 24:KlgMmuzofdTaDHn3Q9GuWvM8MW07IMvtfCMNRcfEnVr5Nd8yt7czg4A2NU8outd+/WoOIKT8NQo5+BJ70A2m+pYdR4OMoSt7Z2Oa3kFQY+Y=; 7:CsIKgYPZEN/T4hPiUqsL/TlpkNqdY2Kb6+ZQx7/JSDzFQLEELw2x9PTqaxX6c74+QO/RX70l9rE+sqw4JOt81kOFqxjlFTWo6N9f0GdM6hTm/owBoQWhQjzPdmgsZk9SN+KLh44PyOCsrFYAd3Y5WwimsC8YGNsdz0bKyan4ZR5XNfoI+ER+ShrzWUD9iBchK7dKN9IJonpmCL8MFa5GIPDc03lWSRBFQWzCuFnHWLmtga2u2Thix8ebroc3UUvY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2017 01:59:33.8992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea0275a3-093b-4abf-1bc0-08d5435f7dd6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2047 Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix Memory Region registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Althought granularity of chunks in a mempool is a cacheline, addresses are extended to align to page boundary for performance reason in device when registering a MR (Memory Region). This could make some regions overlap, then can cause Tx completion error due to incorrect LKEY search. If the error occurs, the Tx queue will get stuck. To avoid it, end address of a packet segment is used in LKEY search. Fixes: b0b093845793 ("net/mlx5: use buffer address for LKEY search") Cc: stable@dpdk.org Reported-by: Hanoch Haim Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index b8c7925a3..b783ca203 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -543,7 +543,7 @@ static __rte_always_inline uint32_t mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb) { uint16_t i = txq->mr_cache_idx; - uintptr_t addr = rte_pktmbuf_mtod(mb, uintptr_t); + uintptr_t addr = rte_pktmbuf_mtod_offset(mb, uintptr_t, DATA_LEN(mb)); struct mlx5_mr *mr; assert(i < RTE_DIM(txq->mp2mr));