[dpdk-dev] i40e: remove warning

  Fix a printf warning which made the compilation fail when compiling
with GCC 7.2 and -Werror:

  error: format ‘%llu’ expects argument of type ‘long long unsigned int’,
  but argument 8 has type ‘u64 {aka long unsigned int}’ [-Werror=format=]

Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
 drivers/net/i40e/base/i40e_common.c | 2 +-
 drivers/net/i40e/base/i40e_nvm.c    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
  

> -----Original Message-----

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matteo Croce

> Sent: Thursday, December 14, 2017 1:23 PM

> To: dev@dpdk.org

> Subject: [dpdk-dev] [PATCH] i40e: remove warning

> 

> Fix a printf warning which made the compilation fail when compiling with GCC

> 7.2 and -Werror:

> 

>   error: format ‘%llu’ expects argument of type ‘long long unsigned int’,

>   but argument 8 has type ‘u64 {aka long unsigned int}’ [-Werror=format=]

> 

> Signed-off-by: Matteo Croce <mcroce@redhat.com>

> ---

>  drivers/net/i40e/base/i40e_common.c | 2 +-

>  drivers/net/i40e/base/i40e_nvm.c    | 6 +++---

>  2 files changed, 4 insertions(+), 4 deletions(-)

> 

> diff --git a/drivers/net/i40e/base/i40e_common.c

> b/drivers/net/i40e/base/i40e_common.c

> index 900d379ca..14834e8f2 100644

> --- a/drivers/net/i40e/base/i40e_common.c

> +++ b/drivers/net/i40e/base/i40e_common.c

> @@ -3929,7 +3929,7 @@ STATIC void i40e_parse_discover_capabilities(struct

> i40e_hw *hw, void *buff,

>  			p->wr_csr_prot = (u64)number;

>  			p->wr_csr_prot |= (u64)logical_id << 32;

>  			i40e_debug(hw, I40E_DEBUG_INIT,

> -				   "HW Capability: wr_csr_prot = 0x%llX\n\n",

> +				   "HW Capability: wr_csr_prot = 0x%lX\n\n",

>  				   (p->wr_csr_prot & 0xffff));

>  			break;

>  		case I40E_AQ_CAP_ID_NVM_MGMT:



wr_src_prot is a u64, which will translate to long long on 32-bit systems. This will likely trip over a similar warning in that case.
Should we instead use "HW Capability: wr_src_prot = 0x"PRIX64"\n\n"?

See inttypes.h for more info.
  

On Thu, Dec 14, 2017 at 9:15 PM, Kyle Larose <klarose@sandvine.com> wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matteo Croce
>> Sent: Thursday, December 14, 2017 1:23 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] i40e: remove warning
>>
>> Fix a printf warning which made the compilation fail when compiling with GCC
>> 7.2 and -Werror:
>>
>>   error: format ‘%llu’ expects argument of type ‘long long unsigned int’,
>>   but argument 8 has type ‘u64 {aka long unsigned int}’ [-Werror=format=]
>>
>> Signed-off-by: Matteo Croce <mcroce@redhat.com>
>> ---
>>  drivers/net/i40e/base/i40e_common.c | 2 +-
>>  drivers/net/i40e/base/i40e_nvm.c    | 6 +++---
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/i40e/base/i40e_common.c
>> b/drivers/net/i40e/base/i40e_common.c
>> index 900d379ca..14834e8f2 100644
>> --- a/drivers/net/i40e/base/i40e_common.c
>> +++ b/drivers/net/i40e/base/i40e_common.c
>> @@ -3929,7 +3929,7 @@ STATIC void i40e_parse_discover_capabilities(struct
>> i40e_hw *hw, void *buff,
>>                       p->wr_csr_prot = (u64)number;
>>                       p->wr_csr_prot |= (u64)logical_id << 32;
>>                       i40e_debug(hw, I40E_DEBUG_INIT,
>> -                                "HW Capability: wr_csr_prot = 0x%llX\n\n",
>> +                                "HW Capability: wr_csr_prot = 0x%lX\n\n",
>>                                  (p->wr_csr_prot & 0xffff));
>>                       break;
>>               case I40E_AQ_CAP_ID_NVM_MGMT:
>
>
> wr_src_prot is a u64, which will translate to long long on 32-bit systems. This will likely trip over a similar warning in that case.
> Should we instead use "HW Capability: wr_src_prot = 0x"PRIX64"\n\n"?
>
> See inttypes.h for more info.
>

Indeed. I'm making a v2 anyway because there are non printable color
codes from the GCC output