From patchwork Sat Dec 9 13:23:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh X-Patchwork-Id: 32053 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CF861AEEE; Sat, 9 Dec 2017 14:24:53 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0082.outbound.protection.outlook.com [104.47.36.82]) by dpdk.org (Postfix) with ESMTP id C0C12199B5 for ; Sat, 9 Dec 2017 14:24:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1VQ7NE2BdF7q4QKYyOsqA3ovYidfpa4Cl6CIeYy4Hnk=; b=Cd2zEG5rY2BgxdK4YrD1SblP7b7R4vS8wdSGubcIsKtHy2xPUBFFjkDIVdM8JhxSAHqNgJnfIKM2fIfkOUv1rVnTe0IRxtrLaJi5MmTwMh5oQ7ET8gVAczhSd3eK83wtBho71UYofk3hxwjaX0mQvJoRvqGtEl+3KEFz/5efm1M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from localhost.localdomain (103.16.71.47) by BN6PR07MB3460.namprd07.prod.outlook.com (10.161.153.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Sat, 9 Dec 2017 13:24:48 +0000 From: Pavan Nikhilesh To: ferruh.yigit@intel.com, olivier.matz@6wind.com, thomas@monjalon.net Cc: dev@dpdk.org, Pavan Nikhilesh Date: Sat, 9 Dec 2017 18:53:58 +0530 Message-Id: <20171209132358.24263-3-pbhagavatula@caviumnetworks.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171209132358.24263-1-pbhagavatula@caviumnetworks.com> References: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com> <20171209132358.24263-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [103.16.71.47] X-ClientProxiedBy: SG2PR0601CA0013.apcprd06.prod.outlook.com (10.170.128.23) To BN6PR07MB3460.namprd07.prod.outlook.com (10.161.153.23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1316865d-80ef-4ee6-aca0-08d53f0839d8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:BN6PR07MB3460; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 3:fXf1qf8owggamWy03iMHRFNs2JjKvwSYIz6WcX7o9uUjea3a8NxNE0QuQeSVtTD7ynB0/lKWoPybPgJGVWtA6780U6HkvUC5hd7QJTu45pfjOpnjFiwSrOu7CdKnGonJWHp8pfa2kRLWyzjBNxgpOVyzuy/KQ0tcbgUHz0/X+cCgV6t1z6OYv/kcjbeE87bDqFNUgEUsRPEIYK3nNyiQ4qdCedPEn1Wj7FPvtnT4hJJA46lMUeV28H1b8fmkx1lD; 25:WRGSnsjzyiKucZ2aAl2X/9Xo2rFzcgXYzlvRm/wp5eLzj+s/7c2w9CAndlXaibOboXLPNp3NSubvMtfYAY6Ml9LlQ7QzCgXpMo9Su59Wu4eEdTx3+pn8g0ovnxKp6PPOs1b8p0HqZcOzWNdzPp4dOr4gpipQtcVro8nnq4lBHipKP0CEfi9xELLXOCAuHYKKf0zGx0udL3lZ42E82yLA1VLT+teiMXx94QEjJBaUlOXIl7yiML2um3wgwMuiTTK9MAJF6gG5rqWr6IChoG8y4woDoNNE8b2g4vxvJ7+114ex5y9XQVUbXCwgKW25byS67ffOcKDMjqy/1gXt7js8Bw==; 31:fKzNfC+6L3vVtRy105NXmclCoMWmOVDYC6ip+bNP7W+S5PbqLbBaHM6G3wGk8tIpAMrVm+roW+603gSyVeQCbyzBkfqSa758jS8L4hfjNqVmU/vxpjdDvbp5nUxTnPSFPm2yN0GGFQeZqktsMWMZuiditePVm0ojk181bG6iSQDxHRFWGlqgp19mhVKkq8nxlFgPvJBdE64pjPQV1n87DXjYb/6EXDpGQdH+O69G/2U= X-MS-TrafficTypeDiagnostic: BN6PR07MB3460: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 20:zFAM3P0o7/Bdy9M2DEPbPqChFRUqZk7TCAl1qEkFI/cCTHQSLVr4vvGcN3EeA6/Hu3tUx7dPeIaYe6OaatanSMUMbAkS2hGkb2nh2nZBdXPSswKey8yDyWAjt9mXyspancveHinlcXEzxkKIRxckW73y2MQfb4Jk6fKfvSI+c1WzLfP3zUk7OskufhBRMjIDFiqOtC83v3B9lWCi0KrAd3yuzVoOuazBZSJcbjTxI0P08L6X5v2LbSrK5yMZrboBwxcOgudkLRmWKL3gh/BtgI2vFAo7aADK3UnGJVc/LQj6ggiLakB3vieApYTkpJhv9GpeNeEEcavdG1tRqFz7KumoOvsHj3RzQZ07XRCdOrm7StDzlx/bONvgwHDz8/SYFkddcEV2lUmOT6vuzLRQVrLNukH4Llu7OIfpgV6b1Y4yjafoISTbS5JIVOSx6HuGCMrckJv8UsoJclnSHEVugnyh5b3ZMJckDz/ZfyBj3dRdAj41QZtzCayecsXJ8Ek1VZX3+/MsHiQNwpy23kReOHG5Nibx0A1KfdPN27wm2ImexQPLCiqqZ7Ph9lgVwbHehJ9afNYOX2IKDOY6M+1QNoV73YDuiQWW5huJoDi8q6E=; 4:rqklBNuTvu7yy/gYiqmouIJlfLckgurOtJ1oxttujE6Pl1rk3MkvKnZ2/DZTXdLOoEg706k/AYHpkBsvrg+qco5JkOKMoVOglqfQxqufDsN4CJOCeA/1UqtNQaQQUR+6U3yXd1/D1ryiw3ThK2mJNviSvhZvg3LTNlwkDmd3zGorkiAxooqj6wgu6Ob+GTesUHo5uGOfQgIeiAJa8f1W513NJETM9g47j4yPkEsqTlgyZQ+Dibf0Ye2gV7PZ+ZwoNpm5d0fjWp94A8wcoOq26A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(10201501046)(93006095)(3002001)(6041248)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011); SRVR:BN6PR07MB3460; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN6PR07MB3460; X-Forefront-PRVS: 05168A3970 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(366004)(376002)(346002)(189003)(199004)(305945005)(2906002)(68736007)(16586007)(1076002)(16526018)(6666003)(2950100002)(5660300001)(42882006)(316002)(81156014)(50226002)(97736004)(81166006)(8676002)(52116002)(8936002)(6116002)(7736002)(51416003)(72206003)(3846002)(478600001)(25786009)(33646002)(107886003)(6512007)(76176011)(4326008)(53936002)(47776003)(66066001)(6506006)(6486002)(48376002)(50466002)(105586002)(106356001)(36756003)(59450400001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3460; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3460; 23:9cs+Iri/9qxsRbpyIKLdFTqlVUkeLkopfw0nSWP8p?= KjXZeIxSoeCSuVPcslEIzMryfFllp+BypS4ETgCnUAS8niMEuC3r2i0fUvozlyK598xj2s6Xk8A5NmlVZjT/M5eG/HItOeM4K0JZN8tlTjRz6vPGMKL91j4P05XoNkn6cHViqtL2RJ4hbXrhCLXGG8Lbopa1NegeJLyK4A4NLD2V6sFQDLQiOlhl6h2/FBwJuXF8gMNiqlVugjCdBvJm7oPnylWatS6PHilFqu4ZxOLussv4li6SEcNxDnQW3Ce7AbZJhd+k5BL8sPD4KaL98XHXFsVaPMedaZ3SQfZDKM00JsINpppeyywlaWQ5zXVd49hF/6J8wlKJ8pwQRH/vxtLN/SIZ+p30g46kVdgpFo3TF3yvJ74sWT+WeSF0CmQJGz0Cr/JfG6CzdJUKWJWWslfGlEQdbaqEgrDwIRJ0lTne+ZBD5lapL60OU7PCsXnsDGwEICLIsjQmQtokpaRcFJr+a2XD3uB+IN9eF07oHTgIPA7dpKlBttXBfCzqRyeygPF2fe7sDTagiuxyNFT2YxN0lLjhlr0FWYSA4Mm7XMrKqi2Ekhh46MzOJcXT6oWExKeap8gT0+qn3mXI1T/PInwLnQ7ZktBipFsRLllpj/MFaC9KXQNcFADQzZ/eXrrmgpHvJlVDckyZ2/0L/K6lo0zaXc3cFXlJsgJ2R5K+V/HjMW7jmtGuSZJtHkzkX3kBPwmLiIiinpmnmBu7WdNu4tpRrq6KRXsyIIIG4FfO2BtAb87XdO9HID7SkXpOtcqoeON24Uf9QLOvxAANeFSVPOzJF8KxIIQCQZ94sElKOKeEGuHHh8KcD72PJzWflVWjwhcCy1pDCIWN4S9JYhx5o4EToZKBVg2wtanfix7L3iGyaNpDfyaZeMJZyPTOuxmOu9swTz9AY+hE0iU2yvEZHtCvwagwzilgMDHpG5/+GOVlPgk/sqUObTGrFEsx8m/RZ9iU4FGCTvdnlh/73Nm+aDGyKksPwAnbHKzdfPKPDMB2l7yLxAym1kLdA12gpNF+n3P9bPFu/HU4QrzkXq4av+6woItnmHMmOryHeCE2Ic9dD8aOEQI/pmTngAiB/y0hb4= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 6:lY6XpQA5ObNzMmupqXvnPaBGCeCefnExiOwFQ0e47iRoDmeAjEUvRxKv73Kfk7QMZfFbqVEq3t/LNp7vw8XXfOfGfalWshX7ilWmwHssv+BdPHcFtQTiTtvdo96S+C5xWf8Shmuc3Np+uQhs5xSQi1zIKN/udYGvbuLRLePaRY2Fct44KGQjnQL8D8d0EOm/hVVg2Eb4iMFzn5DIcGLP/bBtm9ECBch2eGS4ut8v4bK0AZ+4KgMQV2e2quDoUbxbk8Z3I3ZA3aXhNIDiZzH+qCwDXhMHZd74C5AY21bwn3raRWY8KHEeEzDYUJPNmjKfJ/iVPgCFVZzR66S7P920rhuHp2jVRZ/h6/ty37q66Dc=; 5:fTzBVbWEMsyb39hXu0IluD44/NgPvEVlP6qIZG/YHLW5dIhkbG3HdW+rvcnwu9OVKm8mvhP+PdJTb1imXzu1EpdLSGGCWsQdXfGWp+4FfIBNOaebfuAX+EOnVR3q4/VdjkEGfWHUzE3MF7ffZNkgUXsI7OyV/x6UI4rVKSBZ738=; 24:O+XZHvzrvBWEGnNLuk/Gu9gt2/wNy4hAT90oYeZnjtfoInihyhI2sDZ+6G/JgRBCb8W+k52DmrP+bSLgypQaFd0aUWxYt+ZN2h8lqaeRmK4=; 7:IVodhNOEsb930aj4AFzRXCSe9QKX5mNk6IIooNv2+hvFTLFnPOs7cZNOISSZVg1xOKauI9oKS6TwwRTvXnaJ/VOxX2MXX+y+aReHEP84UNm0MCAbqKfDwslieBtP/BF1gosidWn3aN4UHL8quvKQHHEsRogEJkz9IwD41qcdn3h/obhdfNND3y3ei3rWmFtHYHLZMYZKDlHbcxAoZQ7LTxNLaT/mddTwuNqo9DNz69jRjlh+CBdHfJeB45ykEKBG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2017 13:24:48.7770 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1316865d-80ef-4ee6-aca0-08d53f0839d8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3460 Subject: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config option for controlling datapath log level. RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to control global and module specific log levels. Signed-off-by: Pavan Nikhilesh Reviewed-by: Olivier Matz --- config/common_base | 1 - devtools/test-build.sh | 2 +- doc/guides/faq/faq.rst | 3 --- drivers/net/ena/base/ena_plat_dpdk.h | 2 +- drivers/net/sfc/sfc_debug.h | 2 +- examples/l3fwd-acl/main.c | 2 +- 6 files changed, 4 insertions(+), 8 deletions(-) diff --git a/config/common_base b/config/common_base index e74febef4..e7af26cc8 100644 --- a/config/common_base +++ b/config/common_base @@ -94,7 +94,6 @@ CONFIG_RTE_MAX_MEMSEG=256 CONFIG_RTE_MAX_MEMZONE=2560 CONFIG_RTE_MAX_TAILQ=32 CONFIG_RTE_ENABLE_ASSERT=n -CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO CONFIG_RTE_LOG_HISTORY=256 CONFIG_RTE_BACKTRACE=y diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 092d3a7f3..7e9e1e187 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -157,7 +157,7 @@ config () # ! echo $3 | grep -q '+shared' || \ sed -ri 's,(SHARED_LIB=)n,\1y,' $1/.config ! echo $3 | grep -q '+debug' || ( \ - sed -ri 's,(RTE_LOG_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config + sed -ri 's,(RTE_LOG_DP_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config sed -ri 's,(_DEBUG.*=)n,\1y,' $1/.config sed -ri 's,(_STAT.*=)n,\1y,' $1/.config sed -ri 's,(TEST_PMD_RECORD_.*=)n,\1y,' $1/.config ) diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index dac805099..55dcfe9c2 100644 --- a/doc/guides/faq/faq.rst +++ b/doc/guides/faq/faq.rst @@ -103,9 +103,6 @@ Yes, the option ``--log-level=`` accepts one of these numbers: #define RTE_LOG_INFO 7U /* Informational. */ #define RTE_LOG_DEBUG 8U /* Debug-level messages. */ -It is also possible to change the default level at compile time -with ``CONFIG_RTE_LOG_LEVEL``. - How can I tune my network application to achieve lower latency? --------------------------------------------------------------- diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h index accecf518..8cba319eb 100644 --- a/drivers/net/ena/base/ena_plat_dpdk.h +++ b/drivers/net/ena/base/ena_plat_dpdk.h @@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t; #define ENA_GET_SYSTEM_USECS() \ (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz()) -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #define ENA_ASSERT(cond, format, arg...) \ do { \ if (unlikely(!(cond))) { \ diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h index 92eba9c38..3f9ccf1e6 100644 --- a/drivers/net/sfc/sfc_debug.h +++ b/drivers/net/sfc/sfc_debug.h @@ -35,7 +35,7 @@ #include #ifdef RTE_LIBRTE_SFC_EFX_DEBUG -/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check +/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check * in the driver only. */ #define SFC_ASSERT(exp) RTE_VERIFY(exp) diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index e50b1a1a8..eb78decdd 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -68,7 +68,7 @@ #include #include -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #define L3FWDACL_DEBUG #endif #define DO_RFC_1812_CHECKS