[dpdk-dev,29/39] examples/vm_power_manager: convert to new offloads API
Checks
Commit Message
Ethdev offloads API has changed since:
commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
This commit support the new API.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
examples/vm_power_manager/main.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
Comments
On 23/11/2017 12:19 PM, Shahaf Shuler wrote:
> Ethdev offloads API has changed since:
>
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
>
> This commit support the new API.
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> examples/vm_power_manager/main.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
> index 399fbdd43..53d587d83 100644
> --- a/examples/vm_power_manager/main.c
> +++ b/examples/vm_power_manager/main.c
> @@ -74,7 +74,10 @@ static volatile bool force_quit;
>
> /****************/
> static const struct rte_eth_conf port_conf_default = {
> - .rxmode = { .max_rx_pkt_len = ETHER_MAX_LEN }
> + .rxmode = {
> + .max_rx_pkt_len = ETHER_MAX_LEN,
> + .ignore_offload_bitfield = 1,
> + }
> };
>
> static inline int
> @@ -84,6 +87,8 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)
> const uint16_t rx_rings = 1, tx_rings = 1;
> int retval;
> uint16_t q;
> + struct rte_eth_dev_info dev_info;
> + struct rte_eth_txconf txq_conf;
>
> if (port >= rte_eth_dev_count())
> return -1;
> @@ -101,10 +106,13 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)
> return retval;
> }
>
> + rte_eth_dev_info_get(port, &dev_info);
> + txq_conf = dev_info.default_txconf;
> + txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
> /* Allocate and set up 1 TX queue per Ethernet port. */
> for (q = 0; q < tx_rings; q++) {
> retval = rte_eth_tx_queue_setup(port, q, TX_RING_SIZE,
> - rte_eth_dev_socket_id(port), NULL);
> + rte_eth_dev_socket_id(port), &txq_conf);
> if (retval < 0)
> return retval;
> }
Looks good to me.
Acked-by: David Hunt <david.hunt@intel.com>
@@ -74,7 +74,10 @@ static volatile bool force_quit;
/****************/
static const struct rte_eth_conf port_conf_default = {
- .rxmode = { .max_rx_pkt_len = ETHER_MAX_LEN }
+ .rxmode = {
+ .max_rx_pkt_len = ETHER_MAX_LEN,
+ .ignore_offload_bitfield = 1,
+ }
};
static inline int
@@ -84,6 +87,8 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)
const uint16_t rx_rings = 1, tx_rings = 1;
int retval;
uint16_t q;
+ struct rte_eth_dev_info dev_info;
+ struct rte_eth_txconf txq_conf;
if (port >= rte_eth_dev_count())
return -1;
@@ -101,10 +106,13 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)
return retval;
}
+ rte_eth_dev_info_get(port, &dev_info);
+ txq_conf = dev_info.default_txconf;
+ txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
/* Allocate and set up 1 TX queue per Ethernet port. */
for (q = 0; q < tx_rings; q++) {
retval = rte_eth_tx_queue_setup(port, q, TX_RING_SIZE,
- rte_eth_dev_socket_id(port), NULL);
+ rte_eth_dev_socket_id(port), &txq_conf);
if (retval < 0)
return retval;
}