diff mbox

[dpdk-dev] net/bnxt: donot set hash type unnecessarily

Message ID 20171027023024.42707-1-ajit.khaparde@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ajit Khaparde Oct. 27, 2017, 2:30 a.m. UTC 
  We are wrongly "OR-ing" the vnic->hash_type instead of assigning
the new hash type thereby wrongly configuring hash settings.
Fixing it.

Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration")

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_rxq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Oct. 31, 2017, 12:32 a.m. UTC | #1 
On 10/26/2017 7:30 PM, Ajit Khaparde wrote:
> We are wrongly "OR-ing" the vnic->hash_type instead of assigning
> the new hash type thereby wrongly configuring hash settings.
> Fixing it.
> 
> Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration")
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index 67d9bfe9d..c4da474e9 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -206,7 +206,7 @@  int bnxt_mq_rx_configure(struct bnxt *bp)
 
 		for (i = 0; i < bp->nr_vnics; i++) {
 			STAILQ_FOREACH(vnic, &bp->ff_pool[i], next) {
-			vnic->hash_type |= hash_type;
+			vnic->hash_type = hash_type;
 
 			/*
 			 * Use the supplied key if the key length is