diff mbox

[dpdk-dev,1/2] drivers: fix shared build error for DPAA crypto

Message ID 20171026140906.10347-1-shreyansh.jain@nxp.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shreyansh Jain Oct. 26, 2017, 2:09 p.m. UTC 
  Various symbols are being used by DPAA Crypto driver which were not exposed
from DPAA bus during initial version. This breaks the shared build.

This patch also adds the LDLIBS line required after (cbc12b0a9) patch.

Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
Cc: akhil.goyal@nxp.com

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/bus/dpaa/rte_bus_dpaa_version.map | 9 +++++++++
 drivers/crypto/dpaa_sec/Makefile          | 2 ++
 2 files changed, 11 insertions(+)

Comments

Akhil Goyal Oct. 26, 2017, 2:10 p.m. UTC | #1 
On 10/26/2017 7:39 PM, Shreyansh Jain wrote:
> Various symbols are being used by DPAA Crypto driver which were not exposed
> from DPAA bus during initial version. This breaks the shared build.
> 
> This patch also adds the LDLIBS line required after (cbc12b0a9) patch.
> 
> Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
> Cc: akhil.goyal@nxp.com
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
>   drivers/bus/dpaa/rte_bus_dpaa_version.map | 9 +++++++++
>   drivers/crypto/dpaa_sec/Makefile          | 2 ++
>   2 files changed, 11 insertions(+)
> 
> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> index 64a05a9..fb9d532 100644
> --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map
> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> @@ -40,14 +40,23 @@ DPDK_17.11 {
>   	fman_ip_rev;
>   	netcfg_acquire;
>   	netcfg_release;
> +	of_find_compatible_node;
> +	of_get_property;
> +	qm_channel_caam;
>   	qman_create_fq;
>   	qman_dequeue;
>   	qman_dqrr_consume;
> +	qman_enqueue;
>   	qman_enqueue_multi;
> +	qman_fq_fqid;
> +	qman_fq_state;
>   	qman_global_init;
>   	qman_init_fq;
> +	qman_poll_dqrr;
> +	qman_query_fq_np;
>   	qman_set_vdq;
>   	qman_reserve_fqid_range;
> +	qman_volatile_dequeue;
>   	rte_dpaa_driver_register;
>   	rte_dpaa_driver_unregister;
>   	rte_dpaa_mem_ptov;
> diff --git a/drivers/crypto/dpaa_sec/Makefile b/drivers/crypto/dpaa_sec/Makefile
> index 9a061b4..17bc79c 100644
> --- a/drivers/crypto/dpaa_sec/Makefile
> +++ b/drivers/crypto/dpaa_sec/Makefile
> @@ -53,6 +53,8 @@ CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa_sec/
>   CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/
>   CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
>   CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal
> +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> +LDLIBS += -lrte_cryptodev
>   
>   # versioning export map
>   EXPORT_MAP := rte_pmd_dpaa_sec_version.map
> 
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Thomas Monjalon Oct. 26, 2017, 9:06 p.m. UTC | #2 
26/10/2017 16:10, Akhil Goyal:
> On 10/26/2017 7:39 PM, Shreyansh Jain wrote:
> > Various symbols are being used by DPAA Crypto driver which were not exposed
> > from DPAA bus during initial version. This breaks the shared build.
> > 
> > This patch also adds the LDLIBS line required after (cbc12b0a9) patch.
> > 
> > Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
> > Cc: akhil.goyal@nxp.com
> > 
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map
index 64a05a9..fb9d532 100644
--- a/drivers/bus/dpaa/rte_bus_dpaa_version.map
+++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
@@ -40,14 +40,23 @@  DPDK_17.11 {
 	fman_ip_rev;
 	netcfg_acquire;
 	netcfg_release;
+	of_find_compatible_node;
+	of_get_property;
+	qm_channel_caam;
 	qman_create_fq;
 	qman_dequeue;
 	qman_dqrr_consume;
+	qman_enqueue;
 	qman_enqueue_multi;
+	qman_fq_fqid;
+	qman_fq_state;
 	qman_global_init;
 	qman_init_fq;
+	qman_poll_dqrr;
+	qman_query_fq_np;
 	qman_set_vdq;
 	qman_reserve_fqid_range;
+	qman_volatile_dequeue;
 	rte_dpaa_driver_register;
 	rte_dpaa_driver_unregister;
 	rte_dpaa_mem_ptov;
diff --git a/drivers/crypto/dpaa_sec/Makefile b/drivers/crypto/dpaa_sec/Makefile
index 9a061b4..17bc79c 100644
--- a/drivers/crypto/dpaa_sec/Makefile
+++ b/drivers/crypto/dpaa_sec/Makefile
@@ -53,6 +53,8 @@  CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa_sec/
 CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/
 CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
 CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
+LDLIBS += -lrte_cryptodev
 
 # versioning export map
 EXPORT_MAP := rte_pmd_dpaa_sec_version.map