From patchwork Tue Oct 24 21:19:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 30835 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F06D61B92C; Tue, 24 Oct 2017 23:20:38 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id DD68C1B891 for ; Tue, 24 Oct 2017 23:20:06 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.224.233]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id B7E3530C035; Tue, 24 Oct 2017 14:20:05 -0700 (PDT) Received: from C02PT1RBG8WP.vpn.broadcom.net (unknown [10.10.118.158]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 3772981EAD; Tue, 24 Oct 2017 14:20:05 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Tue, 24 Oct 2017 16:19:48 -0500 Message-Id: <20171024211953.12021-11-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.13.5 (Apple Git-94) In-Reply-To: <20171024211953.12021-1-ajit.khaparde@broadcom.com> References: <7b5c8ca8-7523-add0-0cca-826278496a19@intel.com> <20171024211953.12021-1-ajit.khaparde@broadcom.com> Subject: [dpdk-dev] [PATCH v2 10/15] net/bnxt: fix a potential null pointer dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Coverity issue: 195017 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c index af9ed9a62..65d30fb38 100644 --- a/drivers/net/bnxt/bnxt_filter.c +++ b/drivers/net/bnxt/bnxt_filter.c @@ -793,6 +793,8 @@ bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf, //This flow needs DST MAC which is not same as port/l2 RTE_LOG(DEBUG, PMD, "Create L2 filter for DST MAC\n"); filter1 = bnxt_get_unused_filter(bp); + if (filter1 == NULL) + return NULL; filter1->flags = HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX; filter1->enables = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR | L2_FILTER_ALLOC_INPUT_EN_L2_ADDR_MASK;