From patchwork Tue Oct 24 09:09:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jasvinder Singh X-Patchwork-Id: 30765 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 442E31B77C; Tue, 24 Oct 2017 10:57:24 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4074C1B779; Tue, 24 Oct 2017 10:57:22 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 24 Oct 2017 01:57:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.43,427,1503385200"; d="scan'208"; a="1234510616" Received: from silpixa00381635.ir.intel.com (HELO silpixa00381635.ger.corp.intel.com) ([10.237.222.149]) by fmsmga002.fm.intel.com with ESMTP; 24 Oct 2017 01:57:19 -0700 From: Jasvinder Singh To: dev@dpdk.org Cc: cristian.dumitrescu@intel.com, ferruh.yigit@intel.com, john.mcnamara@intel.com, stable@dpdk.org Date: Tue, 24 Oct 2017 10:09:57 +0100 Message-Id: <20171024090957.114392-1-jasvinder.singh@intel.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171023103600.89883-1-jasvinder.singh@intel.com> References: <20171023103600.89883-1-jasvinder.singh@intel.com> Subject: [dpdk-dev] [PATCH] examples/qos_sched: fix uninitialized scalar variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix problem with uninitialized rx/tx deferred_start flags of the struct rte_eth_rxconf/txconf by initializing with 0 value (deferred start of the rx/tx queues is turned off). This setting allows device rx/tx queues to start with rte_eth_dev_start(). Coverity issue: 194999, 195009 (Uninitialized scalar variable) Fixes: de3cfa2c9823 ("sched: initial import") Cc: stable@dpdk.org Signed-off-by: Jasvinder Singh --- examples/qos_sched/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 004ac54..038f042 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -118,6 +118,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) rx_conf.rx_thresh.wthresh = rx_thresh.wthresh; rx_conf.rx_free_thresh = 32; rx_conf.rx_drop_en = 0; + rx_conf.rx_deferred_start = 0; tx_conf.tx_thresh.pthresh = tx_thresh.pthresh; tx_conf.tx_thresh.hthresh = tx_thresh.hthresh; @@ -125,6 +126,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) tx_conf.tx_free_thresh = 0; tx_conf.tx_rs_thresh = 0; tx_conf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS; + tx_conf.tx_deferred_start = 0; /* init port */ RTE_LOG(INFO, APP, "Initializing port %"PRIu16"... ", portid);