From patchwork Fri Oct 20 16:55:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 30654 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CEE6A1B291; Fri, 20 Oct 2017 18:55:21 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 087721B291; Fri, 20 Oct 2017 18:55:19 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2017 09:55:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.43,405,1503385200"; d="scan'208"; a="1233237423" Received: from silpixa00372839.ir.intel.com (HELO silpixa00372839.ger.corp.intel.com) ([10.237.222.154]) by fmsmga002.fm.intel.com with ESMTP; 20 Oct 2017 09:55:16 -0700 From: Ferruh Yigit To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, Jianfeng Tan , Jingjing Wu , Shijith Thotton , Gregory Etelson , Harish Patil , George Prekas , Sergio Gonzalez Monroy Date: Fri, 20 Oct 2017 17:55:11 +0100 Message-Id: <20171020165511.47899-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: References: Subject: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove device reset during application start, the reset for application exit still there. Reset in open removed because of following comments: 1- Device reset not completed when VF driver loaded, which cause VF PMD initialization error. Adding delay can solve the issue but will increase driver load time. 2- Reset will be issues all devices unconditionally, not very efficient way. Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Tested-by: Harish Patil Tested-by: Shijith Thotton Tested-by: Jingjing Wu --- Cc: Jianfeng Tan Cc: Jingjing Wu Cc: Shijith Thotton Cc: Gregory Etelson Cc: Harish Patil Cc: George Prekas Cc: Sergio Gonzalez Monroy --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index f7ef82554..fd320d87d 100644 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c @@ -336,8 +336,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode) struct pci_dev *dev = udev->pdev; int err; - pci_reset_function(dev); - /* set bus master, which was cleared by the reset function */ pci_set_master(dev);